Encrypt message content by default

Migrate unencrypted messages to encrypted message rich text content and drop old unencrypted column.

Author: rsmithlal

app/models/better_together/message.rb

@@ -6,6 +6,8 @@ class Message < ApplicationRecord
     belongs_to :conversation, touch: true
     belongs_to :sender, class_name: 'BetterTogether::Person'
 
+    has_rich_text :content, encrypted: true
+
     validates :content, presence: true
 
     after_create_commit do
@@ -16,5 +18,9 @@ class Message < ApplicationRecord
                                                        created_at: created_at.strftime('%H:%M %d-%m-%Y')
                                                      })
     end
+
+    # def content
+    #   super || self[:content]
+    # end
   end
 end

app/views/better_together/messages/_form.html.erb

@@ -1,8 +1,8 @@
 <!-- app/views/messages/_form.html.erb -->
 <%= form_with(model: [conversation, message], local: false, html: { id: "new_message", data: { controller: "better_together--message-form" } }) do |form| %>
-  <div class="input-group">
-    <%= form.text_area :content, class: 'form-control', rows: 1, placeholder: t('better_together.messages.form.placeholder'), required: true, "data-better_together--message-form-target": "content" %>
-    <button class="btn btn-primary" type="submit">
+  <div class="message-box d-flex flex-column">
+    <%= form.rich_text_area :content, class: 'form-control', rows: 1, placeholder: t('better_together.messages.form.placeholder'), required: true, "data-better_together--message-form-target": "content" %>
+    <button class="btn btn-primary ms-auto mt-2" type="submit">
       <%= t('better_together.messages.form.send') %> <i class="fas fa-paper-plane"></i>
     </button>
   </div>

db/migrate/20241025144852_remove_messages_content_column_null.rb

@@ -0,0 +1,5 @@
+class RemoveMessagesContentColumnNull < ActiveRecord::Migration[7.1]
+  def change
+    change_column_null :better_together_messages, :content, true
+  end
+end

db/migrate/20241025145238_remove_action_text_rich_texts_locale_column_null.rb

@@ -0,0 +1,5 @@
+class RemoveActionTextRichTextsLocaleColumnNull < ActiveRecord::Migration[7.1]
+  def change
+    change_column_null :action_text_rich_texts, :locale, true
+  end
+end

db/migrate/20241025150018_migrate_unencrypted_message_content_and_drop_column.rb

@@ -0,0 +1,12 @@
+class MigrateUnencryptedMessageContentAndDropColumn < ActiveRecord::Migration[7.1]
+  def change
+    reversible do |dir|
+      dir.up do
+        load 'tasks/data_migration.rake'
+        Rake::Task['better_together:migrate_data:unencrypted_messages'].invoke
+
+        remove_column :better_together_messages, :content, if_exists: true
+      end
+    end
+  end
+end

lib/tasks/data_migration.rake

@@ -44,5 +44,16 @@ namespace :better_together do
         end
       end
     end
+
+    desc 'migrates unencrypted message content to encrypted rich text'
+    task unencrypted_messages: :environment do
+      BetterTogether::Message.all.each do |message|
+        next if message.content.persisted? || message[:content].nil?
+
+        message.content = message[:content]
+
+        message.save
+      end
+    end
   end
 end