Fix loading of stimulus controllers

Author: rsmithlal

app/javascript/better_together/application.js

@@ -14,19 +14,15 @@
 //= require popper
 //= require bootstrap-sprockets
 //= require better_together/tooltips
-// require_tree .
 
 import { Turbo } from '@hotwired/turbo-rails'
-// import 'trix'
-// import { start as startActionText } from '@rails/actiontext'
+import './better_together/controllers'
 
-import { application } from 'better_together/controllers'
 // import 'better_together/trix-extensions/richtext'
+// import 'trix'
+// import { start as startActionText } from '@rails/actiontext'
 
 // Turbo.session.drive = false
 
-console.log('initializing engine')
-
-// window.Stimulus = application
+// console.log('initializing engine')
 
-export { application }

app/javascript/better_together/controllers/application.js

@@ -0,0 +1,9 @@
+import { Application } from "@hotwired/stimulus"
+
+const application = Application.start()
+
+// Configure Stimulus development experience
+application.debug = false
+window.Stimulus   = application
+
+export { application }

app/javascript/better_together/controllers/index.js

@@ -1,29 +1,5 @@
+import { application } from './controllers/application'
 
-import { Application } from "@hotwired/stimulus"
-import FlashController from "./flash_controller"
-// import ModalController from "./modal_controller"
-import DynamicSelectController from "./dynamic_select_controller"
-import NewPersonCommunityMembershipController from "./new_person_community_membership_controller"
-import PersonCommunityMembershipController from "./person_community_membership_controller"
-
-const application = Application.start()
-
-// Configure Stimulus development experience
-application.debug = true
-window.Stimulus   = application
-
-console.log('start application')
-
-Stimulus.register('flash', FlashController)
-// Stimulus.register('modal', ModalController)
-Stimulus.register('bt-dynamic-select', DynamicSelectController)
-Stimulus.register('bt-new-person-community-membership', NewPersonCommunityMembershipController)
-Stimulus.register('bt-person-community-membership', PersonCommunityMembershipController)
-
-// Lazy load controllers as they appear in the DOM (remember not to preload controllers in import map!)
-import { lazyLoadControllersFrom } from 'stimulus-loading' // Adjust the path if necessary
-lazyLoadControllersFrom("controllers", application)
-
-console.log('initializing engine controllers')
-
-export { application }
+// Eager load all controllers defined in the import map under controllers/**/*_controller
+import { lazyLoadControllersFrom } from 'stimulus-loading'
+lazyLoadControllersFrom('./better_together/controllers', application)

app/javascript/better_together/controllers/new_person_community_membership_controller.js

@@ -5,7 +5,7 @@ export default class extends Controller {
   static targets = ["modal", "sourceSelect"]
 
   connect() {
-    console.log("New BetterTogether::PersonCommunityMembership controller connected");
+    // console.log("New BetterTogether::PersonCommunityMembership controller connected");
     this.modal = new bootstrap.Modal(this.modalTarget)
   }
 

app/views/better_together/communities/show.html.erb

@@ -40,13 +40,13 @@
     <% end %>
 
    <!-- Add Member Button -->
-    <div data-controller="bt-new-person-community-membership">
-      <button type="button" class="btn btn-primary" data-action="click->bt-new-person-community-membership#openModal">
+    <div data-controller="new-person-community-membership">
+      <button type="button" class="btn btn-primary" data-action="click->new-person-community-membership#openModal">
         Add Member
       </button>
 
      <!-- Add Member Modal -->
-      <div class="modal fade" id="addMemberModal" tabindex="-1" aria-labelledby="addMemberModalLabel" data-bt-new-person-community-membership-target="modal" data-action="turbo:submit-end->bt-new-person-community-membership#handleSuccess">
+      <div class="modal fade" id="addMemberModal" tabindex="-1" aria-labelledby="addMemberModalLabel" data-new-person-community-membership-target="modal" data-action="turbo:submit-end->new-person-community-membership#handleSuccess">
         <div class="modal-dialog">
           <div class="modal-content">
             <div class="modal-header">

config/importmap.rb

@@ -2,9 +2,9 @@
 
 # config/importmap.rb
 
-pin_all_from File.expand_path('../app/javascript', __dir__)
-# pin_all_from 'app/javascript/better_together/controllers', under: 'controllers', to: 'controllers'
-pin_all_from 'app/javascript/better_together/trix-extensions', under: 'trix-extensions', to: 'trix-extensions'
+pin_all_from File.expand_path('../app/javascript/better_together', __dir__)
+pin_all_from 'app/javascript/better_together/controllers', under: 'better_together/controllers', to: 'controllers'
+# pin_all_from 'app/javascript/better_together/trix-extensions', under: 'trix-extensions', to: 'trix-extensions'
 
 pin '@hotwired/turbo-rails', to: 'turbo.min.js'
 pin '@hotwired/stimulus', to: 'stimulus.min.js'