Rubocop fixes

Author: rsmithlal

app/models/concerns/better_together/seedable.rb

@@ -141,8 +141,8 @@ def export_collection_as_seed( # rubocop:todo Metrics/MethodLength
         seed_hash
       end
 
-      def export_collection_as_seed_yaml(records, **opts)
-        export_collection_as_seed(records, **opts).deep_stringify_keys.to_yaml
+      def export_collection_as_seed_yaml(records, **)
+        export_collection_as_seed(records, **).deep_stringify_keys.to_yaml
       end
     end
   end

spec/concerns/better_together/seedable_spec.rb

@@ -5,17 +5,19 @@
 module BetterTogether
   describe Seedable, type: :model do
     # Define a test ActiveRecord model inline for this spec
+    # rubocop:todo RSpec/LeakyConstantDeclaration
     class TestSeedableClass < ApplicationRecord # rubocop:todo Lint/ConstantDefinitionInBlock
       include Seedable
     end
+    # rubocop:enable RSpec/LeakyConstantDeclaration
 
-    before(:all) do
+    before(:all) do # rubocop:todo RSpec/BeforeAfterAll
       create_table(:better_together_test_seedable_classes) do |t|
         t.string :name
       end
     end
 
-    after(:all) do
+    after(:all) do # rubocop:todo RSpec/BeforeAfterAll
       drop_table(:better_together_test_seedable_classes)
     end
 

spec/factories/better_together/seeds.rb

@@ -1,7 +1,7 @@
 # frozen_string_literal: true
 
-FactoryBot.define do # rubocop:todo Metrics/BlockLength
-  factory :better_together_seed, class: 'BetterTogether::Seed' do # rubocop:todo Metrics/BlockLength
+FactoryBot.define do
+  factory :better_together_seed, class: 'BetterTogether::Seed' do
     id { SecureRandom.uuid }
     version { '1.0' }
     created_by { 'Better Together Solutions' }

spec/helpers/better_together/seeds_helper_spec.rb

@@ -13,7 +13,7 @@
 #   end
 # end
 module BetterTogether
-  RSpec.describe SeedsHelper, type: :helper do
+  RSpec.describe SeedsHelper do
     pending "add some examples to (or delete) #{__FILE__}"
   end
 end

spec/models/better_together/seed_spec.rb

@@ -2,7 +2,7 @@
 
 require 'rails_helper'
 
-RSpec.describe BetterTogether::Seed, type: :model do # rubocop:todo Metrics/BlockLength
+RSpec.describe BetterTogether::Seed do
   subject(:seed) { build(:better_together_seed) }
 
   describe 'validations' do
@@ -54,7 +54,7 @@
   # -------------------------------------------------------------------
   # Specs for .load_seed
   # -------------------------------------------------------------------
-  describe '.load_seed' do # rubocop:todo Metrics/BlockLength
+  describe '.load_seed' do
     let(:valid_seed_data) do
       {
         'better_together' => {
@@ -85,30 +85,34 @@
       allow(YAML).to receive(:load_file).and_call_original
     end
 
-    context 'when the source is a direct file path' do # rubocop:todo Metrics/BlockLength
-      context 'and the file exists' do
+    context 'when the source is a direct file path' do
+      # rubocop:todo RSpec/NestedGroups
+      context 'and the file exists' do # rubocop:todo RSpec/ContextWording, RSpec/NestedGroups
+        # rubocop:enable RSpec/NestedGroups
         before do
           allow(File).to receive(:exist?).with(file_path).and_return(true)
           allow(YAML).to receive(:load_file).with(file_path).and_return(valid_seed_data)
         end
 
-        it 'imports the seed and returns a BetterTogether::Seed record' do
+        it 'imports the seed and returns a BetterTogether::Seed record' do # rubocop:todo RSpec/MultipleExpectations
           result = described_class.load_seed(file_path)
           expect(result).to be_a(described_class)
           expect(result.identifier).to eq('from_test')
           expect(result.payload[:payload_key]).to eq('payload_value')
         end
       end
 
-      context 'but the file does not exist' do
+      # rubocop:todo RSpec/NestedGroups
+      context 'but the file does not exist' do # rubocop:todo RSpec/ContextWording, RSpec/NestedGroups
+        # rubocop:enable RSpec/NestedGroups
         it 'falls back to namespace logic and raises an error' do
           expect do
             described_class.load_seed(file_path)
           end.to raise_error(RuntimeError, /Seed file not found for/)
         end
       end
 
-      context 'when YAML loading raises an error' do
+      context 'when YAML loading raises an error' do # rubocop:todo RSpec/NestedGroups
         before do
           allow(File).to receive(:exist?).with(file_path).and_return(true)
           allow(YAML).to receive(:load_file).with(file_path).and_raise(StandardError, 'Bad YAML')
@@ -122,25 +126,29 @@
       end
     end
 
-    context 'when the source is a namespace' do # rubocop:todo Metrics/BlockLength
+    context 'when the source is a namespace' do
       let(:namespace) { 'better_together/wizards/host_setup_wizard' }
       let(:full_path) { Rails.root.join('config', 'seeds', "#{namespace}.yml").to_s }
 
-      context 'and the file exists' do
+      # rubocop:todo RSpec/NestedGroups
+      context 'and the file exists' do # rubocop:todo RSpec/ContextWording, RSpec/NestedGroups
+        # rubocop:enable RSpec/NestedGroups
         before do
           allow(File).to receive(:exist?).with(namespace).and_return(false)
           allow(File).to receive(:exist?).with(full_path).and_return(true)
           allow(YAML).to receive(:load_file).with(full_path).and_return(valid_seed_data)
         end
 
-        it 'imports the seed from the namespace path' do
+        it 'imports the seed from the namespace path' do # rubocop:todo RSpec/MultipleExpectations
           result = described_class.load_seed(namespace)
           expect(result).to be_a(described_class)
           expect(result.identifier).to eq('from_test')
         end
       end
 
-      context 'but the file does not exist' do
+      # rubocop:todo RSpec/NestedGroups
+      context 'but the file does not exist' do # rubocop:todo RSpec/ContextWording, RSpec/NestedGroups
+        # rubocop:enable RSpec/NestedGroups
         before do
           allow(File).to receive(:exist?).with(namespace).and_return(false)
           allow(File).to receive(:exist?).with(full_path).and_return(false)
@@ -153,7 +161,7 @@
         end
       end
 
-      context 'when YAML loading raises an error' do
+      context 'when YAML loading raises an error' do # rubocop:todo RSpec/NestedGroups
         before do
           allow(File).to receive(:exist?).with(namespace).and_return(false)
           allow(File).to receive(:exist?).with(full_path).and_return(true)
@@ -178,7 +186,7 @@
       create(:better_together_seed)
     end
 
-    it 'attaches a YAML file after creation' do
+    it 'attaches a YAML file after creation' do # rubocop:todo RSpec/NoExpectationExample
       # seed.reload  # Ensures the record reloads from the DB after the commit callback
       # expect(seed.yaml_file).to be_attached
 

spec/support/shared_examples/a_seedable_model.rb

@@ -1,11 +1,11 @@
 # frozen_string_literal: true
 
-RSpec.shared_examples 'a seedable model' do # rubocop:todo Metrics/BlockLength
+RSpec.shared_examples 'a seedable model' do
   it 'includes the Seedable concern' do
     expect(described_class.ancestors).to include(BetterTogether::Seedable)
   end
 
-  describe 'Seedable instance methods' do # rubocop:todo Metrics/BlockLength
+  describe 'Seedable instance methods' do
     # Use create(...) so the record is persisted in the test database
     let(:record) { create(described_class.name.underscore.to_sym) }
 
@@ -21,7 +21,7 @@
       expect(record).to respond_to(:export_as_seed_yaml)
     end
 
-    context '#export_as_seed' do
+    describe '#export_as_seed' do
       it 'returns a hash with the default root key' do
         seed_hash = record.export_as_seed
         expect(seed_hash.keys).to include(BetterTogether::Seed::DEFAULT_ROOT_KEY)
@@ -34,16 +34,16 @@
       end
     end
 
-    context '#export_as_seed_yaml' do
-      it 'returns a valid YAML string' do
+    describe '#export_as_seed_yaml' do
+      it 'returns a valid YAML string' do # rubocop:todo RSpec/MultipleExpectations
         yaml_str = record.export_as_seed_yaml
         expect(yaml_str).to be_a(String)
         expect(yaml_str).to include(BetterTogether::Seed::DEFAULT_ROOT_KEY.to_s)
       end
     end
   end
 
-  describe 'Seedable class methods' do # rubocop:todo Metrics/BlockLength
+  describe 'Seedable class methods' do
     let(:records) { build_list(described_class.name.underscore.to_sym, 3) }
 
     it 'responds to .export_collection_as_seed' do
@@ -54,13 +54,13 @@
       expect(described_class).to respond_to(:export_collection_as_seed_yaml)
     end
 
-    context '.export_collection_as_seed' do
+    describe '.export_collection_as_seed' do
       it 'returns a hash with the default root key' do
         collection_hash = described_class.export_collection_as_seed(records)
         expect(collection_hash.keys).to include(BetterTogether::Seed::DEFAULT_ROOT_KEY)
       end
 
-      it 'includes an array of records under :records' do
+      it 'includes an array of records under :records' do # rubocop:todo RSpec/MultipleExpectations
         collection_hash = described_class.export_collection_as_seed(records)
         root_key = collection_hash.keys.first
         expect(collection_hash[root_key]).to have_key(:records)
@@ -69,8 +69,8 @@
       end
     end
 
-    context '.export_collection_as_seed_yaml' do
-      it 'returns a valid YAML string' do
+    describe '.export_collection_as_seed_yaml' do
+      it 'returns a valid YAML string' do # rubocop:todo RSpec/MultipleExpectations
         yaml_str = described_class.export_collection_as_seed_yaml(records)
         expect(yaml_str).to be_a(String)
         expect(yaml_str).to include(BetterTogether::Seed::DEFAULT_ROOT_KEY.to_s)

spec/views/better_together/seeds/edit.html.erb_spec.rb

@@ -2,16 +2,16 @@
 
 require 'rails_helper'
 
-RSpec.describe 'seeds/edit', type: :view do
+RSpec.describe 'seeds/edit' do
   let(:seed) do
     create(:better_together_seed)
   end
 
-  before(:each) do
+  before do
     assign(:seed, seed)
   end
 
-  it 'renders the edit seed form' do
+  it 'renders the edit seed form' do # rubocop:todo RSpec/NoExpectationExample
     # render
 
     # assert_select "form[action=?][method=?]", seed_path(seed), "post" do

spec/views/better_together/seeds/index.html.erb_spec.rb

@@ -2,15 +2,15 @@
 
 require 'rails_helper'
 
-RSpec.describe 'seeds/index', type: :view do
-  before(:each) do
+RSpec.describe 'seeds/index' do
+  before do
     assign(:seeds, [
              create(:better_together_seed),
              create(:better_together_seed)
            ])
   end
 
-  it 'renders a list of seeds' do
+  it 'renders a list of seeds' do # rubocop:todo RSpec/NoExpectationExample
     # render
     # cell_selector = 'div>p'
   end

spec/views/better_together/seeds/new.html.erb_spec.rb

@@ -2,12 +2,12 @@
 
 require 'rails_helper'
 
-RSpec.describe 'seeds/new', type: :view do
-  before(:each) do
+RSpec.describe 'seeds/new' do
+  before do
     assign(:seed, build(:better_together_seed))
   end
 
-  it 'renders new seed form' do
+  it 'renders new seed form' do # rubocop:todo RSpec/NoExpectationExample
     # render
 
     # assert_select "form[action=?][method=?]", seeds_path, "post" do

spec/views/better_together/seeds/show.html.erb_spec.rb

@@ -2,12 +2,12 @@
 
 require 'rails_helper'
 
-RSpec.describe 'seeds/show', type: :view do
-  before(:each) do
+RSpec.describe 'seeds/show' do
+  before do
     assign(:seed, create(:better_together_seed))
   end
 
-  it 'renders attributes in <p>' do
+  it 'renders attributes in <p>' do # rubocop:todo RSpec/NoExpectationExample
     # render
   end
 end