Rubocop fixes

Author: rsmithlal

app/controllers/better_together/platform_invitations_controller.rb

@@ -13,7 +13,7 @@ class PlatformInvitationsController < ApplicationController # rubocop:todo Style
     end
 
     # GET /platforms/:platform_id/platform_invitations
-    def index
+    def index # rubocop:todo Metrics/MethodLength
       authorize BetterTogether::PlatformInvitation
 
       # Build filtered and sorted collection with pagination
@@ -45,7 +45,7 @@ def create # rubocop:todo Metrics/AbcSize, Metrics/MethodLength
 
       authorize @platform_invitation
 
-      respond_to do |format|
+      respond_to do |format| # rubocop:todo Metrics/BlockLength
         if @platform_invitation.save
           flash[:notice] = t('flash.generic.created', resource: t('resources.invitation'))
           format.html { redirect_to @platform, notice: flash[:notice] }
@@ -145,7 +145,7 @@ def set_platform_invitation
       @platform_invitation = @platform.invitations.find(params[:id])
     end
 
-    def build_filtered_collection
+    def build_filtered_collection # rubocop:todo Metrics/CyclomaticComplexity, Metrics/AbcSize, Metrics/PerceivedComplexity
       collection = base_collection
       collection = apply_status_filter(collection) if filter_params[:status].present? || params[:status].present?
       collection = apply_email_filter(collection) if filter_params[:search].present? || params[:search].present?
@@ -156,7 +156,7 @@ def build_filtered_collection
       collection
     end
 
-    def apply_sorting(collection)
+    def apply_sorting(collection) # rubocop:todo Metrics/CyclomaticComplexity, Metrics/AbcSize, Metrics/MethodLength
       sort_by = params[:sort_by]
       sort_direction = params[:sort_direction] == 'asc' ? :asc : :desc
 

app/controllers/better_together/platforms_controller.rb

@@ -1,7 +1,7 @@
 # frozen_string_literal: true
 
 module BetterTogether
-  class PlatformsController < FriendlyResourceController # rubocop:todo Style/Documentation
+  class PlatformsController < FriendlyResourceController # rubocop:todo Style/Documentation, Metrics/ClassLength
     before_action :set_platform, only: %i[show edit update destroy]
     before_action :authorize_platform, only: %i[show edit update destroy]
     after_action :verify_authorized, except: :index
@@ -126,7 +126,7 @@ def resource_class
       ::BetterTogether::Platform
     end
 
-    def resource_collection
+    def resource_collection # rubocop:todo Metrics/MethodLength
       # Comprehensive eager loading to prevent N+1 queries across all platform associations
       resource_class.includes(
         # Platform's own translations and attachments

app/helpers/better_together/platform_invitations_helper.rb

@@ -39,7 +39,7 @@ def default_column_sort_info_for_invitations
       }
     end
 
-    def build_sort_path_for_invitations(column, direction, platform)
+    def build_sort_path_for_invitations(column, direction, platform) # rubocop:todo Metrics/MethodLength
       platform_platform_invitations_path(platform,
                                          filters: {
                                            search: current_search_filter_for_invitations,

app/models/better_together/platform.rb

@@ -82,7 +82,7 @@ def primary_community_extra_attrs
 
     # Efficiently load platform memberships with all necessary associations
     # to prevent N+1 queries in views
-    def memberships_with_associations
+    def memberships_with_associations # rubocop:todo Metrics/MethodLength
       person_platform_memberships.includes(
         {
           member: [

lib/tasks/mobility_translation_migration.rake

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 # Mobility Translation Migration Tasks
 #
 # These tasks handle migrating community and partner name translations from the
@@ -19,10 +21,10 @@
 # The migration can also be executed through Rails migrations via:
 #   bin/dc-run rails db:migrate
 
-namespace :translations do
-  namespace :mobility do
+namespace :translations do # rubocop:todo Metrics/BlockLength
+  namespace :mobility do # rubocop:todo Metrics/BlockLength
     desc 'Migrate community and partner name translations from text to string translations'
-    task migrate_names_to_string: :environment do
+    task migrate_names_to_string: :environment do # rubocop:todo Metrics/BlockLength
       puts 'Starting migration of names from text to string translations...'
       puts '=' * 80
 
@@ -66,7 +68,7 @@ namespace :translations do
       records_to_create = []
       records_to_delete = []
 
-      all_text_translations.each_with_index do |text_translation, index|
+      all_text_translations.each_with_index do |text_translation, index| # rubocop:todo Metrics/BlockLength
         begin
           # Check if a string translation already exists for this record
           existing_string = string_translation_class.find_by(
@@ -88,22 +90,28 @@ namespace :translations do
               updated_at: text_translation.updated_at
             }
 
+            # rubocop:todo Layout/LineLength
             puts "✓ Prepared for migration: #{text_translation.translatable_type} ##{text_translation.translatable_id} name (#{text_translation.locale}): '#{text_translation.value}'"
+            # rubocop:enable Layout/LineLength
             migration_count += 1
           else
+            # rubocop:todo Layout/LineLength
             puts "⚠ String translation already exists for #{text_translation.translatable_type} ##{text_translation.translatable_id} name (#{text_translation.locale}), skipping"
+            # rubocop:enable Layout/LineLength
             skipped_count += 1
           end
 
           # Always prepare text translation for bulk deletion
           records_to_delete << text_translation.id
         rescue StandardError => e
+          # rubocop:todo Layout/LineLength
           puts "✗ Error preparing #{text_translation.translatable_type} ##{text_translation.translatable_id}: #{e.message}"
+          # rubocop:enable Layout/LineLength
           error_count += 1
         end
 
         # Progress indicator for large datasets
-        if (index + 1) % 10 == 0 || (index + 1) == all_text_translations.count
+        if ((index + 1) % 10).zero? || (index + 1) == all_text_translations.count
           puts "Progress: #{index + 1}/#{all_text_translations.count} prepared"
         end
       end
@@ -145,7 +153,7 @@ namespace :translations do
         end
       end
 
-      puts "\n" + ('=' * 80)
+      puts "\n#{'=' * 80}"
       puts 'Migration Summary:'
       puts "  ✓ Successfully migrated: #{migration_count}"
       puts "  ⚠ Skipped (already exist): #{skipped_count}"
@@ -155,7 +163,7 @@ namespace :translations do
     end
 
     desc 'Clean up remaining text translations after successful migration (DANGEROUS: removes data)'
-    task clean_up_text_translations: :environment do
+    task clean_up_text_translations: :environment do # rubocop:todo Metrics/BlockLength
       puts 'Cleaning up remaining text translations for community/partner names...'
       puts '⚠️  WARNING: This will permanently delete records from the text_translations table!'
       puts '=' * 80
@@ -194,10 +202,14 @@ namespace :translations do
         if string_exists
           # Safe to delete the text translation - add to bulk deletion list
           records_to_delete << text_translation.id
+          # rubocop:todo Layout/LineLength
           puts "🗑️  Prepared for cleanup: #{text_translation.translatable_type} ##{text_translation.translatable_id} name (#{text_translation.locale})"
+          # rubocop:enable Layout/LineLength
           cleanup_count += 1
         else
+          # rubocop:todo Layout/LineLength
           puts "⚠️  String translation missing for #{text_translation.translatable_type} ##{text_translation.translatable_id} (#{text_translation.locale}) - skipping cleanup"
+          # rubocop:enable Layout/LineLength
           verification_failures += 1
         end
       end
@@ -217,7 +229,7 @@ namespace :translations do
         end
       end
 
-      puts "\n" + ('=' * 80)
+      puts "\n#{'=' * 80}"
       puts 'Cleanup Summary:'
       puts "  🗑️  Records cleaned up: #{cleanup_count}"
       puts "  ⚠️  Verification failures: #{verification_failures}"
@@ -226,7 +238,7 @@ namespace :translations do
     end
 
     desc 'Check status of community/partner name translations (dry run)'
-    task check_names_status: :environment do
+    task check_names_status: :environment do # rubocop:todo Metrics/BlockLength
       puts 'Checking status of community/partner name translations...'
       puts '=' * 80
 
@@ -278,7 +290,7 @@ namespace :translations do
         end
       end
 
-      puts "\n" + ('=' * 80)
+      puts "\n#{'=' * 80}"
       if all_text_translations.empty?
         puts '✅ Migration appears complete - no name translations found in text_translations'
       else

spec/controllers/better_together/platform_invitations_controller_spec.rb

@@ -21,10 +21,10 @@
   end
 
   describe 'GET #index' do
-    let!(:invitation1) do
+    let!(:invitation1) do # rubocop:todo RSpec/IndexedLet
       create(:better_together_platform_invitation, invitee_email: '[email protected]', invitable: platform)
     end
-    let!(:invitation2) do
+    let!(:invitation2) do # rubocop:todo RSpec/IndexedLet
       create(:better_together_platform_invitation, invitee_email: '[email protected]', invitable: platform)
     end
 
@@ -53,7 +53,7 @@
         expect(invitations.first.association(:invitee)).to be_loaded if invitations.first.invitee.present?
       end
 
-      context 'with filtering' do
+      context 'with filtering' do # rubocop:todo RSpec/NestedGroups
         let!(:pending_invitation) do
           create(:better_together_platform_invitation, status: 'pending', invitable: platform)
         end
@@ -68,7 +68,7 @@
         end
       end
 
-      context 'with search' do
+      context 'with search' do # rubocop:todo RSpec/NestedGroups
         let!(:john_invitation) do
           create(:better_together_platform_invitation, invitee_email: '[email protected]', invitable: platform)
         end
@@ -83,7 +83,7 @@
         end
       end
 
-      context 'with pagination' do
+      context 'with pagination' do # rubocop:todo RSpec/NestedGroups
         before do
           # Create more invitations than the per-page limit (25)
           30.times do |i|
@@ -106,7 +106,7 @@
         end
       end
 
-      context 'with sorting' do
+      context 'with sorting' do # rubocop:todo RSpec/NestedGroups
         let!(:old_invitation) do
           create(:better_together_platform_invitation, invitee_email: '[email protected]', invitable: platform,
                                                        created_at: 2.days.ago)

spec/helpers/better_together/image_helper_spec.rb

@@ -1,7 +1,9 @@
+# frozen_string_literal: true
+
 require 'rails_helper'
 
-RSpec.describe BetterTogether::ImageHelper, type: :helper do
-  include BetterTogether::ImageHelper
+RSpec.describe BetterTogether::ImageHelper do
+  include described_class
 
   describe '#profile_image_tag' do
     let(:person) { create(:better_together_person) }
@@ -16,16 +18,15 @@
 
     context 'when person has profile_image_url method' do
       before do
-        allow(person).to receive(:respond_to?).and_return(false)
         allow(person).to receive(:respond_to?).with(:profile_image).and_return(true)
         allow(person).to receive(:respond_to?).with(:profile_image, anything).and_return(true)
         allow(person).to receive(:respond_to?).with(:profile_image_url).and_return(true)
         allow(person).to receive(:respond_to?).with(:profile_image_url, anything).and_return(true)
-        allow(person).to receive(:profile_image_url).and_return('http://example.com/optimized.jpg')
 
         # Mock profile_image.attached? to return true
-        profile_image_double = double('profile_image', attached?: true)
-        allow(person).to receive(:profile_image).and_return(profile_image_double)
+        profile_image_double = double('profile_image', attached?: true) # rubocop:todo RSpec/VerifiedDoubles
+        allow(person).to receive_messages(respond_to?: false, profile_image_url: 'http://example.com/optimized.jpg',
+                                          profile_image: profile_image_double)
       end
 
       it 'uses the optimized profile_image_url method' do

spec/performance/profile_image_performance_spec.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 require 'rails_helper'
 
 RSpec.describe 'Profile Image Performance', type: :request do