Skip to content

Commit cd9fea0

Browse files
authored
Avoid modifying Rails 8 autoload paths in engine (#1014)
## Summary - replace `require_dependency` with plain `require` for external gems - avoid Rails 8 FrozenError when loading engine ## Testing - `bin/ci` *(fails: bundler: command not found: rails)* - `bundle exec rubocop` *(fails: bundler: command not found: rubocop)* - `bundle exec brakeman -q -w2` *(fails: bundler: command not found: brakeman)* - `bundle exec bundler-audit --update` *(fails: bundler: command not found: bundler-audit)* - `bin/codex_style_guard` *(fails: bundler: command not found: rubocop)* ------ https://chatgpt.com/codex/tasks/task_e_689b6ec3e1b88321a3410959ca87218a
2 parents 421ced1 + 54d23a5 commit cd9fea0

File tree

1 file changed

+10
-8
lines changed

1 file changed

+10
-8
lines changed

lib/better_together/engine.rb

Lines changed: 10 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -53,14 +53,16 @@ class Engine < ::Rails::Engine
5353
end
5454

5555
config.before_initialize do
56-
require_dependency 'friendly_id'
57-
require_dependency 'mobility'
58-
require_dependency 'friendly_id/mobility'
59-
require_dependency 'jsonapi-resources'
60-
require_dependency 'importmap-rails'
61-
require_dependency 'public_activity'
62-
require_dependency 'pundit'
63-
require_dependency 'rack/cors'
56+
# Use `require` instead of `require_dependency` for external gems to avoid
57+
# modifying Rails' frozen autoload paths (Rails 8 compatibility)
58+
require 'friendly_id'
59+
require 'mobility'
60+
require 'friendly_id/mobility'
61+
require 'jsonapi-resources'
62+
require 'importmap-rails'
63+
require 'public_activity'
64+
require 'pundit'
65+
require 'rack/cors'
6466
end
6567

6668
default_url_options = {

0 commit comments

Comments
 (0)