Rubocop fixes

Author: rsmithlal

app/models/concerns/better_together/attachments/images.rb

@@ -1,34 +1,40 @@
+# frozen_string_literal: true
 
 module BetterTogether
   module Attachments
+    # Single place to manage logic for attached images
     module Images
       extend ActiveSupport::Concern
 
-      VALID_IMAGE_CONTENT_TYPES = %w[image/jpeg image/png image/gif image/webp image/svg+xml].freeze
+      VALID_IMAGE_CONTENT_TYPES = %w[
+        image/jpeg image/png image/gif image/webp image/svg+xml
+      ].freeze
 
       included do
-        def self.attachable_cover_image
+        def self.attachable_cover_image # rubocop:todo Metrics/MethodLength
           has_one_attached :cover_image do |attachable|
             attachable.variant :optimized_jpeg, resize_to_limit: [2400, 1200],
                                                 # rubocop:todo Layout/LineLength
                                                 saver: { strip: true, quality: 85, interlace: true, optimize_coding: true, trellis_quant: true, quant_table: 3 }, format: 'jpg'
             # rubocop:enable Layout/LineLength
             attachable.variant :optimized_png, resize_to_limit: [2400, 1200],
-                                              saver: { strip: true, quality: 85, optimize_coding: true }, format: 'png'
+                                               saver: { strip: true, quality: 85, optimize_coding: true }, format: 'png'
 
             attachable.variant :optimized_card_jpeg, resize_to_limit: [1200, 300],
-                                                    # rubocop:todo Layout/LineLength
-                                                    saver: { strip: true, quality: 90, interlace: true, optimize_coding: true, trellis_quant: true, quant_table: 3 }, format: 'jpg'
+                                                     # rubocop:todo Layout/LineLength
+                                                     saver: { strip: true, quality: 90, interlace: true, optimize_coding: true, trellis_quant: true, quant_table: 3 }, format: 'jpg'
             # rubocop:enable Layout/LineLength
             attachable.variant :optimized_card_png, resize_to_limit: [1200, 300],
+                                                    # rubocop:todo Layout/LineLength
                                                     saver: { strip: true, quality: 90, optimize_coding: true }, format: 'png'
+            # rubocop:enable Layout/LineLength
           end
 
           validates :cover_image,
                     content_type: VALID_IMAGE_CONTENT_TYPES,
                     size: { less_than: 100.megabytes, message: 'is too large' }
 
-          alias card_image cover_image
+          alias_method :card_image, :cover_image
 
           attr_accessor :remove_cover_image
 
@@ -73,4 +79,4 @@ def optimized_cover_image
       end
     end
   end
-end
+end

app/models/concerns/better_together/categorizable.rb

@@ -10,12 +10,12 @@ module Categorizable # rubocop:todo Style/Documentation
     end
 
     class_methods do
-      def categorizable(class_name: category_class_name)
+      def categorizable(class_name: category_class_name) # rubocop:todo Metrics/MethodLength
         self.category_class_name = class_name
 
         has_many :categorizations, class_name: 'BetterTogether::Categorization', as: :categorizable, dependent: :destroy
         has_many :categories, through: :categorizations, source_type: category_class_name do
-          def with_cover_images
+          def with_cover_images # rubocop:todo Lint/NestedMethodDefinition
             left_joins(:cover_image_attachment).where.not(active_storage_attachments: { id: nil })
           end
         end

config/initializers/rack_attack.rb

@@ -23,8 +23,12 @@ class Attack
 
     safelist('allow monitors') do |req|
       allowed_user_agents = [
+        # rubocop:todo Layout/LineLength
         'Better Stack Better Uptime Bot Mozilla/5.0 (Windows NT 10.0; Win64; x64) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/130.0.0.0 Safari/537.36',
+        # rubocop:enable Layout/LineLength
+        # rubocop:todo Layout/LineLength
         'Better Uptime Bot Mozilla/5.0 (Windows NT 10.0; Win64; x64) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/74.0.3729.169 Safari/537.36'
+        # rubocop:enable Layout/LineLength
       ]
       # Requests are allowed if the return value is truthy
       allowed_user_agents.include?(req.user_agent)