Rubocop fixes

Author: rsmithlal

app/controllers/better_together/conversations_controller.rb

@@ -228,7 +228,7 @@ def conversation_params
 
     # Ensure participant_ids only include people the agent is allowed to message.
     # If none remain, keep it empty; creator is always added after create.
-    def conversation_params_filtered # rubocop:todo Metrics/AbcSize
+    def conversation_params_filtered # rubocop:todo Metrics/AbcSize, Metrics/CyclomaticComplexity, Metrics/MethodLength, Metrics/PerceivedComplexity
       permitted = ConversationPolicy.new(helpers.current_user, Conversation.new).permitted_participants
       permitted_ids = permitted.pluck(:id)
       # Always allow the current person (creator/participant) to appear in the list

app/models/better_together/message.rb

@@ -15,7 +15,7 @@ class Message < ApplicationRecord
     # Attributes permitted for strong parameters
     def self.permitted_attributes
       # include id and _destroy for nested attributes handling
-  %i[id content _destroy]
+      %i[id content _destroy]
     end
     # def content
     #   super || self[:content]

spec/requests/better_together/conversation_message_protection_spec.rb

@@ -2,19 +2,22 @@
 
 require 'rails_helper'
 
-RSpec.describe 'Conversation message protection', type: :request do
+RSpec.describe 'Conversation message protection' do
   include RequestSpecHelper
 
+  # rubocop:todo RSpec/ExampleLength
+  # rubocop:todo RSpec/MultipleExpectations
   it "prevents a user from altering another user's message via conversation update" do
-  # Setup: ensure host platform exists and create users with known passwords
-  configure_host_platform
-    
+    # rubocop:enable RSpec/MultipleExpectations
+    # Setup: ensure host platform exists and create users with known passwords
+    configure_host_platform
+
     # Setup: create a manager user (owner of the conversation) and another user
-  manager_user = create(:user, :confirmed, :platform_manager, email: '[email protected]', password: 'password12345')
-  other_user = create(:user, :confirmed, email: '[email protected]', password: 'password12345')
+    manager_user = create(:user, :confirmed, :platform_manager, email: '[email protected]', password: 'password12345')
+    other_user = create(:user, :confirmed, email: '[email protected]', password: 'password12345')
 
     # Create a conversation as the manager with a nested message
-  login(manager_user.email, 'password12345')
+    login(manager_user.email, 'password12345')
 
     post better_together.conversations_path(locale: I18n.default_locale), params: {
       conversation: {
@@ -32,8 +35,8 @@
     expect(message.content.to_plain_text).to include('Original message')
 
     # Now sign in as other_user and attempt to change manager's message via PATCH
-  logout
-  login(other_user.email, 'password12345')
+    logout
+    login(other_user.email, 'password12345')
 
     patch better_together.conversation_path(conversation, locale: I18n.default_locale), params: {
       conversation: {
@@ -48,4 +51,5 @@
     message.reload
     expect(message.content.to_plain_text).to include('Original message')
   end
+  # rubocop:enable RSpec/ExampleLength
 end