Exclude hashed links (start with '#') from mailer header and footer nav items

Author: rsmithlal

app/helpers/better_together/navigation_items_helper.rb

@@ -75,6 +75,14 @@ def platform_footer_nav_area
       @platform_footer_nav_area ||= ::BetterTogether::NavigationArea.find_by(identifier: 'platform-footer')
     end
 
+    # Retrieves navigation items for the mailer footer.
+    def mailer_footer_nav_items
+      # Preload navigation items and their translations in a single query
+      Mobility.with_locale(current_locale) do
+        @mailer_footer_nav_items ||= platform_footer_nav_area&.top_level_nav_items_includes_children.excluding_hashed || []
+      end
+    end
+
     # Retrieves navigation items for the platform footer.
     def platform_footer_nav_items
       # Preload navigation items and their translations in a single query
@@ -101,6 +109,14 @@ def platform_header_nav_items
       end
     end
 
+    # Retrieves navigation items for the mailer header.
+    def mailer_header_nav_items
+      # Preload navigation items and their translations in a single query
+      Mobility.with_locale(current_locale) do
+        @mailer_header_nav_items ||= platform_header_nav_area.top_level_nav_items_includes_children.excluding_hashed || []
+      end
+    end
+
     def render_platform_header_nav_items
       Rails.cache.fetch(cache_key_for_nav_area(platform_header_nav_area)) do
         render 'better_together/navigation_items/navigation_items', navigation_items: platform_header_nav_items

app/models/better_together/navigation_item.rb

@@ -100,6 +100,8 @@ def self.route_name_urls
       joins(join).where(combined_conditions)
     }
 
+    scope :excluding_hashed, -> { where.not('url ILIKE ?', '#%') }
+
     def build_children(pages, navigation_area) # rubocop:todo Metrics/MethodLength
       pages.each_with_index do |page, index|
         children.build(

app/views/layouts/better_together/mailers/_footer.html.erb

@@ -6,8 +6,8 @@
       <table id="footer-pages-nav" class="navbar" width="600" cellpadding="0" cellspacing="0" border="0" style="margin: 0 auto;">
         <tr>
           <td class="container-fluid text-center" align="center">
-            <% platform_footer_nav_items.each_with_index do |nav_item, index| %>
-              <%= link_to nav_item, nav_item.url, class: 'text-decoration-none' %><% if index < (platform_footer_nav_items.size - 1) %> | <% end %>
+            <% mailer_footer_nav_items.each_with_index do |nav_item, index| %>
+              <%= link_to nav_item, nav_item.url, class: 'text-decoration-none' %><% if index < (mailer_footer_nav_items.size - 1) %> | <% end %>
             <% end %>
           </td>
         </tr>

app/views/layouts/better_together/mailers/_header.html.erb

@@ -10,8 +10,8 @@
   </tr>
   <tr>
     <td class="" style="margin-bottom: 24px;" align="center">
-      <% platform_header_nav_items.each_with_index do |nav_item, index| %>
-        <%= link_to nav_item, nav_item.url, class: 'text-decoration-none' %><% if index < (platform_header_nav_items.size - 1) %> | <% end %>
+      <% mailer_header_nav_items.each_with_index do |nav_item, index| %>
+        <%= link_to nav_item, nav_item.url, class: 'text-decoration-none' %><% if index < (mailer_header_nav_items.size - 1) %> | <% end %>
       <% end %>
     </td>
   </tr>