Revert "replace require_dependency"

rsmithlal · rsmithlal · commit d1d4440b4151 · 2025-09-03T17:21:39.000-02:30
This (partially) reverts commit 8cf9077.
diff --git a/app/future_controllers/better_together/api_controller.rb b/app/future_controllers/better_together/api_controller.rb
@@ -1,6 +1,6 @@
 # frozen_string_literal: true
 
-require 'jsonapi/resource_controller'
+require_dependency 'jsonapi/resource_controller'
 
 module BetterTogether
   # Base API controller
diff --git a/app/future_controllers/better_together/bt/api/v1/communities_controller.rb b/app/future_controllers/better_together/bt/api/v1/communities_controller.rb
@@ -1,6 +1,6 @@
 # frozen_string_literal: true
 
-require 'better_together/api_controller'
+require_dependency 'better_together/api_controller'
 
 module BetterTogether
   module Bt
diff --git a/app/future_controllers/better_together/bt/api/v1/community_memberships_controller.rb b/app/future_controllers/better_together/bt/api/v1/community_memberships_controller.rb
@@ -1,6 +1,6 @@
 # frozen_string_literal: true
 
-require 'better_together/api_controller'
+require_dependency 'better_together/api_controller'
 
 module BetterTogether
   module Bt
diff --git a/app/future_controllers/better_together/bt/api/v1/people_controller.rb b/app/future_controllers/better_together/bt/api/v1/people_controller.rb
@@ -1,6 +1,6 @@
 # frozen_string_literal: true
 
-require 'better_together/api_controller'
+require_dependency 'better_together/api_controller'
 
 module BetterTogether
   module Bt
diff --git a/app/future_controllers/better_together/bt/api/v1/roles_controller.rb b/app/future_controllers/better_together/bt/api/v1/roles_controller.rb
@@ -1,6 +1,6 @@
 # frozen_string_literal: true
 
-require 'better_together/api_controller'
+require_dependency 'better_together/api_controller'
 
 module BetterTogether
   module Bt
diff --git a/app/helpers/better_together/calendars_helper.rb b/app/helpers/better_together/calendars_helper.rb
@@ -1,7 +1,6 @@
 # frozen_string_literal: true
 
-# require 'simple_calendar/calendar_helper'
-
+require_dependency 'simple_calendar/calendar_helper'
 module BetterTogether
   module CalendarsHelper
     include SimpleCalendar::CalendarHelper
diff --git a/app/models/better_together/geography/map.rb b/app/models/better_together/geography/map.rb
@@ -85,5 +85,5 @@ def to_s
   end
 end
 
-require 'better_together/geography/community_map'
-require 'better_together/geography/community_collection_map'
+require_dependency 'better_together/geography/community_map'
+require_dependency 'better_together/geography/community_collection_map'
diff --git a/app/resources/better_together/api_resource.rb b/app/resources/better_together/api_resource.rb
@@ -1,6 +1,6 @@
 # frozen_string_literal: true
 
-# require 'jsonapi/resource'
+require_dependency 'jsonapi/resource'
 
 module BetterTogether
   # Base JSONAPI serializer that sets common attrbutes
diff --git a/app/resources/better_together/bt/api/v1/community_membership_resource.rb b/app/resources/better_together/bt/api/v1/community_membership_resource.rb
@@ -1,6 +1,6 @@
 # frozen_string_literal: true
 
-require 'better_together/api_resource'
+require_dependency 'better_together/api_resource'
 
 module BetterTogether
   module Bt
diff --git a/app/resources/better_together/bt/api/v1/community_resource.rb b/app/resources/better_together/bt/api/v1/community_resource.rb
@@ -1,6 +1,6 @@
 # frozen_string_literal: true
 
-require 'better_together/api_resource'
+require_dependency 'better_together/api_resource'
 
 module BetterTogether
   module Bt
diff --git a/app/resources/better_together/bt/api/v1/person_resource.rb b/app/resources/better_together/bt/api/v1/person_resource.rb
@@ -1,6 +1,6 @@
 # frozen_string_literal: true
 
-require 'better_together/api_resource'
+require_dependency 'better_together/api_resource'
 
 module BetterTogether
   module Bt
diff --git a/app/resources/better_together/bt/api/v1/registration_resource.rb b/app/resources/better_together/bt/api/v1/registration_resource.rb
@@ -1,6 +1,6 @@
 # frozen_string_literal: true
 
-require 'better_together/api_resource'
+require_dependency 'better_together/api_resource'
 
 module BetterTogether
   module Bt
diff --git a/app/resources/better_together/bt/api/v1/role_resource.rb b/app/resources/better_together/bt/api/v1/role_resource.rb
@@ -1,6 +1,6 @@
 # frozen_string_literal: true
 
-require 'better_together/api_resource'
+require_dependency 'better_together/api_resource'
 
 module BetterTogether
   module Bt
diff --git a/app/resources/better_together/bt/api/v1/user_resource.rb b/app/resources/better_together/bt/api/v1/user_resource.rb
@@ -1,6 +1,6 @@
 # frozen_string_literal: true
 
-require 'better_together/api_resource'
+require_dependency 'better_together/api_resource'
 
 module BetterTogether
   module Bt
diff --git a/lib/better_together/engine.rb b/lib/better_together/engine.rb
@@ -53,14 +53,14 @@ class Engine < ::Rails::Engine
     end
 
     config.before_initialize do
-      require 'friendly_id'
-      require 'mobility'
-      require 'friendly_id/mobility'
-      require 'jsonapi-resources'
-      require 'importmap-rails'
-      require 'public_activity'
-      require 'pundit'
-      require 'rack/cors'
+      require_dependency 'friendly_id'
+      require_dependency 'mobility'
+      require_dependency 'friendly_id/mobility'
+      require_dependency 'jsonapi-resources'
+      require_dependency 'importmap-rails'
+      require_dependency 'public_activity'
+      require_dependency 'pundit'
+      require_dependency 'rack/cors'
     end
 
     default_url_options = {
@@ -80,13 +80,13 @@ class Engine < ::Rails::Engine
     end
 
     initializer 'better_together.action_mailer' do |app|
-      if Rails.env.production?
-        app.config.action_mailer.show_previews = false
-      else
+      if Rails.env.development?
         app.config.action_mailer.show_previews = true
         app.config.action_mailer.preview_paths =
           app.config.action_mailer.preview_paths.to_a +
           [BetterTogether::Engine.root.join('spec/mailers/previews')]
+      else
+        app.config.action_mailer.show_previews = false
       end
     end
 
diff --git a/spec/dummy/config/initializers/rswag_ui.rb b/spec/dummy/config/initializers/rswag_ui.rb
@@ -1,7 +1,7 @@
 # spec/dummy/config/initializers/rswag_ui.rb
 # frozen_string_literal: true
 
-require 'rswag'
+require_dependency 'rswag'
 
 Rswag::Ui.configure do |c|
   # List the Swagger endpoints that you want to be documented through the swagger-ui
