Rubocop fixes

Author: rsmithlal

app/controllers/better_together/users/registrations_controller.rb

@@ -74,14 +74,14 @@ def new
         end
       end
 
-      def create
+      def create # rubocop:todo Metrics/MethodLength
         unless agreements_accepted?
           handle_agreements_not_accepted
           return
         end
 
         # Validate captcha if enabled by host application
-        unless validate_captcha_if_enabled
+        unless validate_captcha_if_enabled?
           build_resource(sign_up_params)
           handle_captcha_validation_failure(resource)
           return
@@ -114,7 +114,7 @@ def set_required_agreements
       # Hook method for host applications to implement captcha validation
       # Override this method in host applications to add Turnstile or other captcha validation
       # @return [Boolean] true if captcha is valid or not enabled, false if validation fails
-      def validate_captcha_if_enabled
+      def validate_captcha_if_enabled?
         # Default implementation - no captcha validation
         # Host applications should override this method to implement their captcha logic
         true

spec/controllers/better_together/users/registrations_controller_hook_spec.rb

@@ -2,8 +2,7 @@
 
 require 'rails_helper'
 
-RSpec.describe BetterTogether::Users::RegistrationsController, :skip_host_setup,
-               type: :controller do
+RSpec.describe BetterTogether::Users::RegistrationsController, :skip_host_setup do
   include BetterTogether::CapybaraFeatureHelpers
 
   routes { BetterTogether::Engine.routes }
@@ -13,11 +12,11 @@
   end
 
   describe 'captcha hook methods', :no_auth do
-    describe '#validate_captcha_if_enabled' do
+    describe '#validate_captcha_if_enabled?' do
       let(:controller_instance) { described_class.new }
 
       it 'returns true by default (no captcha validation)' do
-        expect(controller_instance.send(:validate_captcha_if_enabled)).to be true
+        expect(controller_instance.send(:validate_captcha_if_enabled?)).to be true
       end
     end