Increase spec coverage

Author: rsmithlal

spec/requests/better_together/geography/countries_controller_spec.rb

@@ -0,0 +1,28 @@
+# frozen_string_literal: true
+
+require 'rails_helper'
+
+RSpec.describe 'BetterTogether::Geography::CountriesController', type: :request do
+  let(:locale) { I18n.default_locale }
+
+  before do
+    configure_host_platform
+    login('[email protected]', 'password12345')
+  end
+
+  describe 'GET /:locale/.../host/geography/countries' do
+    it 'renders index' do
+      get better_together.geography_countries_path(locale:)
+      expect(response).to have_http_status(:ok)
+    end
+  end
+
+  describe 'GET /:locale/.../host/geography/countries/:id' do
+    let!(:country) { create(:geography_country) }
+
+    it 'renders show' do
+      get better_together.geography_country_path(locale:, id: country.slug)
+      expect(response).to have_http_status(:ok)
+    end
+  end
+end

spec/requests/better_together/metrics/link_click_reports_controller_spec.rb

@@ -0,0 +1,42 @@
+# frozen_string_literal: true
+
+require 'rails_helper'
+
+# rubocop:todo Metrics/BlockLength
+RSpec.describe 'BetterTogether::Metrics::LinkClickReportsController', type: :request do
+  let(:locale) { I18n.default_locale }
+
+  before do
+    configure_host_platform
+    login('[email protected]', 'password12345')
+  end
+
+  describe 'GET /:locale/.../metrics/link_click_reports' do
+    it 'renders index' do
+      get better_together.metrics_link_click_reports_path(locale:)
+      expect(response).to have_http_status(:ok)
+    end
+
+    it 'renders new' do
+      get better_together.new_metrics_link_click_report_path(locale:)
+      expect(response).to have_http_status(:ok)
+    end
+  end
+
+  describe 'POST /:locale/.../metrics/link_click_reports' do
+    it 'creates a report and redirects with valid params' do
+      post better_together.metrics_link_click_reports_path(locale:), params: {
+        metrics_link_click_report: {
+          file_format: 'csv',
+          sort_by_total_clicks: false,
+          filters: { from_date: '', to_date: '', filter_internal: '' }
+        }
+      }
+
+      expect(response).to have_http_status(:found)
+      follow_redirect!
+      expect(response).to have_http_status(:ok)
+    end
+  end
+end
+# rubocop:enable Metrics/BlockLength

spec/requests/better_together/metrics/page_view_reports_controller_spec.rb

@@ -0,0 +1,42 @@
+# frozen_string_literal: true
+
+require 'rails_helper'
+
+# rubocop:todo Metrics/BlockLength
+RSpec.describe 'BetterTogether::Metrics::PageViewReportsController', type: :request do
+  let(:locale) { I18n.default_locale }
+
+  before do
+    configure_host_platform
+    login('[email protected]', 'password12345')
+  end
+
+  describe 'GET /:locale/.../metrics/page_view_reports' do
+    it 'renders index' do
+      get better_together.metrics_page_view_reports_path(locale:)
+      expect(response).to have_http_status(:ok)
+    end
+
+    it 'renders new' do
+      get better_together.new_metrics_page_view_report_path(locale:)
+      expect(response).to have_http_status(:ok)
+    end
+  end
+
+  describe 'POST /:locale/.../metrics/page_view_reports' do
+    it 'creates a report and redirects with valid params' do
+      post better_together.metrics_page_view_reports_path(locale:), params: {
+        metrics_page_view_report: {
+          file_format: 'csv',
+          sort_by_total_views: false,
+          filters: { from_date: '', to_date: '', filter_pageable_type: '' }
+        }
+      }
+
+      expect(response).to have_http_status(:found)
+      follow_redirect!
+      expect(response).to have_http_status(:ok)
+    end
+  end
+end
+# rubocop:enable Metrics/BlockLength

spec/requests/better_together/navigation_areas_controller_spec.rb

@@ -0,0 +1,76 @@
+# frozen_string_literal: true
+
+require 'rails_helper'
+
+RSpec.describe 'BetterTogether::NavigationAreasController', type: :request do # rubocop:todo Metrics/BlockLength
+  let(:locale) { I18n.default_locale }
+
+  before do
+    configure_host_platform
+    login('[email protected]', 'password12345')
+  end
+
+  describe 'GET /:locale/.../navigation_areas' do
+    it 'renders index' do
+      get better_together.navigation_areas_path(locale:)
+      expect(response).to have_http_status(:ok)
+    end
+
+    it 'renders new' do
+      get better_together.new_navigation_area_path(locale:)
+      expect(response).to have_http_status(:ok)
+    end
+  end
+
+  describe 'POST /:locale/.../navigation_areas' do
+    it 'creates and redirects on valid params' do
+      post better_together.navigation_areas_path(locale:), params: {
+        navigation_area: {
+          name: 'Main Nav',
+          visible: true,
+          style: 'primary'
+        }
+      }
+
+      expect(response).to have_http_status(:found)
+      follow_redirect!
+      expect(response).to have_http_status(:ok)
+    end
+
+    it 'renders new on invalid params (HTML 200)' do
+      post better_together.navigation_areas_path(locale:), params: { navigation_area: { name: '' } }
+      expect(response).to have_http_status(:ok)
+    end
+  end
+
+  describe 'PATCH /:locale/.../navigation_areas/:id' do
+    let!(:area) { create(:better_together_navigation_area, protected: false) }
+
+    it 'updates and redirects on valid params' do
+      patch better_together.navigation_area_path(locale:, id: area.slug), params: {
+        navigation_area: { style: 'secondary' }
+      }
+      expect(response).to have_http_status(:found)
+      follow_redirect!
+      expect(response).to have_http_status(:ok)
+    end
+
+    it 'renders edit on invalid params (HTML 200)' do
+      patch better_together.navigation_area_path(locale:, id: area.slug), params: {
+        navigation_area: { name: '' }
+      }
+      expect(response).to have_http_status(:ok)
+    end
+  end
+
+  describe 'DELETE /:locale/.../navigation_areas/:id' do
+    let!(:area) { create(:better_together_navigation_area, protected: false) }
+
+    it 'destroys and redirects' do
+      delete better_together.navigation_area_path(locale:, id: area.slug)
+      expect(response).to have_http_status(:found)
+      follow_redirect!
+      expect(response).to have_http_status(:ok)
+    end
+  end
+end

spec/requests/better_together/navigation_items_controller_spec.rb

@@ -0,0 +1,102 @@
+# frozen_string_literal: true
+
+require 'rails_helper'
+
+RSpec.describe 'BetterTogether::NavigationItemsController', type: :request do # rubocop:todo Metrics/BlockLength
+  let(:locale) { I18n.default_locale }
+  let(:user) { create(:better_together_user, :confirmed, :platform_manager) }
+  let!(:navigation_area) { create(:better_together_navigation_area) }
+
+  before do
+    configure_host_platform
+    login('[email protected]', 'password12345')
+  end
+
+  describe 'GET /:locale/.../navigation_areas/:navigation_area_id/navigation_items' do
+    it 'returns ok for index' do
+      get better_together.navigation_area_navigation_items_path(
+        locale:,
+        navigation_area_id: navigation_area.slug
+      )
+
+      expect(response).to have_http_status(:ok)
+    end
+  end
+
+  describe 'POST /:locale/.../navigation_areas/:navigation_area_id/navigation_items' do
+    let(:params) do
+      # Start with factory attributes, then adapt to permitted keys
+      raw_attrs = attributes_for(:better_together_navigation_item)
+      permitted = raw_attrs.slice(:url, :icon, :position, :visible, :item_type, :parent_id, :route_name)
+      # Use localized title key instead of :title; drop non-permitted keys (:slug, :id, :linkable_*)
+      permitted["title_#{locale}"] = raw_attrs[:title]
+
+      { navigation_item: permitted }
+    end
+
+    it 'creates a navigation item and redirects (HTML)' do
+      post better_together.navigation_area_navigation_items_path(
+        locale:,
+        navigation_area_id: navigation_area.slug
+      ), params: params
+
+      expect(response).to have_http_status(:found)
+      follow_redirect!
+      expect(response).to have_http_status(:ok)
+    end
+
+    it 'renders errors on invalid params' do
+      post better_together.navigation_area_navigation_items_path(
+        locale:,
+        navigation_area_id: navigation_area.slug
+      ), params: { navigation_item: { "title_#{locale}": '' } }
+
+      expect(response).to have_http_status(:unprocessable_content)
+    end
+  end
+
+  describe 'GET/PUT/DELETE on a navigation item' do # rubocop:todo Metrics/BlockLength
+    let!(:item) { create(:better_together_navigation_item, navigation_area: navigation_area, protected: false) }
+
+    it 'shows the item' do
+      get better_together.navigation_area_navigation_item_path(locale:, navigation_area_id: navigation_area.slug,
+                                                               # rubocop:todo Layout/LineLength
+                                                               id: item.slug)
+      # rubocop:enable Layout/LineLength
+      expect(response).to have_http_status(:ok)
+    end
+
+    it 'updates with valid params then redirects' do
+      put better_together.navigation_area_navigation_item_path(
+        locale:,
+        navigation_area_id: navigation_area.slug,
+        id: item.slug
+      ), params: { navigation_item: { "title_#{locale}": 'Updated Title' } }
+
+      expect(response).to have_http_status(:found)
+      follow_redirect!
+      expect(response).to have_http_status(:ok)
+    end
+
+    it 'renders edit on invalid params (422)' do
+      put better_together.navigation_area_navigation_item_path(
+        locale:,
+        navigation_area_id: navigation_area.slug,
+        id: item.slug
+      ), params: { navigation_item: { "title_#{locale}": '' } }
+
+      expect(response).to have_http_status(:unprocessable_content)
+    end
+
+    it 'destroys and redirects' do
+      delete better_together.navigation_area_navigation_item_path(
+        locale:,
+        navigation_area_id: navigation_area.slug,
+        id: item.slug
+      )
+      expect(response).to have_http_status(:found)
+      follow_redirect!
+      expect(response).to have_http_status(:ok)
+    end
+  end
+end

spec/spec_helper.rb

@@ -21,16 +21,16 @@
 require 'simplecov'
 require 'coveralls'
 
+# Allow CI/local runs to override coverage output to avoid permission issues
+SimpleCov.coverage_dir ENV['SIMPLECOV_DIR'] if ENV['SIMPLECOV_DIR']
+
 Capybara.asset_host = ENV.fetch('APP_HOST', 'http://localhost:3000')
 
 Coveralls.wear!('rails')
 
-SimpleCov.formatter = SimpleCov::Formatter::MultiFormatter.new(
-  [
-    SimpleCov::Formatter::HTMLFormatter,
-    Coveralls::SimpleCov::Formatter
-  ]
-)
+formatters = [Coveralls::SimpleCov::Formatter]
+formatters.unshift(SimpleCov::Formatter::HTMLFormatter) unless ENV['SIMPLECOV_NO_HTML'] == '1'
+SimpleCov.formatter = SimpleCov::Formatter::MultiFormatter.new(formatters)
 
 SimpleCov.start 'rails' do
   add_filter '/bin/'

spec/support/request_spec_helper.rb

@@ -5,9 +5,19 @@ def json
     JSON.parse(response.body)
   end
 
-  def login(user)
+  def login(email, password)
     post better_together.user_session_path, params: {
-      user: { email: user.email, password: user.password }
+      user: { email: email, password: password }
     }
   end
+
+  def configure_host_platform
+    host_platform = create(:better_together_platform, :host, privacy: 'public')
+    wizard = BetterTogether::Wizard.find_or_create_by(identifier: 'host_setup')
+    wizard.mark_completed
+    create(:user, :confirmed, :platform_manager,
+           email: '[email protected]',
+           password: 'password12345')
+    host_platform
+  end
 end