Add event reminder functionality with associated tests and mailer

- Implement EventReminderNotifier to handle sending event reminder emails and creating notification records.
- Create EventReminderJob to enqueue notifications for event attendees.
- Develop EventReminderSchedulerJob to schedule reminders at specified intervals.
- Add EventMailer for sending reminder and update emails with appropriate content.
- Enhance Event model with validations, scopes, and callbacks for reminder scheduling.
- Introduce tests for Event, EventReminderNotifier, EventReminderJob, EventReminderSchedulerJob, and EventMailer.
- Implement validations and methods in LocatableLocation for handling location data.

Author: rsmithlal

.github/copilot-instructions.md

@@ -1,25 +1,15 @@
-# Be## Core Principles
-
-- **Security first**: Run `bundle exec brakeman -q` before generating code; fix high-confidence vulnerabilities
-- **Accessibility first** (WCAG AA/AAA): semantic HTML, ARIA roles, keyboard nav, proper contrast.
-- **Hotwire everywhere**: Turbo for navigation/updates; Stimulus controllers for interactivity.
-- **Keep controllers thin**; move business logic to POROs/service objects or concerns.
-- **Prefer explicit join models** over polymorphic associations when validation matters.
-- **Avoid the term "STI"** in code/comments; use "single-table inheritance" or alternate designs.
-- **Use `ENV.fetch`** rather than `ENV[]`.
-- **Always add policy/authorization checks** on links/buttons to controller actions.
-- **i18n & Mobility**: every user-facing string must be translatable; include missing keys.
-- Provide translations for all available locales (e.g., en, es, fr) when adding new strings.er Community Engine – Rails App & Engine Guidelines
+# Better Together Community Engine – Rails App & Engine Guidelines
 
 This repository contains the **Better Together Community Engine** (an isolated Rails engine under the `BetterTogether` namespace) and/or a host Rails app that mounts it. Use these instructions for all code generation.
 
 ## Core Principles
 
+- **Security first**: Run `bundle exec brakeman --quiet --no-pager` before generating code; fix high-confidence vulnerabilities
 - **Accessibility first** (WCAG AA/AAA): semantic HTML, ARIA roles, keyboard nav, proper contrast.
 - **Hotwire everywhere**: Turbo for navigation/updates; Stimulus controllers for interactivity.
 - **Keep controllers thin**; move business logic to POROs/service objects or concerns.
 - **Prefer explicit join models** over polymorphic associations when validation matters.
-- **Avoid the term “STI”** in code/comments; use “single-table inheritance” or alternate designs.
+- **Avoid the term "STI"** in code/comments; use "single-table inheritance" or alternate designs.
 - **Use `ENV.fetch`** rather than `ENV[]`.
 - **Always add policy/authorization checks** on links/buttons to controller actions.
 - **i18n & Mobility**: every user-facing string must be translatable; include missing keys.
@@ -59,7 +49,7 @@ This repository contains the **Better Together Community Engine** (an isolated R
 ## Coding Guidelines
 
 ### Security Requirements
-- **Run Brakeman before generating code**: `bundle exec brakeman -q` 
+- **Run Brakeman before generating code**: `bundle exec brakeman --quiet --no-pager` 
 - **Fix high-confidence vulnerabilities immediately** - never ignore security warnings with "High" confidence
 - **Review and address medium-confidence warnings** that are security-relevant
 - **Safe coding practices when generating code:**
@@ -71,7 +61,7 @@ This repository contains the **Better Together Community Engine** (an isolated R
   - **SQL injection prevention**: Use parameterized queries, avoid string interpolation in SQL
   - **XSS prevention**: Use Rails auto-escaping, sanitize HTML inputs with allowlists
 - **For reflection-based features**: Create concerns with `included_in_models` class methods for safe dynamic class resolution
-- **Post-generation security check**: Run `bundle exec brakeman -c UnsafeReflection,SQL,CrossSiteScripting` after major code changes
+- **Post-generation security check**: Run `bundle exec brakeman --quiet --no-pager -c UnsafeReflection,SQL,CrossSiteScripting` after major code changes
 
 ## Test Environment Setup
 - Configure the host Platform in a before block for controller/request/feature tests.
@@ -105,10 +95,74 @@ This repository contains the **Better Together Community Engine** (an isolated R
   - Ensure blobs are encrypted at rest
 - **Testing**
   - RSpec (if present) or Minitest – follow existing test framework
+  - **Generate comprehensive test coverage for all changes**: Every modification must include RSpec tests covering the new functionality
   - All RSpec specs **must use FactoryBot factories** for model instances (do not use `Model.create` or `Model.new` directly in specs).
   - **A FactoryBot factory must exist for every model**. When generating a new model, also generate a factory for it.
   - **Factories must use the Faker gem** to provide realistic, varied test data for all attributes (e.g., names, emails, addresses, etc.).
+  - **Test all layers**: models, controllers, mailers, jobs, JavaScript/Stimulus controllers, and integration workflows
   - System tests for Turbo flows where possible
+  - **Session-based testing**: When working on existing code modifications, generate tests that cover all unstaged changes and related functionality
+
+## Test Generation Strategy
+
+### Mandatory Test Creation
+When modifying existing code or adding new features, always generate RSpec tests that provide comprehensive coverage:
+
+1. **Model Tests**: 
+   - Validations, associations, scopes, callbacks
+   - Instance methods, class methods, delegations
+   - Business logic and calculated attributes
+   - Security-related functionality (encryption, authorization)
+
+2. **Controller Tests**:
+   - All CRUD actions and custom endpoints
+   - Authorization policy checks (Pundit/equivalent)
+   - Parameter handling and strong params
+   - Response formats (HTML, JSON, Turbo Stream)
+   - Error handling and edge cases
+
+3. **Background Job Tests**:
+   - Job execution and success scenarios
+   - Retry logic and error handling
+   - Side effects and state changes
+   - Queue assignment and timing
+
+4. **Mailer Tests**:
+   - Email content and formatting
+   - Recipient handling and localization
+   - Attachment and delivery configurations
+   - Multi-locale support
+
+5. **JavaScript/Stimulus Tests**:
+   - Controller initialization and teardown
+   - User interaction handlers
+   - Form state management and dynamic updates
+   - Target and action mappings
+
+6. **Integration Tests**:
+   - Complete user workflows
+   - Cross-model interactions
+   - End-to-end feature functionality
+   - Authentication and authorization flows
+
+### Session-Specific Test Coverage
+For this codebase, ensure tests cover all recent changes including:
+- Enhanced LocatableLocation model with polymorphic associations
+- Event model with notification callbacks and location integration
+- Calendar and CalendarEntry associations
+- Event notification system (EventReminderNotifier, EventUpdateNotifier)
+- Background jobs for event reminders and scheduling
+- EventMailer with localized content
+- Dynamic location selector JavaScript controller
+- Form enhancements with location type selection
+
+### Test Quality Standards
+- Use descriptive test names that explain the expected behavior
+- Follow AAA pattern (Arrange, Act, Assert) in test structure
+- Mock external dependencies and network calls
+- Test both success and failure scenarios
+- Use shared examples for common behavior patterns
+- Ensure tests are deterministic and can run independently
 
 ## Project Architecture Notes
 

AGENTS.md

@@ -21,25 +21,28 @@ Instructions for GitHub Copilot and other automated contributors working in this
 - **Tests:** `bin/ci`
   (Equivalent: `cd spec/dummy && bundle exec rspec`)
 - **Lint:** `bundle exec rubocop`
-- **Security:** `bundle exec brakeman -q -w2` and `bundle exec bundler-audit --update`
+- **Security:** `bundle exec brakeman --quiet --no-pager` and `bundle exec bundler-audit --update`
 - **Style:** `bin/codex_style_guard`
 
 ## Security Requirements
-- **Always run Brakeman** before generating/committing code: `bundle exec brakeman -q`
-- **Address high-confidence vulnerabilities immediately** - anything with "High" confidence must be fixed
-- **Review medium-confidence warnings** - evaluate and fix security-relevant issues  
-- **Use safe coding practices:**
+## Security Requirements
+- **Run Brakeman before generating code**: `bundle exec brakeman --quiet --no-pager` 
+- **Fix high-confidence vulnerabilities immediately** - never ignore security warnings with "High" confidence
+- **Review and address medium-confidence warnings** that are security-relevant
+- **Safe coding practices when generating code:**
   - Never use `constantize`, `safe_constantize`, or `eval` on user input
   - Use allow-lists for dynamic class resolution (see `joatu_source_class` pattern)
   - Sanitize and validate all user inputs
   - Use strong parameters in controllers
   - Implement proper authorization checks (Pundit policies)
-- **For reflection-based code**: Create concern-based allow-lists using `included_in_models` pattern
-- **Run security scan after major changes**: `bundle exec brakeman -c UnsafeReflection,SQL,CrossSiteScripting`
+- **For reflection-based features**: Create concerns with `included_in_models` class methods for safe dynamic class resolution
+- **Post-generation security check**: Run `bundle exec brakeman --quiet --no-pager -c UnsafeReflection,SQL,CrossSiteScripting` after major code changes
 
 ## Conventions
 - Make incremental changes with passing tests.
-- **Security first**: Run `bundle exec brakeman -q` before committing code changes.
+- **Security first**: Run `bundle exec brakeman --quiet --no-pager` before committing code changes.
+- **Test every change**: Generate RSpec tests for all code modifications, including models, controllers, mailers, jobs, and JavaScript.
+- **Test coverage requirements**: All new features, bug fixes, and refactors must include comprehensive test coverage.
 - Avoid introducing new external services in tests; stub where possible.
 - If RuboCop reports offenses after autocorrect, update and rerun until clean.
 - Keep commit messages and PR descriptions concise and informative.
@@ -103,3 +106,35 @@ i18n-tasks health
 ```
 
 See `.github/instructions/i18n-mobility.instructions.md` for additional translation rules.
+
+# Testing Requirements
+
+## Mandatory Test Generation
+- **Every code change must include RSpec tests** covering the new or modified functionality.
+- **Generate factories for new models** using FactoryBot with realistic Faker-generated test data.
+- **Test all layers**: models (validations, associations, methods), controllers (actions, authorization), services, mailers, jobs, and view components.
+- **JavaScript/Stimulus testing**: Include feature specs that exercise dynamic behaviors like form interactions and AJAX updates.
+
+## Test Coverage Standards
+- **Models**: Test validations, associations, scopes, instance methods, class methods, and callbacks.
+- **Controllers**: Test all actions, authorization policies, parameter handling, and response formats.
+- **Mailers**: Test email content, recipients, localization, and delivery configurations.
+- **Jobs**: Test job execution, retry behavior, error handling, and side effects.
+- **JavaScript**: Test Stimulus controller behavior, form interactions, and dynamic content updates.
+- **Integration**: Test complete user workflows and cross-model interactions.
+
+## Session Coverage Requirements
+When making changes to existing code, generate tests that cover:
+- All modified models and their new/changed methods, associations, and validations
+- Any new background jobs, mailers, and notification systems
+- Controller actions that handle the new functionality
+- JavaScript controllers and dynamic form behaviors
+- Integration tests for complete user workflows
+- Edge cases and error conditions
+
+## Test Organization
+- Follow the existing RSpec structure and naming conventions.
+- Use FactoryBot factories instead of direct model creation.
+- Group related tests with descriptive context blocks.
+- Use shared examples for common behavior patterns.
+- Mock external dependencies and network calls.

app/javascript/controllers/better_together/location_selector_controller.js

@@ -0,0 +1,114 @@
+// Stimulus controller for dynamic location selection in event forms
+import { Controller } from "@hotwired/stimulus"
+
+export default class extends Controller {
+  static targets = [
+    "typeSelector",
+    "simpleLocation", 
+    "addressLocation",
+    "buildingLocation",
+    "addressTypeField",
+    "buildingTypeField"
+  ]
+
+  connect() {
+    // Initialize form state based on existing data
+    this.updateVisibility()
+  }
+
+  toggleLocationType(event) {
+    const selectedType = event.target.value
+    this.hideAllLocationTypes()
+    
+    switch(selectedType) {
+      case 'simple':
+        this.showSimpleLocation()
+        break
+      case 'address':
+        this.showAddressLocation()
+        break
+      case 'building':
+        this.showBuildingLocation()
+        break
+    }
+  }
+
+  hideAllLocationTypes() {
+    if (this.hasSimpleLocationTarget) {
+      this.simpleLocationTarget.style.display = 'none'
+    }
+    if (this.hasAddressLocationTarget) {
+      this.addressLocationTarget.style.display = 'none'
+    }
+    if (this.hasBuildingLocationTarget) {
+      this.buildingLocationTarget.style.display = 'none'
+    }
+  }
+
+  showSimpleLocation() {
+    if (this.hasSimpleLocationTarget) {
+      this.simpleLocationTarget.style.display = 'block'
+    }
+    // Clear structured location fields
+    this.clearStructuredLocationFields()
+  }
+
+  showAddressLocation() {
+    if (this.hasAddressLocationTarget) {
+      this.addressLocationTarget.style.display = 'block'
+    }
+    // Clear simple name field
+    this.clearSimpleLocationFields()
+  }
+
+  showBuildingLocation() {
+    if (this.hasBuildingLocationTarget) {
+      this.buildingLocationTarget.style.display = 'block'
+    }
+    // Clear simple name field
+    this.clearSimpleLocationFields()
+  }
+
+  updateAddressType(event) {
+    if (event.target.value && this.hasAddressTypeFieldTarget) {
+      // Type field should already be set in the hidden field
+    }
+  }
+
+  updateBuildingType(event) {
+    if (event.target.value && this.hasBuildingTypeFieldTarget) {
+      // Type field should already be set in the hidden field
+    }
+  }
+
+  updateVisibility() {
+    // Show the appropriate section based on current data
+    const checkedRadio = this.element.querySelector('input[name="location_type_selector"]:checked')
+    if (checkedRadio) {
+      this.toggleLocationType({ target: { value: checkedRadio.value } })
+    } else {
+      // Default to simple location if nothing is selected
+      this.hideAllLocationTypes()
+      this.showSimpleLocation()
+      const simpleRadio = this.element.querySelector('#simple_location')
+      if (simpleRadio) {
+        simpleRadio.checked = true
+      }
+    }
+  }
+
+  clearSimpleLocationFields() {
+    const nameField = this.element.querySelector('input[name*="[name]"]')
+    if (nameField) {
+      nameField.value = ''
+    }
+  }
+
+  clearStructuredLocationFields() {
+    // Clear location_id and location_type for structured locations
+    const locationIdFields = this.element.querySelectorAll('select[name*="[location_id]"]')
+    locationIdFields.forEach(field => {
+      field.selectedIndex = 0
+    })
+  }
+}

app/jobs/better_together/event_reminder_job.rb

@@ -0,0 +1,46 @@
+# frozen_string_literal: true
+
+module BetterTogether
+  # Job to send event reminders to attendees
+  class EventReminderJob < ApplicationJob
+    queue_as :notifications
+
+    def perform(event, reminder_type = '24_hours')
+      return unless event_valid?(event)
+
+      attendees = going_attendees(event)
+      send_reminders_to_attendees(event, attendees, reminder_type)
+      log_completion(event, attendees, reminder_type)
+    end
+
+    private
+
+    def event_valid?(event)
+      event.present? && event.starts_at.present?
+    end
+
+    def going_attendees(event)
+      event.attendees.joins(:event_attendances)
+           .where(better_together_event_attendances: { status: 'going' })
+    end
+
+    def send_reminders_to_attendees(event, attendees, reminder_type)
+      attendees.find_each do |attendee|
+        send_reminder_to_attendee(event, attendee, reminder_type)
+      end
+    end
+
+    def send_reminder_to_attendee(event, attendee, reminder_type)
+      BetterTogether::EventReminderNotifier.with(
+        event: event,
+        reminder_type: reminder_type
+      ).deliver(attendee)
+    rescue StandardError => e
+      Rails.logger.error "Failed to send event reminder to #{attendee.identifier}: #{e.message}"
+    end
+
+    def log_completion(event, attendees, reminder_type)
+      Rails.logger.info "Sent #{reminder_type} reminders for event #{event.identifier} to #{attendees.count} attendees"
+    end
+  end
+end