Rubocop fixes

rsmithlal · rsmithlal · commit e01bed8df937 · 2025-09-02T17:52:58.000-02:30
diff --git a/app/jobs/better_together/metrics/rich_text_external_link_checker_queue_job.rb b/app/jobs/better_together/metrics/rich_text_external_link_checker_queue_job.rb
@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 module BetterTogether
   module Metrics
     class RichTextExternalLinkCheckerQueueJob < RichTextLinkCheckerQueueJob
diff --git a/app/jobs/better_together/metrics/rich_text_internal_link_checker_queue_job.rb b/app/jobs/better_together/metrics/rich_text_internal_link_checker_queue_job.rb
@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 module BetterTogether
   module Metrics
     class RichTextInternalLinkCheckerQueueJob < RichTextLinkCheckerQueueJob
diff --git a/app/jobs/better_together/metrics/rich_text_link_checker_queue_job.rb b/app/jobs/better_together/metrics/rich_text_link_checker_queue_job.rb
@@ -1,7 +1,8 @@
+# frozen_string_literal: true
+
 module BetterTogether
   module Metrics
     class RichTextLinkCheckerQueueJob < MetricsJob
-
       def perform
         records_size = model_collection.size
         return if records_size.zero?
@@ -44,7 +45,7 @@ def queue_jobs_for_host(host, delay_between_requests)
 
       def child_job_class
         # Define this in subclasses (e.g., InternalLinkCheckerJob, ExternalLinkCheckerJob)
-        raise NotImplementedError, "Subclasses must implement `child_job_class`"
+        raise NotImplementedError, 'Subclasses must implement `child_job_class`'
       end
 
       def last_checked_lt
diff --git a/app/models/better_together/content/link.rb b/app/models/better_together/content/link.rb
@@ -1,7 +1,11 @@
+# frozen_string_literal: true
+
 module BetterTogether
-  class Content::Link < ApplicationRecord
-    has_many :rich_text_links, class_name: 'BetterTogether::Metrics::RichTextLink', inverse_of: :link
-    has_many :rich_texts, through: :rich_text_links
-    has_many :rich_text_records, through: :rich_text_links
+  module Content
+    class Link < ApplicationRecord
+      has_many :rich_text_links, class_name: 'BetterTogether::Metrics::RichTextLink', inverse_of: :link
+      has_many :rich_texts, through: :rich_text_links
+      has_many :rich_text_records, through: :rich_text_links
+    end
   end
 end
diff --git a/app/models/better_together/links.rb b/app/models/better_together/links.rb
@@ -1,7 +1,9 @@
+# frozen_string_literal: true
+
 module BetterTogether
   module Links
     def self.table_name_prefix
-      "better_together_links_"
+      'better_together_links_'
     end
   end
 end
diff --git a/app/models/better_together/metrics/rich_text_link.rb b/app/models/better_together/metrics/rich_text_link.rb
@@ -1,9 +1,13 @@
+# frozen_string_literal: true
+
 module BetterTogether
-  class Metrics::RichTextLink < ApplicationRecord
-    belongs_to :link, class_name: 'BetterTogether::Content::Link'
-    belongs_to :rich_text, class_name: 'ActionText::RichText'
-    belongs_to :rich_text_record, polymorphic: true
+  module Metrics
+    class RichTextLink < ApplicationRecord
+      belongs_to :link, class_name: 'BetterTogether::Content::Link'
+      belongs_to :rich_text, class_name: 'ActionText::RichText'
+      belongs_to :rich_text_record, polymorphic: true
 
-    accepts_nested_attributes_for :link, reject_if: ->(attributes){ attributes['url'].blank? }, allow_destroy: false
+      accepts_nested_attributes_for :link, reject_if: ->(attributes) { attributes['url'].blank? }, allow_destroy: false
+    end
   end
 end
diff --git a/db/migrate/20241124181740_create_better_together_content_links.rb b/db/migrate/20241124181740_create_better_together_content_links.rb
@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 class CreateBetterTogetherContentLinks < ActiveRecord::Migration[7.1]
   def change
     create_bt_table :links, prefix: :better_together_content do |t|
diff --git a/db/migrate/20241125190948_create_better_together_metrics_rich_text_links.rb b/db/migrate/20241125190948_create_better_together_metrics_rich_text_links.rb
@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 class CreateBetterTogetherMetricsRichTextLinks < ActiveRecord::Migration[7.1]
   def change
     create_bt_table :rich_text_links, prefix: :better_together_metrics do |t|
@@ -8,7 +10,7 @@ def change
       t.bt_position # index in the RichText links array
       t.bt_locale # locale of the RichText content
 
-      t.index [:rich_text_id, :position, :locale], unique: true
+      t.index %i[rich_text_id position locale], unique: true
     end
   end
 end
diff --git a/lib/tasks/quality_assurance.rake b/lib/tasks/quality_assurance.rake
@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 namespace :better_together do
   namespace :qa do
     namespace :rich_text do
@@ -20,58 +22,15 @@ namespace :better_together do
             next unless links.any?
 
             links.each_with_index do |link, index|
-              begin
-                uri = URI.parse(link)
-
-                internal_link = uri.host == platform_uri.host
-                link_type = determine_link_type(uri, internal_link)
-
-                if uri.host.nil? && uri.scheme.nil?
-                  invalid_type = if uri.path
-                                   'path'
-                                 elsif link.include?('mailto')
-                                   'email'
-                                 elsif link.include?('tel')
-                                   'phone'
-                                 else
-                                   'undetermined'
-                                 end
-
-                  invalid_rich_text_links << {
-                    rich_text_id: rt.id,
-                    rich_text_record_id: rt.record_id,
-                    rich_text_record_type: rt.record_type,
-                    locale: rt.locale,
-                    position: index, # Track the first position for clarity
-
-                    link_attributes: {
-                      url: link,
-                      link_type: "invalid:#{invalid_type}",
-                      valid_link: false,
-                      error_message: 'No host or scheme. Needs review.'
-                    }
-                  }
+              uri = URI.parse(link)
 
-                  next
-                end
+              internal_link = uri.host == platform_uri.host
+              link_type = determine_link_type(uri, internal_link)
 
-                valid_rich_text_links << {
-                  rich_text_id: rt.id,
-                  rich_text_record_id: rt.record_id,
-                  rich_text_record_type: rt.record_type,
-                  locale: rt.locale,
-                  position: index, # Track the first position for clarity
-
-                  link_attributes: {
-                    url: link,
-                    host: uri.host,
-                    link_type: link_type,
-                    valid_link: true,
-                    external: !internal_link
-                  }
-                }
-              rescue URI::InvalidURIError => e
-                invalid_type = if link.include?('mailto')
+              if uri.host.nil? && uri.scheme.nil?
+                invalid_type = if uri.path
+                                 'path'
+                               elsif link.include?('mailto')
                                  'email'
                                elsif link.include?('tel')
                                  'phone'
@@ -90,25 +49,75 @@ namespace :better_together do
                     url: link,
                     link_type: "invalid:#{invalid_type}",
                     valid_link: false,
-                    error_message: e.message,
+                    error_message: 'No host or scheme. Needs review.'
                   }
                 }
+
+                next
               end
+
+              valid_rich_text_links << {
+                rich_text_id: rt.id,
+                rich_text_record_id: rt.record_id,
+                rich_text_record_type: rt.record_type,
+                locale: rt.locale,
+                position: index, # Track the first position for clarity
+
+                link_attributes: {
+                  url: link,
+                  host: uri.host,
+                  link_type: link_type,
+                  valid_link: true,
+                  external: !internal_link
+                }
+              }
+            rescue URI::InvalidURIError => e
+              invalid_type = if link.include?('mailto')
+                               'email'
+                             elsif link.include?('tel')
+                               'phone'
+                             else
+                               'undetermined'
+                             end
+
+              invalid_rich_text_links << {
+                rich_text_id: rt.id,
+                rich_text_record_id: rt.record_id,
+                rich_text_record_type: rt.record_type,
+                locale: rt.locale,
+                position: index, # Track the first position for clarity
+
+                link_attributes: {
+                  url: link,
+                  link_type: "invalid:#{invalid_type}",
+                  valid_link: false,
+                  error_message: e.message
+                }
+              }
             end
           end
 
           # Upsert valid and invalid links
-          BetterTogether::Metrics::RichTextLink.upsert_all(valid_rich_text_links, unique_by: %i[rich_text_id position locale]) if valid_rich_text_links.any?
-          BetterTogether::Metrics::RichTextLink.upsert_all(invalid_rich_text_links, unique_by: %i[rich_text_id position locale]) if invalid_rich_text_links.any?
+          if valid_rich_text_links.any?
+            BetterTogether::Metrics::RichTextLink.upsert_all(valid_rich_text_links,
+                                                             unique_by: %i[rich_text_id position
+                                                                           locale])
+          end
+          if invalid_rich_text_links.any?
+            BetterTogether::Metrics::RichTextLink.upsert_all(invalid_rich_text_links,
+                                                             unique_by: %i[rich_text_id position
+                                                                           locale])
+          end
 
           puts "Valid links processed: #{valid_rich_text_links.size}"
           puts "Invalid links processed: #{invalid_rich_text_links.size}"
         end
 
         desc 'checks rich text links and returns their status code'
         task check: :environment do
-          internal_queue_job = BetterTogether::Metrics::RichTextInternalLinkCheckerQueueJob.new
-          external_queue_job = BetterTogether::Metrics::RichTextExternalLinkCheckerQueueJob.new; byebug
+          BetterTogether::Metrics::RichTextInternalLinkCheckerQueueJob.new
+          BetterTogether::Metrics::RichTextExternalLinkCheckerQueueJob.new
+          byebug
         end
 
         def determine_link_type(uri, internal_link)
diff --git a/spec/factories/better_together/metrics/rich_text_links.rb b/spec/factories/better_together/metrics/rich_text_links.rb
@@ -1,5 +1,6 @@
+# frozen_string_literal: true
+
 FactoryBot.define do
   factory :metrics_rich_text_link, class: 'Metrics::RichTextLink' do
-    
   end
 end
diff --git a/spec/models/better_together/metrics/rich_text_link_spec.rb b/spec/models/better_together/metrics/rich_text_link_spec.rb
@@ -1,7 +1,9 @@
+# frozen_string_literal: true
+
 require 'rails_helper'
 
 module BetterTogether
-  RSpec.describe Metrics::RichTextLink, type: :model do
+  RSpec.describe Metrics::RichTextLink do
     pending "add some examples to (or delete) #{__FILE__}"
   end
 end

Original file line number	Diff line number	Diff line change
`@@ -1,3 +1,5 @@`
	`1`	`+# frozen_string_literal: true`
	`2`	`+`
`1`	`3`	`module BetterTogether`
`2`	`4`	`module Metrics`
`3`	`5`	`class RichTextExternalLinkCheckerQueueJob < RichTextLinkCheckerQueueJob`
Original file line number	Diff line number	Diff line change
`@@ -1,3 +1,5 @@`
	`1`	`+# frozen_string_literal: true`
	`2`	`+`
`1`	`3`	`class CreateBetterTogetherContentLinks < ActiveRecord::Migration[7.1]`
`2`	`4`	`def change`
`3`	`5`	`create_bt_table :links, prefix: :better_together_content do \|t\|`