Rubocop fixes

Author: rsmithlal

Gemfile.lock

@@ -474,9 +474,9 @@ GEM
       actiontext (>= 6.0)
       mobility (~> 1.2)
     msgpack (1.8.0)
+    multi_json (1.17.0)
     multi_xml (0.7.1)
       bigdecimal (~> 3.1)
-    multi_json (1.17.0)
     multipart-post (2.4.1)
     mutex_m (0.3.0)
     net-http (0.6.0)

app/controllers/better_together/person_platform_integrations_controller.rb

@@ -23,10 +23,7 @@ def edit; end
 
     # POST /better_together/person_platform_integrations
     def create
-      # rubocop:todo Layout/LineLength
       @better_together_person_platform_integration = BetterTogether::PersonPlatformIntegration.new(person_platform_integration_params)
-      # rubocop:enable Layout/LineLength
-
       if @person_platform_integration.save
         redirect_to @person_platform_integration, notice: 'PersonPlatformIntegration was successfully created.'
       else

app/models/concerns/better_together/devise_user.rb

@@ -73,8 +73,8 @@ def send_confirmation_instructions(opts = {})
         send_devise_notification(:confirmation_instructions, @raw_confirmation_token, opts)
       end
 
-      def send_devise_notification(notification, *args)
-        devise_mailer.send(notification, self, *args).deliver_later
+      def send_devise_notification(notification, *)
+        devise_mailer.send(notification, self, *).deliver_later
       end
 
       # # override devise method to include additional info as opts hash

app/models/concerns/better_together/seedable.rb

@@ -141,8 +141,8 @@ def export_collection_as_seed( # rubocop:todo Metrics/MethodLength
         seed_hash
       end
 
-      def export_collection_as_seed_yaml(records, **opts)
-        export_collection_as_seed(records, **opts).deep_stringify_keys.to_yaml
+      def export_collection_as_seed_yaml(records, **)
+        export_collection_as_seed(records, **).deep_stringify_keys.to_yaml
       end
     end
   end

app/policies/better_together/person_block_policy.rb

@@ -6,8 +6,28 @@ def index?
       user.present?
     end
 
+    def new?
+      user.present?
+    end
+
     def create?
-      user.present? && record.blocker == agent && !record.blocked.permitted_to?('manage_platform')
+      # Must be logged in and be the blocker
+      return false unless user.present? && record.blocker == agent
+
+      # Must have a valid blocked person
+      return false unless record.blocked.present?
+
+      # Cannot block platform managers
+      !blocked_user_is_platform_manager?
+    end
+
+    private
+
+    def blocked_user_is_platform_manager?
+      return false unless record.blocked&.user
+
+      # Check if the blocked person's user has platform management permissions
+      record.blocked.user.permitted_to?('manage_platform')
     end
 
     def destroy?

spec/dummy/db/schema.rb

@@ -1,7 +1,7 @@
 # frozen_string_literal: true
 
-FactoryBot.define do # rubocop:todo Metrics/BlockLength
-  factory :better_together_seed, class: 'BetterTogether::Seed' do # rubocop:todo Metrics/BlockLength
+FactoryBot.define do
+  factory :better_together_seed, class: 'BetterTogether::Seed' do
     id { SecureRandom.uuid }
     version { '1.0' }
     created_by { 'Better Together Solutions' }

spec/factories/better_together/seeds.rb

@@ -12,6 +12,6 @@
 #     end
 #   end
 # end
-RSpec.describe BetterTogether::PersonPlatformIntegrationsHelper, type: :helper do
+RSpec.describe BetterTogether::PersonPlatformIntegrationsHelper do
   pending "add some examples to (or delete) #{__FILE__}"
 end

spec/helpers/better_together/person_platform_integrations_helper_spec.rb

@@ -13,7 +13,7 @@
 #   end
 # end
 module BetterTogether
-  RSpec.describe SeedsHelper, type: :helper do
+  RSpec.describe SeedsHelper do
     pending "add some examples to (or delete) #{__FILE__}"
   end
 end

spec/helpers/better_together/seeds_helper_spec.rb

@@ -2,6 +2,6 @@
 
 require 'rails_helper'
 
-RSpec.describe BetterTogether::PersonPlatformIntegration, type: :model do
+RSpec.describe BetterTogether::PersonPlatformIntegration do
   pending "add some examples to (or delete) #{__FILE__}"
 end