adds logic to send message notification emails

do not send if user has email preferences disabled.
delay 15 minutes to give time to mark notification as read. only send one email per unread notifications per conversation

Author: Kneeba921

app/controllers/better_together/messages_controller.rb

@@ -35,7 +35,8 @@ def notify_participants(message)
       recipients = message.conversation.participants.where.not(id: message.sender_id)
 
       # Pass the array of recipients to the notification
-      BetterTogether::NewMessageNotifier.with(record: message).deliver_later(recipients)
+      BetterTogether::NewMessageNotifier.with(record: message,
+                                              conversation_id: message.conversation_id).deliver_later(recipients)
     end
 
     def broadcast_to_recipients(message, recipients)

app/notifiers/better_together/new_message_notifier.rb

@@ -33,37 +33,24 @@ def sender
       delegate :url, to: :event
 
       def send_email_notification?
-        recipient.email.present? && should_send_email?
+        recipient.email.present? && recipient.notification_preferences['notify_by_email'] && should_send_email?
       end
 
-      # rubocop:todo Metrics/MethodLength
-      def should_send_email? # rubocop:todo Metrics/AbcSize, Metrics/MethodLength
-        # Find the events related to the conversation
-        related_event_ids = BetterTogether::NewMessageNotifier.where(params: { conversation_id: conversation.id })
-                                                              .pluck(:id)
+      def should_send_email?
+        # Check for unread notifications for the recipient for the record's conversation
+        unread_notifications = recipient.notifications.where(
+          event_id: BetterTogether::NewMessageNotifier.where(params: { conversation_id: conversation.id }).select(:id),
+          read_at: nil
+        ).order(created_at: :desc)
 
-        # Check for unread notifications for the recipient related to these events
-        unread_notifications = recipient.notifications
-                                        .where(event_id: related_event_ids, read_at: nil)
-
-        if unread_notifications.empty? || (unread_notifications.last.created_at <= 1.day.ago)
-          # No unread recent notifications, send the email
-          true
+        if unread_notifications.none?
+          # If the recipient has read their notifications, do not send
+          false
         else
-          # Optional: Implement a time-based delay or other conditions
-          last_email_sent_at = recipient.notifications
-                                        .where(event_id: related_event_ids)
-                                        .order(created_at: :desc)
-                                        .pluck(:created_at)
-                                        .first
-
-          return true if last_email_sent_at.blank? # Send if no previous email sent
-
-          # Send email only if more than 30 minutes have passed since the last one
-          last_email_sent_at < 30.minutes.ago
+          # Only send one email per unread notifications per conversation
+          message.id == unread_notifications.first.event.record_id
         end
       end
-      # rubocop:enable Metrics/MethodLength
     end
 
     def identifier