Rubocop fixes

Author: rsmithlal

app/helpers/better_together/navigation_items_helper.rb

@@ -1,9 +1,12 @@
 # frozen_string_literal: true
 
 module BetterTogether
-  module NavigationItemsHelper # rubocop:todo Style/Documentation
+  # rubocop:todo Metrics/ModuleLength
+  module NavigationItemsHelper # rubocop:todo Style/Documentation, Metrics/ModuleLength
     def better_together_nav_area
-      @better_together_nav_area ||= ::BetterTogether::NavigationArea.find_by(identifier: 'better-together')
+  # rubocop:todo Layout/IndentationWidth
+  @better_together_nav_area ||= ::BetterTogether::NavigationArea.find_by(identifier: 'better-together')
+      # rubocop:enable Layout/IndentationWidth
     end
 
     # Retrieves navigation items for the BetterTogether header navigation.
@@ -79,7 +82,8 @@ def platform_footer_nav_area
     def mailer_footer_nav_items
       # Preload navigation items and their translations in a single query
       Mobility.with_locale(current_locale) do
-        @mailer_footer_nav_items ||= platform_footer_nav_area&.top_level_nav_items_includes_children.excluding_hashed || []
+        @mailer_footer_nav_items ||=
+          platform_footer_nav_area&.top_level_nav_items_includes_children&.excluding_hashed || []
       end
     end
 
@@ -113,7 +117,8 @@ def platform_header_nav_items
     def mailer_header_nav_items
       # Preload navigation items and their translations in a single query
       Mobility.with_locale(current_locale) do
-        @mailer_header_nav_items ||= platform_header_nav_area.top_level_nav_items_includes_children.excluding_hashed || []
+        @mailer_header_nav_items ||=
+          platform_header_nav_area.top_level_nav_items_includes_children.excluding_hashed || []
       end
     end
 
@@ -138,4 +143,5 @@ def current_locale
       I18n.locale
     end
   end
+  # rubocop:enable Metrics/ModuleLength
 end

lib/tasks/data_migration.rake

@@ -4,7 +4,7 @@ namespace :better_together do # rubocop:todo Metrics/BlockLength
   namespace :migrate_data do # rubocop:todo Metrics/BlockLength
     desc 'Migrate nav item route name values from _path to _url'
     task nav_item_route_name_to_url: :environment do
-      nav_items = BetterTogether::NavigationItem.where("route_name ILIKE ?", '%_path')
+      nav_items = BetterTogether::NavigationItem.where('route_name ILIKE ?', '%_path')
 
       puts nav_items.size