Remove unlisted as an option for privacy

This commit updates all tables that include a "privacy" column so that the default is uniformly set to "private". In addition, any existing records that were marked as "unlisted" (or "public") have been updated to "private", since the "unlisted" option is not currently implemented.

Below is a summary of the changes made:

| Table Name                              | Previous Default | New Default |
|-----------------------------------------|------------------|-------------|
| better_together_addresses               | unlisted         | private     |
| better_together_communities             | public           | private     |
| better_together_content_blocks          | unlisted         | private     |
| better_together_email_addresses         | unlisted         | private     |
| better_together_pages                   | public           | private     |
| better_together_people                  | unlisted         | private     |
| better_together_phone_numbers           | unlisted         | private     |
| better_together_platforms               | public           | private     |
| better_together_posts                   | private          | private     |
| better_together_social_media_accounts   | public           | private     |
| better_together_website_links           | unlisted         | private     |

Author: rsmithlal

app/models/concerns/better_together/privacy.rb

@@ -7,8 +7,7 @@ module Privacy
 
     PRIVACY_LEVELS = {
       public: 'public',
-      private: 'private',
-      unlisted: 'unlisted'
+      private: 'private'
     }.freeze
 
     included do

db/migrate/20250304142407_set_privacy_default_private.rb

@@ -0,0 +1,24 @@
+# frozen_string_literal: true
+
+# Ensures that all tables with the privacy column default to private and replaces existing 'unlisted' values with 'private'
+class SetPrivacyDefaultPrivate < ActiveRecord::Migration[7.1]
+  def up
+    ActiveRecord::Base.connection.tables.each do |table|
+      next unless column_exists?(table, :privacy)
+
+      # Replace existing 'unlisted' values with 'private'
+      execute "UPDATE #{table} SET privacy = 'private' WHERE privacy = 'unlisted'"
+
+      privacy_column = ActiveRecord::Base.connection.columns(table).find { |col| col.name == 'privacy' }
+      next unless privacy_column
+      next if privacy_column.default == 'private'
+
+      say "Changing default privacy for table #{table} from #{privacy_column.default.inspect} to 'private'"
+      change_column_default table, :privacy, 'private'
+    end
+  end
+
+  def down
+    # No reversal defined as reverting the default value change and data update is not supported.
+  end
+end

spec/dummy/db/schema.rb

@@ -10,7 +10,7 @@
 #
 # It's strongly recommended that you check this file into your version control system.
 
-ActiveRecord::Schema[7.1].define(version: 2025_02_28_154526) do
+ActiveRecord::Schema[7.1].define(version: 2025_03_04_142407) do
   # These are extensions that must be enabled in order to support this database
   enable_extension "pgcrypto"
   enable_extension "plpgsql"
@@ -68,7 +68,7 @@
     t.string "state_province_name"
     t.string "postal_code"
     t.string "country_name"
-    t.string "privacy", limit: 50, default: "unlisted", null: false
+    t.string "privacy", limit: 50, default: "private", null: false
     t.uuid "contact_detail_id", null: false
     t.boolean "primary_flag", default: false, null: false
     t.index ["contact_detail_id", "primary_flag"], name: "index_bt_addresses_on_contact_detail_id_and_primary", unique: true, where: "(primary_flag IS TRUE)"
@@ -143,7 +143,7 @@
     t.string "identifier", limit: 100, null: false
     t.boolean "host", default: false, null: false
     t.boolean "protected", default: false, null: false
-    t.string "privacy", limit: 50, default: "public", null: false
+    t.string "privacy", limit: 50, default: "private", null: false
     t.string "slug"
     t.uuid "creator_id"
     t.string "type", default: "BetterTogether::Community", null: false
@@ -178,7 +178,7 @@
     t.jsonb "media_settings", default: {}, null: false
     t.jsonb "content_data", default: {}
     t.uuid "creator_id"
-    t.string "privacy", limit: 50, default: "unlisted", null: false
+    t.string "privacy", limit: 50, default: "private", null: false
     t.boolean "visible", default: true, null: false
     t.jsonb "content_area_settings", default: {}, null: false
     t.index ["creator_id"], name: "by_better_together_content_blocks_creator"
@@ -233,7 +233,7 @@
     t.datetime "updated_at", null: false
     t.string "email", null: false
     t.string "label", null: false
-    t.string "privacy", limit: 50, default: "unlisted", null: false
+    t.string "privacy", limit: 50, default: "private", null: false
     t.uuid "contact_detail_id", null: false
     t.boolean "primary_flag", default: false, null: false
     t.index ["contact_detail_id", "primary_flag"], name: "index_bt_email_addresses_on_contact_detail_id_and_primary", unique: true, where: "(primary_flag IS TRUE)"
@@ -543,7 +543,7 @@
     t.text "meta_description"
     t.string "keywords"
     t.datetime "published_at"
-    t.string "privacy", default: "public", null: false
+    t.string "privacy", default: "private", null: false
     t.string "layout"
     t.string "template"
     t.uuid "sidebar_nav_id"
@@ -562,7 +562,7 @@
     t.string "slug"
     t.uuid "community_id", null: false
     t.jsonb "preferences", default: {}, null: false
-    t.string "privacy", limit: 50, default: "unlisted", null: false
+    t.string "privacy", limit: 50, default: "private", null: false
     t.index ["community_id"], name: "by_person_community"
     t.index ["identifier"], name: "index_better_together_people_on_identifier", unique: true
     t.index ["privacy"], name: "by_better_together_people_privacy"
@@ -624,7 +624,7 @@
     t.datetime "updated_at", null: false
     t.string "number", null: false
     t.string "label", null: false
-    t.string "privacy", limit: 50, default: "unlisted", null: false
+    t.string "privacy", limit: 50, default: "private", null: false
     t.uuid "contact_detail_id", null: false
     t.boolean "primary_flag", default: false, null: false
     t.index ["contact_detail_id", "primary_flag"], name: "index_bt_phone_numbers_on_contact_detail_id_and_primary", unique: true, where: "(primary_flag IS TRUE)"
@@ -672,7 +672,7 @@
     t.string "identifier", limit: 100, null: false
     t.boolean "host", default: false, null: false
     t.boolean "protected", default: false, null: false
-    t.string "privacy", limit: 50, default: "public", null: false
+    t.string "privacy", limit: 50, default: "private", null: false
     t.string "slug"
     t.uuid "community_id"
     t.string "url", null: false
@@ -750,7 +750,7 @@
     t.string "platform", null: false
     t.string "handle", null: false
     t.string "url"
-    t.string "privacy", limit: 50, default: "public", null: false
+    t.string "privacy", limit: 50, default: "private", null: false
     t.uuid "contact_detail_id", null: false
     t.index ["contact_detail_id", "platform"], name: "index_bt_sma_on_contact_detail_and_platform", unique: true
     t.index ["contact_detail_id"], name: "idx_on_contact_detail_id_6380b64b3b"
@@ -790,7 +790,7 @@
     t.datetime "updated_at", null: false
     t.string "url", null: false
     t.string "label", null: false
-    t.string "privacy", limit: 50, default: "unlisted", null: false
+    t.string "privacy", limit: 50, default: "private", null: false
     t.uuid "contact_detail_id", null: false
     t.index ["contact_detail_id"], name: "index_better_together_website_links_on_contact_detail_id"
     t.index ["privacy"], name: "by_better_together_website_links_privacy"