Fix rspec failures

Author: rsmithlal

spec/features/invitations/platform_invitation_accept_spec.rb

@@ -5,7 +5,7 @@
 RSpec.describe 'accepting a platform invitation' do
   include BetterTogether::DeviseSessionHelpers
 
-  let(:invitation) do
+  let!(:invitation) do
     create(:better_together_platform_invitation,
            invitable: configure_host_platform)
   end

spec/features/joatu/respond_with_request_hidden_when_response_spec.rb

@@ -6,9 +6,11 @@
   let!(:person) { create(:person) }
   let!(:other)  { create(:person) }
 
+  include BetterTogether::DeviseSessionHelpers
+
   before do
+    configure_host_platform
     # sign in the request creator and create an offer response owned by other
-    login_as(other, scope: :person)
     # create a request belonging to person
     @request = create(:better_together_joatu_request, creator: person)
     # create an offer that is a response to the request (nested attributes or direct link)
@@ -19,8 +21,8 @@
     # rubocop:enable RSpec/InstanceVariable
 
     # sign in as the request creator to view the offer
-    logout(:person)
-    login_as(person, scope: :person)
+    logout(:user)
+    login_as(BetterTogether::User.find_by(email: '[email protected]'), scope: :user)
   end
 
   it 'does not render Respond with Request button on an offer that is a response to my request' do

spec/features/notifications/unread_badge_spec.rb

@@ -9,7 +9,7 @@
   before do
     configure_host_platform
     logout(:user)
-    login('[email protected]', 'password12345')
+    login_as_platform_manager
   end
 
   it 'updates badge and title based on unread count', :js do # rubocop:todo RSpec/ExampleLength, RSpec/MultipleExpectations

spec/requests/better_together/events_controller_spec.rb

@@ -6,10 +6,12 @@
   include RequestSpecHelper
 
   let(:locale) { I18n.default_locale }
+  let!(:user) { create(:user, :confirmed) }
 
   before do
     configure_host_platform
     logout(:user)
+    login_as(user, scope: :user)
   end
 
   describe 'GET /events/:id.ics' do

spec/requests/better_together/navigation_areas_controller_spec.rb

@@ -3,6 +3,8 @@
 require 'rails_helper'
 
 RSpec.describe 'BetterTogether::NavigationAreasController' do
+  include RequestSpecHelper
+
   let(:locale) { I18n.default_locale }
 
   before do