From ad0e56723c864291295a0aabcba2588938d23f58 Mon Sep 17 00:00:00 2001 From: Robert Smith Date: Mon, 11 Aug 2025 15:44:31 -0230 Subject: [PATCH 1/3] Toggle github action rails 8.0 entry allow failure false --- .github/workflows/rubyonrails.yml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.github/workflows/rubyonrails.yml b/.github/workflows/rubyonrails.yml index 47d749294..5f2e88557 100644 --- a/.github/workflows/rubyonrails.yml +++ b/.github/workflows/rubyonrails.yml @@ -18,7 +18,7 @@ jobs: # allowed_failure: true # ⚠️ allowed to fail - ruby: '3.4.4' rails: '8.0' - allowed_failure: true # ⚠️ allowed to fail + allowed_failure: false # ⚠️ allowed to fail env: RAILS_ENV: test From 54d23a599e7c419ca018b39915948252e813d42c Mon Sep 17 00:00:00 2001 From: Robert Smith Date: Tue, 12 Aug 2025 14:29:21 -0230 Subject: [PATCH 2/3] Avoid modifying frozen autoload paths for Rails 8 --- lib/better_together/engine.rb | 18 ++++++++++-------- 1 file changed, 10 insertions(+), 8 deletions(-) diff --git a/lib/better_together/engine.rb b/lib/better_together/engine.rb index 0344ade23..4d56ce6e2 100644 --- a/lib/better_together/engine.rb +++ b/lib/better_together/engine.rb @@ -53,14 +53,16 @@ class Engine < ::Rails::Engine end config.before_initialize do - require_dependency 'friendly_id' - require_dependency 'mobility' - require_dependency 'friendly_id/mobility' - require_dependency 'jsonapi-resources' - require_dependency 'importmap-rails' - require_dependency 'public_activity' - require_dependency 'pundit' - require_dependency 'rack/cors' + # Use `require` instead of `require_dependency` for external gems to avoid + # modifying Rails' frozen autoload paths (Rails 8 compatibility) + require 'friendly_id' + require 'mobility' + require 'friendly_id/mobility' + require 'jsonapi-resources' + require 'importmap-rails' + require 'public_activity' + require 'pundit' + require 'rack/cors' end default_url_options = { From dde5f6a66249a75d765fab9e15d2bde613785205 Mon Sep 17 00:00:00 2001 From: Robert Smith Date: Tue, 12 Aug 2025 14:59:25 -0230 Subject: [PATCH 3/3] chore: adjust autoload path for Rails 8 --- lib/better_together/engine.rb | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/lib/better_together/engine.rb b/lib/better_together/engine.rb index 4d56ce6e2..0096f2ef2 100644 --- a/lib/better_together/engine.rb +++ b/lib/better_together/engine.rb @@ -44,7 +44,7 @@ class Engine < ::Rails::Engine isolate_namespace BetterTogether # Avoid modifying frozen autoload path arrays (Rails 8 compatibility) - config.autoload_paths = Array(config.autoload_paths) + Dir["#{root}/lib/better_together/**/"] + paths.add 'lib', eager_load: true config.generators do |g| g.orm :active_record, primary_key_type: :uuid