Add back missing tests

Author: AdrienVannson

tests/test_module_validation.py

@@ -0,0 +1,110 @@
+from typing import (
+    List,
+    Optional,
+    Set,
+)
+
+import pytest
+from betterproto2.plugin.module_validation import ModuleValidator
+
+
+@pytest.mark.parametrize(
+    ["text", "expected_collisions"],
+    [
+        pytest.param(
+            ["import os"],
+            None,
+            id="single import",
+        ),
+        pytest.param(
+            ["import os", "import sys"],
+            None,
+            id="multiple imports",
+        ),
+        pytest.param(
+            ["import os", "import os"],
+            {"os"},
+            id="duplicate imports",
+        ),
+        pytest.param(
+            ["from os import path", "import os"],
+            None,
+            id="duplicate imports with alias",
+        ),
+        pytest.param(
+            ["from os import path", "import os as os_alias"],
+            None,
+            id="duplicate imports with alias",
+        ),
+        pytest.param(
+            ["from os import path", "import os as path"],
+            {"path"},
+            id="duplicate imports with alias",
+        ),
+        pytest.param(
+            ["import os", "class os:"],
+            {"os"},
+            id="duplicate import with class",
+        ),
+        pytest.param(
+            ["import os", "class os:", "  pass", "import sys"],
+            {"os"},
+            id="duplicate import with class and another",
+        ),
+        pytest.param(
+            ["def test(): pass", "class test:"],
+            {"test"},
+            id="duplicate class and function",
+        ),
+        pytest.param(
+            ["def test(): pass", "def test(): pass"],
+            {"test"},
+            id="duplicate functions",
+        ),
+        pytest.param(
+            ["def test(): pass", "test = 100"],
+            {"test"},
+            id="function and variable",
+        ),
+        pytest.param(
+            ["def test():", "    test = 3"],
+            None,
+            id="function and variable in function",
+        ),
+        pytest.param(
+            [
+                "def test(): pass",
+                "'''",
+                "def test(): pass",
+                "'''",
+                "def test_2(): pass",
+            ],
+            None,
+            id="duplicate functions with multiline string",
+        ),
+        pytest.param(
+            ["def test(): pass", "# def test(): pass"],
+            None,
+            id="duplicate functions with comments",
+        ),
+        pytest.param(
+            ["from test import (", "    A", "   B", "   C", ")"],
+            None,
+            id="multiline import",
+        ),
+        pytest.param(
+            ["from test import (", "    A", "   B", "   C", ")", "from test import A"],
+            {"A"},
+            id="multiline import with duplicate",
+        ),
+    ],
+)
+def test_module_validator(text: List[str], expected_collisions: Optional[Set[str]]):
+    line_iterator = iter(text)
+    validator = ModuleValidator(line_iterator)
+    valid = validator.validate()
+    if expected_collisions is None:
+        assert valid
+    else:
+        assert set(validator.collisions.keys()) == expected_collisions
+        assert not valid

tests/test_typing_compiler.py

@@ -0,0 +1,70 @@
+from betterproto2.plugin.typing_compiler import (
+    DirectImportTypingCompiler,
+    NoTyping310TypingCompiler,
+    TypingImportTypingCompiler,
+)
+
+
+def test_direct_import_typing_compiler():
+    compiler = DirectImportTypingCompiler()
+    assert compiler.imports() == {}
+    assert compiler.optional("str") == "Optional[str]"
+    assert compiler.imports() == {"typing": {"Optional"}}
+    assert compiler.list("str") == "List[str]"
+    assert compiler.imports() == {"typing": {"Optional", "List"}}
+    assert compiler.dict("str", "int") == "Dict[str, int]"
+    assert compiler.imports() == {"typing": {"Optional", "List", "Dict"}}
+    assert compiler.union("str", "int") == "Union[str, int]"
+    assert compiler.imports() == {"typing": {"Optional", "List", "Dict", "Union"}}
+    assert compiler.iterable("str") == "Iterable[str]"
+    assert compiler.imports() == {"typing": {"Optional", "List", "Dict", "Union", "Iterable"}}
+    assert compiler.async_iterable("str") == "AsyncIterable[str]"
+    assert compiler.imports() == {"typing": {"Optional", "List", "Dict", "Union", "Iterable", "AsyncIterable"}}
+    assert compiler.async_iterator("str") == "AsyncIterator[str]"
+    assert compiler.imports() == {
+        "typing": {
+            "Optional",
+            "List",
+            "Dict",
+            "Union",
+            "Iterable",
+            "AsyncIterable",
+            "AsyncIterator",
+        }
+    }
+
+
+def test_typing_import_typing_compiler():
+    compiler = TypingImportTypingCompiler()
+    assert compiler.imports() == {}
+    assert compiler.optional("str") == "typing.Optional[str]"
+    assert compiler.imports() == {"typing": None}
+    assert compiler.list("str") == "typing.List[str]"
+    assert compiler.imports() == {"typing": None}
+    assert compiler.dict("str", "int") == "typing.Dict[str, int]"
+    assert compiler.imports() == {"typing": None}
+    assert compiler.union("str", "int") == "typing.Union[str, int]"
+    assert compiler.imports() == {"typing": None}
+    assert compiler.iterable("str") == "typing.Iterable[str]"
+    assert compiler.imports() == {"typing": None}
+    assert compiler.async_iterable("str") == "typing.AsyncIterable[str]"
+    assert compiler.imports() == {"typing": None}
+    assert compiler.async_iterator("str") == "typing.AsyncIterator[str]"
+    assert compiler.imports() == {"typing": None}
+
+
+def test_no_typing_311_typing_compiler():
+    compiler = NoTyping310TypingCompiler()
+    assert compiler.imports() == {}
+    assert compiler.optional("str") == "str | None"
+    assert compiler.imports() == {}
+    assert compiler.list("str") == "list[str]"
+    assert compiler.imports() == {}
+    assert compiler.dict("str", "int") == "dict[str, int]"
+    assert compiler.imports() == {}
+    assert compiler.union("str", "int") == "str | int"
+    assert compiler.imports() == {}
+    assert compiler.iterable("str") == "Iterable[str]"
+    assert compiler.async_iterable("str") == "AsyncIterable[str]"
+    assert compiler.async_iterator("str") == "AsyncIterator[str]"
+    assert compiler.imports() == {"collections.abc": {"Iterable", "AsyncIterable", "AsyncIterator"}}