realtek: RTL930x/RTL931x led_set defines, and led-sync pin configuration

Add defines for RTL930x and RTL931x led_set 'modes' (to avoid magic numbers
in dts files).

Add support for led-sync pin usage on RTL930x and RTL931x devices.
This allows for the HC595 shift register LED support provided by these chips.

Also tidy up the handling of led_sets on rtl930x devices (so it doesn't
produce errors for missing led_sets)

Signed-off-by: Bevan Weiss <bevan.weiss@gmail.com>

Author: bevanweiss

target/linux/realtek/dts/rtl930x.dtsi

@@ -10,6 +10,22 @@
 		sds = <##s>; \
 	};
 
+// LED Set mode definitions
+#define RTL930X_LED_SET_NONE        0
+#define RTL930X_LED_SET_10G         1 << 0
+#define RTL930X_LED_SET_5G          1 << 1
+#define RTL930X_LED_SET_2P5G        1 << 3
+#define RTL930X_LED_SET_1G          1 << 5
+#define RTL930X_LED_SET_100M        1 << 7
+#define RTL930X_LED_SET_10M         1 << 8
+#define RTL930X_LED_SET_LINK        1 << 9
+#define RTL930X_LED_SET_LINK_BLINK  1 << 10
+#define RTL930X_LED_SET_ACT         1 << 11
+#define RTL930X_LED_SET_RX          1 << 12
+#define RTL930X_LED_SET_TX          1 << 13
+#define RTL930X_LED_SET_COLLISION   1 << 14
+#define RTL930X_LED_SET_DUPLEX      1 << 15
+
 / {
 	#address-cells = <1>;
 	#size-cells = <1>;

target/linux/realtek/dts/rtl931x.dtsi

@@ -12,6 +12,22 @@
 		sds = <##s>; \
 	};
 
+// LED Set mode definitions
+#define RTL931X_LED_SET_NONE        0
+#define RTL931X_LED_SET_10G         1 << 0
+#define RTL931X_LED_SET_5G          1 << 1
+#define RTL931X_LED_SET_2P5G        1 << 3
+#define RTL931X_LED_SET_1G          1 << 5
+#define RTL931X_LED_SET_100M        1 << 7
+#define RTL931X_LED_SET_10M         1 << 8
+#define RTL931X_LED_SET_LINK        1 << 9
+#define RTL931X_LED_SET_LINK_BLINK  1 << 10
+#define RTL931X_LED_SET_ACT         1 << 11
+#define RTL931X_LED_SET_RX          1 << 12
+#define RTL931X_LED_SET_TX          1 << 13
+#define RTL931X_LED_SET_COLLISION   1 << 14
+#define RTL931X_LED_SET_DUPLEX      1 << 15
+
 / {
 	#address-cells = <1>;
 	#size-cells = <1>;

target/linux/realtek/files-6.12/arch/mips/include/asm/mach-rtl838x/mach-rtl83xx.h

@@ -230,6 +230,8 @@
 #define RTL93XX_MODEL_NAME_INFO		(0x0004)
 #define RTL93XX_CHIP_INFO		(0x0008)
 
+#define RTL930X_GPIO_SEL_CTRL		(0x0200)
+
 #define RTL838X_LED_GLB_CTRL		(0xA000)
 #define RTL839X_LED_GLB_CTRL		(0x00E4)
 #define RTL9302_LED_GLB_CTRL		(0xcc00)

target/linux/realtek/files-6.12/drivers/net/dsa/rtl83xx/rtl930x.c

@@ -22,6 +22,8 @@
 #define RTL930X_VLAN_PORT_TAG_STS_CTRL_IGR_P_OTAG_KEEP_MASK	GENMASK(1,1)
 #define RTL930X_VLAN_PORT_TAG_STS_CTRL_IGR_P_ITAG_KEEP_MASK	GENMASK(0,0)
 
+#define RTL930X_GPIO_SEL_GPIO19_LEDSYNC_SEL		BIT(11)
+
 #define RTL930X_LED_GLB_ACTIVE_LOW				BIT(22)
 
 #define RTL930X_LED_SETX_0_CTRL(x) (RTL930X_LED_SET0_0_CTRL - (x * 8))
@@ -2272,11 +2274,20 @@ static void rtl930x_led_init(struct rtl838x_switch_priv *priv)
 		sprintf(set_name, "led_set%d", set);
 		leds_in_this_set = of_property_count_u32_elems(node, set_name);
 
-		if (leds_in_this_set == 0 || leds_in_this_set > sizeof(set_config)) {
-			pr_err("%s led_set configuration invalid skipping over this set\n", __func__);
+		if (leds_in_this_set == -EINVAL) {
+			// if this led_setX property is not present, skip it silently
 			continue;
 		}
 
+		if (leds_in_this_set <= 0 || leds_in_this_set > sizeof(set_config)) {
+			pr_err("%s: %s configuration invalid skipping over this set, leds_in_this_set=%d (should be >0 and <=%d\n",
+				__func__, set_name, leds_in_this_set, sizeof(set_config));
+			continue;
+		}
+		else {
+			pr_info("%s: %s has %d LEDs configured\n", __func__, set_name, leds_in_this_set);
+		}
+
 		if (of_property_read_u32_array(node, set_name, set_config, leds_in_this_set)) {
 			break;
 		}
@@ -2312,6 +2323,12 @@ static void rtl930x_led_init(struct rtl838x_switch_priv *priv)
 	/* Set LED mode to serial (0x1) */
 	sw_w32_mask(0x3, 0x1, RTL930X_LED_GLB_CTRL);
 
+	/* Enable GPIO19_LEDSYNC if utilised */
+	if (of_property_read_bool(node, "led-sync"))
+		sw_w32_mask(0,RTL930X_GPIO_SEL_GPIO19_LEDSYNC_SEL,RTL930X_GPIO_SEL_CTRL);
+	else
+		sw_w32_mask(RTL930X_GPIO_SEL_GPIO19_LEDSYNC_SEL, 0, RTL930X_GPIO_SEL_CTRL);
+
 	/* Set LED active state */
 	if (of_property_read_bool(node, "active-low"))
 		sw_w32_mask(RTL930X_LED_GLB_ACTIVE_LOW, 0, RTL930X_LED_GLB_CTRL);

target/linux/realtek/files-6.12/drivers/net/dsa/rtl83xx/rtl931x.c

@@ -25,6 +25,8 @@
 #define RTL931X_VLAN_PORT_TAG_ITPID_IDX_MASK			GENMASK(2,1)
 #define RTL931X_VLAN_PORT_TAG_ITPID_KEEP_MASK			GENMASK(0,0)
 
+#define RTL930X_GPIO_SEL_GPIO31_LEDSYNC_SEL 			BIT(16)
+
 extern struct mutex smi_lock;
 extern struct rtl83xx_soc_info soc_info;
 
@@ -1651,6 +1653,12 @@ static void rtldsa_931x_led_init(struct rtl838x_switch_priv *priv)
 	/* Set LED mode to serial (0x1) */
 	sw_w32_mask(0x3, 0x1, RTL931X_LED_GLB_CTRL);
 
+	/* Enable GPIO31_LEDSYNC if utilised */
+	if (of_property_read_bool(node, "led-sync"))
+		sw_w32_mask(0, RTL930X_GPIO_SEL_GPIO31_LEDSYNC_SEL, RTL931X_MAC_L2_GLOBAL_CTRL2);
+	else
+		sw_w32_mask(RTL930X_GPIO_SEL_GPIO31_LEDSYNC_SEL, 0, RTL931X_MAC_L2_GLOBAL_CTRL2);
+
 	rtl839x_set_port_reg_le(pm_copper, RTL931X_LED_PORT_COPR_MASK_CTRL);
 	rtl839x_set_port_reg_le(pm_fiber, RTL931X_LED_PORT_FIB_MASK_CTRL);
 	rtl839x_set_port_reg_le(pm_copper | pm_fiber, RTL931X_LED_PORT_COMBO_MASK_CTRL);