Support for mocking multiple times

[santiagoparradev]

sometimes the same query can run múltiple times throughout a process

it would be great to be able to
SOQL.mockOnce(mockId, firstCall);
SOQL.mockOnce(mockId, secondCall);

[pgajek2]

Hi @santiagoparradev ,

As far as I understand, you would like a "stack" from which the mocked result will be retrieved.

e.g.

Account accountA = new Account(Name = 'Test A');
SOQL.mock('AccountQuery', accountA);

Account accountB = new Account(Name = 'Test B');
SOQL.mock('AccountQuery', accountB);

Test.startTest();
Account account1 = SOQL.of(Account.SObjectType).mockId('AccountQuery').toObject();
Account account2 = SOQL.of(Account.SObjectType).mockId('AccountQuery').toObject();
Test.stopTest();

Assert.areEqual(accountA, account1);
Assert.areEqual(accountB, account2);

If SOQL.mock is invoked multiple times for the same mockId, then each SObject or List<SObject> should be added to the “stack,” from which each SOQL invocation retrieves mocked result.

Is that correct?

[santiagoparradev]

Yes !

[pgajek2]

Hi @santiagoparradev ,

It has been a long time, but I finally started working on the mocking stack.
You can find code in the feature/mock-stack branch.
Let me know if this is something you've expected.

// Setup
SOQL.mock('mockingQuery').thenReturn(new Account(Name = 'Test 1'));
SOQL.mock('mockingQuery').thenReturn(new Account(Name = 'Test 2'));
SOQL.mock('mockingQuery').thenReturn(new Account(Name = 'Test 3'));

// Test
SOQL.Queryable query = SOQL.of(Account.SObjectType).with(Account.Name).mockId('mockingQuery');

Account acc1 = (Account) query.toObject();
Account acc2 = (Account) query.toObject();
Account acc3 = (Account) query.toObject();
Account acc4 = (Account) query.toObject();

// Verify
Assert.areEqual('Test 1', acc1.Name, 'The returned account name should match the expected one.');
Assert.areEqual('Test 2', acc2.Name, 'The returned account name should match the expected one.');
Assert.areEqual('Test 3', acc3.Name, 'The returned account name should match the expected one.');
Assert.areEqual('Test 3', acc4.Name, 'The returned account name should match the expected one.');

[santiagoparradev]

Yes I based myself on jest so something similar to this would be ideal.

Your approach works but maybe the default thing can be useful under certain circumstances.

const fn = jest.fn();

// Permanent
fn.mockReturnValue('always');
console.log(fn()); // 'always'
console.log(fn()); // 'always'

// One-time
fn
.mockReturnValueOnce('first')
.mockReturnValue('default');

console.log(fn()); // 'first'
console.log(fn()); // 'default'

[pgajek2]

@santiagoparradev Hmm. It works in a similar way. Maybe the API isn’t as fluent as the one you showed.

SOQL.mock('mockingQuery').thenReturn(new Account(Name = 'Test 1')); // returned once
SOQL.mock('mockingQuery').thenReturn(new Account(Name = 'Test 2')); // returned once
SOQL.mock('mockingQuery').thenReturn(new Account(Name = 'Test 3')); // returned always - at the end, when the stack is empty

// Test
SOQL.Queryable query = SOQL.of(Account.SObjectType).with(Account.Name).mockId('mockingQuery');

Account acc1 = (Account) query.toObject(); // Test 1
Account acc2 = (Account) query.toObject(); // Test 2
Account acc3 = (Account) query.toObject(); // Test 3
Account acc4 = (Account) query.toObject(); // Test 3
Account acc5 = (Account) query.toObject(); // Test 3
// etc.

I’ll think about it and try to mimic the approach you showed, but this will be part of a future improvement, as it will require more changes to the code.