Skip to content
This repository was archived by the owner on Feb 7, 2024. It is now read-only.

Commit 94fb667

Browse files
gabrieliugampociot
authored andcommitted
Fix for dependency upgrade (#223)
* + DnsResolver no longer extends React/Dns/Resolver as it's now a final class + StartWebSocketServer:getDnsResolver returns ResolverInterface to comply with new react/dns policy * + organize imports * + organize imports
1 parent 639a63b commit 94fb667

File tree

2 files changed

+22
-5
lines changed

2 files changed

+22
-5
lines changed

src/Console/StartWebSocketServer.php

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -6,9 +6,9 @@
66
use Clue\React\Buzz\Browser;
77
use Illuminate\Console\Command;
88
use React\Dns\Config\Config as DnsConfig;
9+
use React\Dns\Resolver\ResolverInterface;
910
use React\EventLoop\Factory as LoopFactory;
1011
use React\Dns\Resolver\Factory as DnsFactory;
11-
use React\Dns\Resolver\Resolver as ReactDnsResolver;
1212
use BeyondCode\LaravelWebSockets\Statistics\DnsResolver;
1313
use BeyondCode\LaravelWebSockets\Facades\StatisticsLogger;
1414
use BeyondCode\LaravelWebSockets\Facades\WebSocketsRouter;
@@ -135,7 +135,7 @@ protected function startWebSocketServer()
135135
->run();
136136
}
137137

138-
protected function getDnsResolver(): ReactDnsResolver
138+
protected function getDnsResolver(): ResolverInterface
139139
{
140140
if (! config('websockets.statistics.perform_dns_lookup')) {
141141
return new DnsResolver;

src/Statistics/DnsResolver.php

Lines changed: 20 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -2,11 +2,13 @@
22

33
namespace BeyondCode\LaravelWebSockets\Statistics;
44

5-
use React\Dns\Resolver\Resolver;
65
use React\Promise\FulfilledPromise;
6+
use React\Dns\Resolver\ResolverInterface;
77

8-
class DnsResolver extends Resolver
8+
class DnsResolver implements ResolverInterface
99
{
10+
private $internalIP = '127.0.0.1';
11+
1012
/*
1113
* This empty constructor is needed so we don't have to setup the parent's dependencies.
1214
*/
@@ -17,6 +19,21 @@ public function __construct()
1719

1820
public function resolve($domain)
1921
{
20-
return new FulfilledPromise('127.0.0.1');
22+
return $this->resolveInternal($domain);
23+
}
24+
25+
public function resolveAll($domain, $type)
26+
{
27+
return $this->resolveInternal($domain, $type);
28+
}
29+
30+
private function resolveInternal($domain, $type = null)
31+
{
32+
return new FulfilledPromise($this->internalIP);
33+
}
34+
35+
public function __toString()
36+
{
37+
return $this->internalIP;
2138
}
2239
}

0 commit comments

Comments
 (0)