Reset app traces if no activity was found since last save

Author: rennokki

src/Contracts/StatisticsCollector.php

@@ -66,4 +66,13 @@ public function getStatistics(): PromiseInterface;
      * @return PromiseInterface[\BeyondCode\LaravelWebSockets\Statistics\Statistic|null]
      */
     public function getAppStatistics($appId): PromiseInterface;
+
+    /**
+     * Remove all app traces from the database if no connections have been set
+     * in the meanwhile since last save.
+     *
+     * @param  string|int  $appId
+     * @return void
+     */
+    public function resetAppTraces($appId);
 }

src/Statistics/Collectors/MemoryCollector.php

@@ -92,6 +92,12 @@ public function save()
                     continue;
                 }
 
+                if ($statistic->shouldHaveTracesRemoved()) {
+                    $this->resetAppTraces($appId);
+
+                    continue;
+                }
+
                 $this->createRecord($statistic, $appId);
 
                 $this->channelManager->getGlobalConnectionsCount($appId)->then(function ($connections) use ($statistic) {
@@ -136,6 +142,18 @@ public function getAppStatistics($appId): PromiseInterface
         );
     }
 
+    /**
+     * Remove all app traces from the database if no connections have been set
+     * in the meanwhile since last save.
+     *
+     * @param  string|int  $appId
+     * @return void
+     */
+    public function resetAppTraces($appId)
+    {
+        unset($this->statistics[$appId]);
+    }
+
     /**
      * Find or create a defined statistic for an app.
      *

src/Statistics/Collectors/RedisCollector.php

@@ -161,6 +161,10 @@ public function save()
                                 $appId, Helpers::redisListToArray($list)
                             );
 
+                            if ($statistic->shouldHaveTracesRemoved()) {
+                                return $this->resetAppTraces($appId);
+                            }
+
                             $this->createRecord($statistic, $appId);
 
                             $this->channelManager
@@ -272,6 +276,8 @@ public function resetStatistics($appId, int $currentConnectionCount)
      */
     public function resetAppTraces($appId)
     {
+        parent::resetAppTraces($appId);
+
         $this->channelManager->getPublishClient()->hdel(
             $this->channelManager->getRedisKey($appId, null, ['stats']),
             'current_connections_count'

src/Statistics/Statistic.php

@@ -183,6 +183,18 @@ public function reset(int $currentConnectionsCount)
         $this->apiMessagesCount = 0;
     }
 
+    /**
+     * Check if the current statistic entry is empty. This means
+     * that the statistic entry can be easily deleted if no activity
+     * occured for a while.
+     *
+     * @return bool
+     */
+    public function shouldHaveTracesRemoved(): bool
+    {
+        return $this->currentConnectionsCount === 0 && $this->peakConnectionsCount === 0;
+    }
+
     /**
      * Transform the statistic to array.
      *