Check for key app on authorization

rennokki · rennokki · commit e0d8f6ac33cc · 2020-12-01T19:43:18.000+02:00
diff --git a/src/Statistics/Http/Middleware/Authorize.php b/src/Statistics/Http/Middleware/Authorize.php
@@ -8,6 +8,10 @@ class Authorize
 {
     public function handle($request, $next)
     {
-        return is_null(App::findBySecret($request->secret)) ? abort(403) : $next($request);
+        $app = App::findByKey($request->key);
+
+        return is_null($app) || $app->secret !== $request->secret
+            ? abort(403)
+            : $next($request);
     }
 }

Original file line number	Diff line number	Diff line change
`@@ -8,6 +8,10 @@ class Authorize`
`8`	`8`	`{`
`9`	`9`	`public function handle($request, $next)`
`10`	`10`	`{`
`11`		`- return is_null(App::findBySecret($request->secret)) ? abort(403) : $next($request);`
	`11`	`+ $app = App::findByKey($request->key);`
	`12`	`+`
	`13`	`+ return is_null($app) \|\| $app->secret !== $request->secret`
	`14`	`+ ? abort(403)`
	`15`	`+ : $next($request);`
`12`	`16`	`}`
`13`	`17`	`}`