Skip to content

Commit 293722d

Browse files
bfabiobfabio
committed
fix: make sure relative paths are checked correctly
logo, monochromeLogo, authorsFile and screenshots are supposed to be either relative paths or HTTP URLs.
1 parent 5773d64 commit 293722d

File tree

4 files changed

+216
-0
lines changed

4 files changed

+216
-0
lines changed

‎testdata/v0/invalid/logo_absolute_path.yml‎

Lines changed: 54 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,54 @@
1+
publiccodeYmlVersion: "0.4"
2+
3+
name: Medusa
4+
url: "https://github.com/italia/developers.italia.it.git"
5+
releaseDate: "2017-04-15"
6+
7+
platforms:
8+
- web
9+
10+
categories:
11+
- cloud-management
12+
13+
developmentStatus: development
14+
15+
softwareType: "standalone/other"
16+
17+
# Should NOT validate: it's an absolute path. logo must be either an HTTP URL or a relative path
18+
logo: "/logo.png"
19+
20+
description:
21+
en:
22+
localisedName: Medusa
23+
shortDescription: >
24+
A rather short description which
25+
is probably useless
26+
longDescription: >
27+
Very long description of this software, also split
28+
on multiple rows. You should note what the software
29+
is and why one should need it. This is 158 characters.
30+
Very long description of this software, also split
31+
on multiple rows. You should note what the software
32+
is and why one should need it. This is 316 characters.
33+
Very long description of this software, also split
34+
on multiple rows. You should note what the software
35+
is and why one should need it. This is 474 characters.
36+
Very long description of this software, also split
37+
on multiple rows. You should note what the software
38+
is and why one should need it. This is 632 characters.
39+
features:
40+
- Just one feature
41+
42+
legal:
43+
license: AGPL-3.0-or-later
44+
45+
maintenance:
46+
type: "community"
47+
48+
contacts:
49+
- name: Francesco Rossi
50+
51+
localisation:
52+
localisationReady: true
53+
availableLanguages:
54+
- en

‎testdata/v0/invalid/logo_file_scheme.yml‎

Lines changed: 54 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,54 @@
1+
publiccodeYmlVersion: "0.4"
2+
3+
name: Medusa
4+
url: "https://github.com/italia/developers.italia.it.git"
5+
releaseDate: "2017-04-15"
6+
7+
platforms:
8+
- web
9+
10+
categories:
11+
- cloud-management
12+
13+
developmentStatus: development
14+
15+
softwareType: "standalone/other"
16+
17+
# Should NOT validate: it has a "file:" scheme. logo must be either an HTTP URL or a relative path
18+
logo: "file:///logo.png"
19+
20+
description:
21+
en:
22+
localisedName: Medusa
23+
shortDescription: >
24+
A rather short description which
25+
is probably useless
26+
longDescription: >
27+
Very long description of this software, also split
28+
on multiple rows. You should note what the software
29+
is and why one should need it. This is 158 characters.
30+
Very long description of this software, also split
31+
on multiple rows. You should note what the software
32+
is and why one should need it. This is 316 characters.
33+
Very long description of this software, also split
34+
on multiple rows. You should note what the software
35+
is and why one should need it. This is 474 characters.
36+
Very long description of this software, also split
37+
on multiple rows. You should note what the software
38+
is and why one should need it. This is 632 characters.
39+
features:
40+
- Just one feature
41+
42+
legal:
43+
license: AGPL-3.0-or-later
44+
45+
maintenance:
46+
type: "community"
47+
48+
contacts:
49+
- name: Francesco Rossi
50+
51+
localisation:
52+
localisationReady: true
53+
availableLanguages:
54+
- en

‎testdata/v0/invalid/logo_file_scheme2.yml‎

Lines changed: 54 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,54 @@
1+
publiccodeYmlVersion: "0.4"
2+
3+
name: Medusa
4+
url: "https://github.com/italia/developers.italia.it.git"
5+
releaseDate: "2017-04-15"
6+
7+
platforms:
8+
- web
9+
10+
categories:
11+
- cloud-management
12+
13+
developmentStatus: development
14+
15+
softwareType: "standalone/other"
16+
17+
# Should NOT validate: it has a (invalid) "file:" scheme. logo must be either an HTTP URL or a relative path
18+
logo: "file://logo.png"
19+
20+
description:
21+
en:
22+
localisedName: Medusa
23+
shortDescription: >
24+
A rather short description which
25+
is probably useless
26+
longDescription: >
27+
Very long description of this software, also split
28+
on multiple rows. You should note what the software
29+
is and why one should need it. This is 158 characters.
30+
Very long description of this software, also split
31+
on multiple rows. You should note what the software
32+
is and why one should need it. This is 316 characters.
33+
Very long description of this software, also split
34+
on multiple rows. You should note what the software
35+
is and why one should need it. This is 474 characters.
36+
Very long description of this software, also split
37+
on multiple rows. You should note what the software
38+
is and why one should need it. This is 632 characters.
39+
features:
40+
- Just one feature
41+
42+
legal:
43+
license: AGPL-3.0-or-later
44+
45+
maintenance:
46+
type: "community"
47+
48+
contacts:
49+
- name: Francesco Rossi
50+
51+
localisation:
52+
localisationReady: true
53+
availableLanguages:
54+
- en

‎testdata/v0/invalid/logo_file_scheme3.yml‎

Lines changed: 54 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,54 @@
1+
publiccodeYmlVersion: "0.4"
2+
3+
name: Medusa
4+
url: "https://github.com/italia/developers.italia.it.git"
5+
releaseDate: "2017-04-15"
6+
7+
platforms:
8+
- web
9+
10+
categories:
11+
- cloud-management
12+
13+
developmentStatus: development
14+
15+
softwareType: "standalone/other"
16+
17+
# Should NOT validate: it has a (invalid) "file:" scheme. logo must be either an HTTP URL or a relative path
18+
logo: "file:/logo.png"
19+
20+
description:
21+
en:
22+
localisedName: Medusa
23+
shortDescription: >
24+
A rather short description which
25+
is probably useless
26+
longDescription: >
27+
Very long description of this software, also split
28+
on multiple rows. You should note what the software
29+
is and why one should need it. This is 158 characters.
30+
Very long description of this software, also split
31+
on multiple rows. You should note what the software
32+
is and why one should need it. This is 316 characters.
33+
Very long description of this software, also split
34+
on multiple rows. You should note what the software
35+
is and why one should need it. This is 474 characters.
36+
Very long description of this software, also split
37+
on multiple rows. You should note what the software
38+
is and why one should need it. This is 632 characters.
39+
features:
40+
- Just one feature
41+
42+
legal:
43+
license: AGPL-3.0-or-later
44+
45+
maintenance:
46+
type: "community"
47+
48+
contacts:
49+
- name: Francesco Rossi
50+
51+
localisation:
52+
localisationReady: true
53+
availableLanguages:
54+
- en

0 commit comments

Comments
 (0)