fix: properly validate isBasedOn

isBasedOn must be a URL:
https://yml.publiccode.tools/schema.core.html?highlight=isbasedon#key-isbasedon

Author: bfabio

parser_test.go

@@ -201,10 +201,10 @@ func TestInvalidTestcasesV0(t *testing.T) {
 			ValidationError{"isBasedOn.foobar", "wrong type for this field", 10, 1},
 		},
 		"isBasedOn_bad_url_array.yml": ValidationResults{
-			ValidationError{"isBasedOn", "wrong type for this field", 8, 1},
+			ValidationError{"isBasedOn[1]", "isBasedOn[1] must be a valid URL", 1, 1},
 		},
 		"isBasedOn_bad_url_string.yml": ValidationResults{
-			ValidationError{"isBasedOn", "'???' not reachable: missing URL scheme", 8, 1},
+			ValidationError{"isBasedOn[0]", "isBasedOn[0] must be a valid URL", 1, 1},
 		},
 
 		// softwareVersion

testdata/v0/invalid/isBasedOn_bad_url_array.yml

@@ -0,0 +1,57 @@
+publiccodeYmlVersion: "0.4"
+
+name: Medusa
+url: "https://github.com/italia/developers.italia.it.git"
+softwareVersion: "dev"
+releaseDate: "2017-04-15"
+
+isBasedOn:
+  - https://github.com/italia/developers.git
+  # Should NOT validate: must a URL
+  - string
+
+platforms:
+  - web
+
+categories:
+  - cloud-management
+
+developmentStatus: development
+
+softwareType: "standalone/other"
+
+description:
+  en:
+    localisedName: Medusa
+    shortDescription: >
+          A rather short description which
+          is probably useless
+    longDescription: >
+          Very long description of this software, also split
+          on multiple rows. You should note what the software
+          is and why one should need it. This is 158 characters.
+          Very long description of this software, also split
+          on multiple rows. You should note what the software
+          is and why one should need it. This is 316 characters.
+          Very long description of this software, also split
+          on multiple rows. You should note what the software
+          is and why one should need it. This is 474 characters.
+          Very long description of this software, also split
+          on multiple rows. You should note what the software
+          is and why one should need it. This is 632 characters.
+    features:
+       - Just one feature
+
+legal:
+  license: AGPL-3.0-or-later
+
+maintenance:
+  type: "community"
+
+  contacts:
+    - name: Francesco Rossi
+
+localisation:
+  localisationReady: true
+  availableLanguages:
+    - en

testdata/v0/invalid/isBasedOn_bad_url_string.yml

@@ -0,0 +1,55 @@
+publiccodeYmlVersion: "0.4"
+
+name: Medusa
+url: "https://github.com/italia/developers.italia.it.git"
+softwareVersion: "dev"
+releaseDate: "2017-04-15"
+
+# Should NOT validate: must a URL
+isBasedOn: foobar
+
+platforms:
+  - web
+
+categories:
+  - cloud-management
+
+developmentStatus: development
+
+softwareType: "standalone/other"
+
+description:
+  en:
+    localisedName: Medusa
+    shortDescription: >
+          A rather short description which
+          is probably useless
+    longDescription: >
+          Very long description of this software, also split
+          on multiple rows. You should note what the software
+          is and why one should need it. This is 158 characters.
+          Very long description of this software, also split
+          on multiple rows. You should note what the software
+          is and why one should need it. This is 316 characters.
+          Very long description of this software, also split
+          on multiple rows. You should note what the software
+          is and why one should need it. This is 474 characters.
+          Very long description of this software, also split
+          on multiple rows. You should note what the software
+          is and why one should need it. This is 632 characters.
+    features:
+       - Just one feature
+
+legal:
+  license: AGPL-3.0-or-later
+
+maintenance:
+  type: "community"
+
+  contacts:
+    - name: Francesco Rossi
+
+localisation:
+  localisationReady: true
+  availableLanguages:
+    - en

v0.go

@@ -14,9 +14,9 @@ type PublicCodeV0 struct {
 	URL              *URL   `validate:"required,url_url"       yaml:"url"`
 	LandingURL       *URL   `validate:"omitnil,url_http_url"   yaml:"landingURL,omitempty"`
 
-	IsBasedOn       UrlOrUrlArray `yaml:"isBasedOn,omitempty"`
+	IsBasedOn       UrlOrUrlArray `validate:"omitempty,dive,url_url" yaml:"isBasedOn,omitempty"`
 	SoftwareVersion string        `yaml:"softwareVersion,omitempty"`
-	ReleaseDate     *string       `validate:"omitnil,date"          yaml:"releaseDate"`
+	ReleaseDate     *string       `validate:"omitnil,date"           yaml:"releaseDate"`
 	Logo            string        `yaml:"logo,omitempty"`
 	MonochromeLogo  string        `yaml:"monochromeLogo,omitempty"`