chore: add forbidgo linter (italia#244)

Author: bfabio

.golangci.yaml

@@ -37,7 +37,6 @@ linters:
     - err113
     - errname
     - errorlint
-    - forbidigo
     - forcetypeassert
     - funlen
     - gochecknoglobals
@@ -90,6 +89,10 @@ linters:
       os-setenv: true
       os-create-temp: true
       os-temp-dir: false
+    forbidigo:
+      forbid:
+        - pattern: ^(fmt\.Print(|f|ln)|print|println)$
+        - pattern: ^panic$
 
   exclusions:
     generated: lax
@@ -102,6 +105,12 @@ linters:
       - third_party$
       - builtin$
       - examples$
+    rules:
+      # Allow prints and panics in publiccode-parser/, as it's the
+      # CLI tool.
+      - path: publiccode-parser/
+        linters:
+          - forbidigo
 
 formatters:
   enable:

validators/common.go

@@ -51,6 +51,7 @@ func isHTTPURL(fl validator.FieldLevel) bool {
 		return err == nil
 	}
 
+	//nolint:forbidigo // If we hit this, it's a programming error caught at runtime, it's good to panic.
 	panic(fmt.Sprintf("Bad field type for %T. Must be implement fmt.Stringer", fl.Field().Interface()))
 }
 
@@ -65,6 +66,7 @@ func isURL(fl validator.FieldLevel) bool {
 		return err == nil
 	}
 
+	//nolint:forbidigo // If we hit this, it's a programming error caught at runtime, it's good to panic.
 	panic(fmt.Sprintf("Bad field type for %T. Must be implement fmt.Stringer", fl.Field().Interface()))
 }
 
@@ -73,6 +75,7 @@ func bcp47_keys(fl validator.FieldLevel) bool {
 	validate := validator.New(validator.WithRequiredStructEnabled())
 
 	if fl.Field().Kind() != reflect.Map {
+		//nolint:forbidigo // If we hit this, it's a programming error caught at runtime, it's good to panic.
 		panic(fmt.Sprintf("Bad field type for %T. Must be a map", fl.Field().Interface()))
 	}