Fix validateSelector method stopped working if a selector could not be validated

Author: bfiessinger

changelog.MD

@@ -1,5 +1,10 @@
 # Changelog
 
+### 3.0.1 (Hotfix release)
+
+#### Bug Fixes
+- ScrollToSmooth stopped working in version 3.0.0 when the selector to be validated would fail
+
 ### 3.0.0
 
 #### Features

dist/scrolltosmooth.cjs.js

@@ -603,10 +603,16 @@ var forEach = function forEach(arr, callback) {
 
 var validateSelector = function validateSelector(selector) {
   var container = arguments.length > 1 && arguments[1] !== undefined ? arguments[1] : d;
-  var valid = false; // Check if the target is a valid selector inside the scrollToSmooth container
+  var valid = true; // Check if the target is a valid selector inside the scrollToSmooth container
 
-  if (typeof selector == 'string' && _$(selector, container) || isNodeOrElement(selector) && container.contains(selector)) {
-    valid = true;
+  try {
+    if (typeof selector === 'string') {
+      _$(selector, container);
+    } else if (isNodeOrElement(selector) && container.contains(selector)) {
+      selector;
+    }
+  } catch (e) {
+    valid = false;
   }
 
   return valid;
@@ -747,6 +753,7 @@ function getTargetElement(el) {
     return this.container;
   }
 
+  console.log(targetSelector, validateSelector(targetSelector, this.container));
   return validateSelector(targetSelector, this.container) ? _$(targetSelector, this.container) : null;
 }
 /**

dist/scrolltosmooth.esm.js

@@ -599,10 +599,16 @@ var forEach = function forEach(arr, callback) {
 
 var validateSelector = function validateSelector(selector) {
   var container = arguments.length > 1 && arguments[1] !== undefined ? arguments[1] : d;
-  var valid = false; // Check if the target is a valid selector inside the scrollToSmooth container
+  var valid = true; // Check if the target is a valid selector inside the scrollToSmooth container
 
-  if (typeof selector == 'string' && _$(selector, container) || isNodeOrElement(selector) && container.contains(selector)) {
-    valid = true;
+  try {
+    if (typeof selector === 'string') {
+      _$(selector, container);
+    } else if (isNodeOrElement(selector) && container.contains(selector)) {
+      selector;
+    }
+  } catch (e) {
+    valid = false;
   }
 
   return valid;
@@ -743,6 +749,7 @@ function getTargetElement(el) {
     return this.container;
   }
 
+  console.log(targetSelector, validateSelector(targetSelector, this.container));
   return validateSelector(targetSelector, this.container) ? _$(targetSelector, this.container) : null;
 }
 /**