Auto-approve menu stylistic fixes (RooCodeInc#3504)

* marginal improvements

* undo forbidding enable all favorite

* changeset

Author: frostbournesb

.changeset/bright-grapes-suffer.md

@@ -0,0 +1,5 @@
+---
+"claude-dev": patch
+---
+
+Fix minor visual issues with auto-approve menu

webview-ui/src/components/chat/auto-approve-menu/AutoApproveMenu.tsx

@@ -336,7 +336,7 @@ const AutoApproveMenu = ({ style }: AutoApproveMenuProps) => {
 		<div
 			ref={menuRef}
 			style={{
-				padding: "0 10px",
+				padding: "0 4px 0 10px",
 				margin: "0 5px",
 				userSelect: "none",
 				borderTop: `0.5px solid color-mix(in srgb, ${getAsVar(VSC_TITLEBAR_INACTIVE_FOREGROUND)} 20%, transparent)`,
@@ -352,6 +352,7 @@ const AutoApproveMenu = ({ style }: AutoApproveMenuProps) => {
 					style={{
 						cursor: "pointer",
 						paddingTop: "6px",
+						paddingRight: "2px",
 						display: "flex",
 						alignItems: "center",
 						justifyContent: "space-between",
@@ -369,6 +370,7 @@ const AutoApproveMenu = ({ style }: AutoApproveMenuProps) => {
 							gap: "4px",
 							whiteSpace: "nowrap", // Prevent text wrapping
 						}}>
+						<span>Auto-approve:</span>
 						{getQuickAccessItems()}
 					</div>
 					<span className="codicon codicon-chevron-right" />
@@ -393,25 +395,25 @@ const AutoApproveMenu = ({ style }: AutoApproveMenuProps) => {
 								display: "flex",
 								justifyContent: "space-between",
 								alignItems: "center",
-								padding: "8px 0",
+								padding: "8px 4px 8px 0",
 								cursor: "pointer",
 								position: "relative", // Added for positioning context
 							}}
 							onClick={() => setIsExpanded(false)}>
 							<HeroTooltip
 								content="Auto-approve allows Cline to perform the following actions without asking for permission. Please use with caution and only enable if you understand the risks."
 								placement="top">
-								<span style={{ color: getAsVar(VSC_FOREGROUND) }}>Auto-approve</span>
+								<span style={{ color: getAsVar(VSC_FOREGROUND), fontWeight: 500 }}>Auto-approve:</span>
 							</HeroTooltip>
-							<span className="codicon codicon-chevron-down" style={{ paddingRight: "4px" }} />
+							<span className="codicon codicon-chevron-down" />
 						</div>
 
 						<div
 							ref={itemsContainerRef}
 							style={{
 								columnCount: containerWidth > breakpoint ? 2 : 1,
 								columnGap: "4px",
-								margin: "4px 0 8px 0",
+								margin: "4px 0 16px 0",
 								position: "relative", // For absolute positioning of the separator
 							}}>
 							{/* Vertical separator line - only visible in two-column mode */}
@@ -442,14 +444,7 @@ const AutoApproveMenu = ({ style }: AutoApproveMenuProps) => {
 								/>
 							))}
 						</div>
-						<div
-							style={{
-								height: "0.5px",
-								background: getAsVar(VSC_TITLEBAR_INACTIVE_FOREGROUND),
-								margin: "8px 0",
-								opacity: 0.2,
-							}}
-						/>
+						<span style={{ color: getAsVar(VSC_FOREGROUND), marginBottom: 4, fontWeight: 500 }}>Quick Settings:</span>
 						<AutoApproveMenuItem
 							key={NOTIFICATIONS_SETTING.id}
 							action={NOTIFICATIONS_SETTING}
@@ -463,7 +458,7 @@ const AutoApproveMenu = ({ style }: AutoApproveMenuProps) => {
 							placement="top">
 							<div
 								style={{
-									margin: "2px 10px 10px 5px",
+									margin: "2px 10px 20px 5px",
 									display: "flex",
 									alignItems: "center",
 									gap: "8px",
@@ -500,7 +495,13 @@ const AutoApproveMenu = ({ style }: AutoApproveMenuProps) => {
 				{isExpanded && (
 					<span
 						className="codicon codicon-chevron-up"
-						style={{ paddingBottom: "4px", marginLeft: "auto", marginTop: "-20px", cursor: "pointer" }}
+						style={{
+							paddingBottom: "4px",
+							paddingRight: "3px",
+							marginLeft: "auto",
+							marginTop: "-20px",
+							cursor: "pointer",
+						}}
 						onClick={() => setIsExpanded(false)}
 					/>
 				)}

webview-ui/src/components/chat/auto-approve-menu/AutoApproveMenuItem.tsx

@@ -22,7 +22,8 @@ const CheckboxContainer = styled.div<{
 	display: flex;
 	align-items: center;
 	justify-content: space-between; /* Push content to edges */
-	padding: 0 4px;
+	padding-left: 4px;
+	padding-right: 1px;
 	border-radius: 4px;
 	cursor: pointer;
 	transition: all 0.2s ease;
@@ -51,7 +52,7 @@ const CheckboxContainer = styled.div<{
 	.star {
 		color: ${(props) => (props.isFavorited ? "var(--vscode-terminal-ansiYellow)" : "var(--vscode-descriptionForeground)")};
 		opacity: ${(props) => (props.isFavorited ? 1 : 0.6)};
-		font-size: 12px;
+		font-size: 14px;
 	}
 `
 
@@ -99,21 +100,14 @@ const AutoApproveMenuItem = ({
 						{onToggleFavorite && !condensed && (
 							<HeroTooltip
 								delay={500}
-								content={
-									action.id === "enableAll"
-										? "Required"
-										: favorited
-											? "Remove from quick-access menu"
-											: "Add to quick-access menu"
-								}>
+								content={favorited ? "Remove from quick-access menu" : "Add to quick-access menu"}>
 								<span
-									className={`codicon codicon-${favorited ? "star-full" : "star-empty"} star`}
+									className={`p-0.5 codicon codicon-${favorited ? "star-full" : "star-empty"} star`}
 									style={{
-										cursor: action.id === "enableAll" ? "not-allowed" : "pointer",
+										cursor: "pointer",
 									}}
 									onClick={(e) => {
 										e.stopPropagation()
-										if (action.id === "enableAll") return
 										onToggleFavorite?.(action.id)
 									}}
 								/>