[PROTOBUS] Move requestVsCodeLmModels to protobus (RooCodeInc#3344)

* Task Favorites

* getOllamaModels protobus migration

* VsCodeLmModels protobus migration

* cleanup

Author: canvrno

.changeset/old-jeans-applaud.md

@@ -0,0 +1,5 @@
+---
+"claude-dev": patch
+---
+
+requestVsCodeLmModels protobus migration

proto/models.proto

@@ -10,7 +10,21 @@ import "common.proto";
 service ModelsService {
   // Fetches available models from Ollama
   rpc getOllamaModels(StringRequest) returns (StringArray);
-  
   // Fetches available models from LM Studio
   rpc getLmStudioModels(StringRequest) returns (StringArray);
+  // Fetches available models from VS Code LM API
+  rpc getVsCodeLmModels(EmptyRequest) returns (VsCodeLmModelsArray);
+}
+
+// List of VS Code LM models
+message VsCodeLmModelsArray {
+  repeated VsCodeLmModel models = 1;
+}
+
+// Structure representing a VS Code LM model
+message VsCodeLmModel {
+  string vendor = 1;
+  string family = 2;
+  string version = 3;
+  string id = 4;
 }

proto/task.proto

@@ -27,4 +27,3 @@ message NewTaskRequest {
   string text = 2;
   repeated string images = 3;
 }
-

src/core/controller/index.ts

@@ -19,7 +19,6 @@ import WorkspaceTracker from "@integrations/workspace/WorkspaceTracker"
 import { ClineAccountService } from "@services/account/ClineAccountService"
 import { BrowserSession } from "@services/browser/BrowserSession"
 import { McpHub } from "@services/mcp/McpHub"
-import { searchWorkspaceFiles } from "@services/search/file-search"
 import { telemetryService } from "@/services/posthog/telemetry/TelemetryService"
 import { ApiProvider, ModelInfo } from "@shared/api"
 import { ChatContent } from "@shared/ChatContent"
@@ -28,11 +27,10 @@ import { ExtensionMessage, ExtensionState, Invoke, Platform } from "@shared/Exte
 import { HistoryItem } from "@shared/HistoryItem"
 import { McpDownloadResponse, McpMarketplaceCatalog, McpServer } from "@shared/mcp"
 import { TelemetrySetting } from "@shared/TelemetrySetting"
-import { ClineCheckpointRestore, WebviewMessage } from "@shared/WebviewMessage"
+import { WebviewMessage } from "@shared/WebviewMessage"
 import { fileExistsAtPath } from "@utils/fs"
-import { searchCommits, getWorkingState } from "@utils/git"
+import { getWorkingState } from "@utils/git"
 import { extractCommitMessage } from "@integrations/git/commit-message-generator"
-import { getWorkspacePath } from "@utils/path"
 import { getTotalTasksSize } from "@utils/storage"
 import { openMention } from "../mentions"
 import { ensureMcpServersDirectoryExists, ensureSettingsDirectoryExists, GlobalFileNames } from "../storage/disk"
@@ -332,10 +330,6 @@ export class Controller {
 			case "resetState":
 				await this.resetState()
 				break
-			case "requestVsCodeLmModels":
-				const vsCodeLmModels = await this.getVsCodeLmModels()
-				this.postMessageToWebview({ type: "vsCodeLmModels", vsCodeLmModels })
-				break
 			case "refreshOpenRouterModels":
 				await this.refreshOpenRouterModels()
 				break
@@ -884,18 +878,6 @@ export class Controller {
 		}
 	}
 
-	// VSCode LM API
-
-	private async getVsCodeLmModels() {
-		try {
-			const models = await vscode.lm.selectChatModels({})
-			return models || []
-		} catch (error) {
-			console.error("Error fetching VS Code LM models:", error)
-			return []
-		}
-	}
-
 	// Account
 
 	async fetchUserCreditsData() {

src/core/controller/models/getVsCodeLmModels.ts

@@ -0,0 +1,24 @@
+import { Controller } from ".."
+import { EmptyRequest } from "../../../shared/proto/common"
+import { VsCodeLmModelsArray } from "../../../shared/proto/models"
+import * as vscode from "vscode"
+import { convertVsCodeNativeModelsToProtoModels } from "../../../shared/proto-conversions/models/vscode-lm-models-conversion"
+
+/**
+ * Fetches available models from VS Code LM API
+ * @param controller The controller instance
+ * @param request Empty request
+ * @returns Array of VS Code LM models
+ */
+export async function getVsCodeLmModels(controller: Controller, request: EmptyRequest): Promise<VsCodeLmModelsArray> {
+	try {
+		const models = await vscode.lm.selectChatModels({})
+
+		const protoModels = convertVsCodeNativeModelsToProtoModels(models || [])
+
+		return VsCodeLmModelsArray.create({ models: protoModels })
+	} catch (error) {
+		console.error("Error fetching VS Code LM models:", error)
+		return VsCodeLmModelsArray.create({ models: [] })
+	}
+}

src/core/controller/models/methods.ts

@@ -5,10 +5,12 @@
 import { registerMethod } from "./index"
 import { getLmStudioModels } from "./getLmStudioModels"
 import { getOllamaModels } from "./getOllamaModels"
+import { getVsCodeLmModels } from "./getVsCodeLmModels"
 
 // Register all models service methods
 export function registerAllMethods(): void {
 	// Register each method with the registry
 	registerMethod("getLmStudioModels", getLmStudioModels)
 	registerMethod("getOllamaModels", getOllamaModels)
+	registerMethod("getVsCodeLmModels", getVsCodeLmModels)
 }

src/shared/ExtensionMessage.ts

@@ -28,8 +28,6 @@ export interface ExtensionMessage {
 		| "requestyModels"
 		| "mcpServers"
 		| "relinquishControl"
-		| "vsCodeLmModels"
-		| "requestVsCodeLmModels"
 		| "authCallback"
 		| "mcpMarketplaceCatalog"
 		| "mcpDownloadDetails"

src/shared/proto-conversions/models/vscode-lm-models-conversion.ts

@@ -0,0 +1,23 @@
+import { VsCodeLmModel } from "../../proto/models"
+
+/**
+ * Represents a VS Code language model in the native VS Code format
+ */
+export interface VsCodeNativeModel {
+	vendor?: string
+	family?: string
+	version?: string
+	id?: string
+}
+
+/**
+ * Converts VS Code native model format to protobuf format
+ */
+export function convertVsCodeNativeModelsToProtoModels(models: VsCodeNativeModel[]): VsCodeLmModel[] {
+	return (models || []).map((model) => ({
+		vendor: model.vendor || "",
+		family: model.family || "",
+		version: model.version || "",
+		id: model.id || "",
+	}))
+}