getLmStudioModels protobus migration (RooCodeInc#3341)

Author: canvrno

.changeset/serious-cameras-pretend.md

@@ -0,0 +1,5 @@
+---
+"claude-dev": patch
+---
+
+getLmStudioModels protobus migration

proto/models.proto

@@ -10,4 +10,7 @@ import "common.proto";
 service ModelsService {
   // Fetches available models from Ollama
   rpc getOllamaModels(StringRequest) returns (StringArray);
+  
+  // Fetches available models from LM Studio
+  rpc getLmStudioModels(StringRequest) returns (StringArray);
 }

src/core/controller/index.ts

@@ -335,13 +335,6 @@ export class Controller {
 			case "resetState":
 				await this.resetState()
 				break
-			case "requestLmStudioModels":
-				const lmStudioModels = await this.getLmStudioModels(message.text)
-				this.postMessageToWebview({
-					type: "lmStudioModels",
-					lmStudioModels,
-				})
-				break
 			case "requestVsCodeLmModels":
 				const vsCodeLmModels = await this.getVsCodeLmModels()
 				this.postMessageToWebview({ type: "vsCodeLmModels", vsCodeLmModels })
@@ -906,25 +899,6 @@ export class Controller {
 		}
 	}
 
-	// LM Studio
-
-	async getLmStudioModels(baseUrl?: string) {
-		try {
-			if (!baseUrl) {
-				baseUrl = "http://localhost:1234"
-			}
-			if (!URL.canParse(baseUrl)) {
-				return []
-			}
-			const response = await axios.get(`${baseUrl}/v1/models`)
-			const modelsArray = response.data?.data?.map((model: any) => model.id) || []
-			const models = [...new Set<string>(modelsArray)]
-			return models
-		} catch (error) {
-			return []
-		}
-	}
-
 	// Account
 
 	async fetchUserCreditsData() {

src/core/controller/models/getLmStudioModels.ts

@@ -0,0 +1,27 @@
+import { Controller } from ".."
+import { StringArray, StringRequest } from "../../../shared/proto/common"
+import axios from "axios"
+
+/**
+ * Fetches available models from LM Studio
+ * @param controller The controller instance
+ * @param request The request containing the base URL (optional)
+ * @returns Array of model names
+ */
+export async function getLmStudioModels(controller: Controller, request: StringRequest): Promise<StringArray> {
+	try {
+		let baseUrl = request.value || "http://localhost:1234"
+
+		if (!URL.canParse(baseUrl)) {
+			return StringArray.create({ values: [] })
+		}
+
+		const response = await axios.get(`${baseUrl}/v1/models`)
+		const modelsArray = response.data?.data?.map((model: any) => model.id) || []
+		const models = [...new Set<string>(modelsArray)]
+
+		return StringArray.create({ values: models })
+	} catch (error) {
+		return StringArray.create({ values: [] })
+	}
+}

src/core/controller/models/methods.ts

@@ -3,10 +3,12 @@
 
 // Import all method implementations
 import { registerMethod } from "./index"
+import { getLmStudioModels } from "./getLmStudioModels"
 import { getOllamaModels } from "./getOllamaModels"
 
 // Register all models service methods
 export function registerAllMethods(): void {
 	// Register each method with the registry
+	registerMethod("getLmStudioModels", getLmStudioModels)
 	registerMethod("getOllamaModels", getOllamaModels)
 }

src/shared/WebviewMessage.ts

@@ -18,7 +18,6 @@ export interface WebviewMessage {
 		| "selectImages"
 		| "showTaskWithId"
 		| "resetState"
-		| "requestLmStudioModels"
 		| "openInBrowser"
 		| "openMention"
 		| "showChatView"

src/shared/proto/models.ts

@@ -197,10 +197,17 @@ const ApiOptions = ({
 				setOllamaModels([])
 			}
 		} else if (selectedProvider === "lmstudio") {
-			vscode.postMessage({
-				type: "requestLmStudioModels",
-				text: apiConfiguration?.lmStudioBaseUrl,
-			})
+			try {
+				const response = await ModelsServiceClient.getLmStudioModels({
+					value: apiConfiguration?.lmStudioBaseUrl || "",
+				})
+				if (response && response.values) {
+					setLmStudioModels(response.values)
+				}
+			} catch (error) {
+				console.error("Failed to fetch LM Studio models:", error)
+				setLmStudioModels([])
+			}
 		} else if (selectedProvider === "vscode-lm") {
 			vscode.postMessage({ type: "requestVsCodeLmModels" })
 		}
@@ -217,9 +224,7 @@ const ApiOptions = ({
 
 	const handleMessage = useCallback((event: MessageEvent) => {
 		const message: ExtensionMessage = event.data
-		if (message.type === "lmStudioModels" && message.lmStudioModels) {
-			setLmStudioModels(message.lmStudioModels)
-		} else if (message.type === "vsCodeLmModels" && message.vsCodeLmModels) {
+		if (message.type === "vsCodeLmModels" && message.vsCodeLmModels) {
 			setVsCodeLmModels(message.vsCodeLmModels)
 		}
 	}, [])