Fix db-refresh lock issue, add --no-refresh flag, improve logging

Bug Fixes:
- Fixed 'database is locked' error in 'monocle config db-refresh' (Issue
  #90) by removing redundant database connections in do_refresh function

New Features:
- Added global --no-refresh flag to disable automatic data refresh
- Added [monocle] prefix to all auto-refresh log messages for better
  visibility
- RPKI ASPA command now ensures ASInfo data is available for AS name
  enrichment

Improvements:
- Added comprehensive tests for database initialization with mock data

Author: digizeph

CHANGELOG.md

@@ -2,6 +2,36 @@
 
 All notable changes to this project will be documented in this file.
 
+## Unreleased
+
+### Bug Fixes
+
+* Fixed "database is locked" error in `monocle config db-refresh` command (Issue #90)
+  * The `do_refresh` function was opening redundant database connections for ASInfo and AS2Rel data sources
+  * Now correctly uses the already-passed database connection parameter
+
+### New Features
+
+* Added global `--no-refresh` flag to disable automatic data refresh
+  * Use `monocle --no-refresh <command>` to skip all automatic data loading/refresh
+  * Useful when you want to use existing cached data only
+  * Shows warnings when data is missing or stale instead of auto-refreshing
+
+* Added `[monocle]` prefix to all auto-refresh log messages
+  * Makes it easier to distinguish monocle's internal logging from main output
+  * Especially useful when refresh operations run automatically during commands
+
+* RPKI ASPA command now ensures ASInfo data is available for AS name enrichment
+  * Automatically loads ASInfo data before showing ASPA output
+  * AS names and countries are displayed in ASPA results
+
+### Improvements
+
+* Added comprehensive tests for database initialization with mock data
+  * Tests for all repositories being accessible after initialization
+  * Tests for schema version verification
+  * Tests for RPKI and Pfx2as mock data storage/retrieval
+
 ## v1.0.1 - 2025-12-18
 
 ### Bug Fixes

Cargo.lock

@@ -116,7 +116,6 @@ lens-bgpkit = [
     "dep:itertools",
     "dep:radar-rs",
     "dep:rayon",
-    "dep:ureq",
 ]
 
 # Full lens layer - all lenses including InspectLens
@@ -170,7 +169,7 @@ tracing = "0.1"
 # Database dependencies (optional but commonly needed)
 # =============================================================================
 ipnet = { version = "2.10", features = ["json"], optional = true }
-oneio = { version = "0.20.0", default-features = false, features = ["https", "gz", "bz", "json"], optional = true }
+oneio = { version = "0.20.1", default-features = false, features = ["https", "gz", "bz", "json"], optional = true }
 
 # =============================================================================
 # Lens-core dependencies (optional)
@@ -188,7 +187,6 @@ bgpkit-commons = { version = "0.10.1", features = ["asinfo", "rpki", "countries"
 itertools = { version = "0.14", optional = true }
 radar-rs = { version = "0.1.0", optional = true }
 rayon = { version = "1.8", optional = true }
-ureq = { version = "3.1", features = ["json"], optional = true }
 
 # =============================================================================
 # Display dependencies (optional)

Cargo.toml

@@ -40,7 +40,12 @@ pub struct As2relArgs {
     pub show_full_name: bool,
 }
 
-pub fn run(config: &MonocleConfig, args: As2relArgs, output_format: OutputFormat) {
+pub fn run(
+    config: &MonocleConfig,
+    args: As2relArgs,
+    output_format: OutputFormat,
+    no_refresh: bool,
+) {
     let As2relArgs {
         asns,
         update,
@@ -64,43 +69,50 @@ pub fn run(config: &MonocleConfig, args: As2relArgs, output_format: OutputFormat
 
     // Handle explicit updates
     if update || update_with.is_some() {
-        eprintln!("Updating AS2rel data...");
+        if no_refresh {
+            eprintln!("[monocle] Warning: --update ignored because --no-refresh is set");
+        } else {
+            eprintln!("[monocle] Updating AS2rel data...");
 
-        let db = match MonocleDatabase::open(&sqlite_path) {
-            Ok(db) => db,
-            Err(e) => {
-                eprintln!("Failed to open database: {}", e);
-                std::process::exit(1);
+            let db = match MonocleDatabase::open(&sqlite_path) {
+                Ok(db) => db,
+                Err(e) => {
+                    eprintln!("Failed to open database: {}", e);
+                    std::process::exit(1);
+                }
+            };
+
+            let lens = As2relLens::new(&db);
+            let result = match &update_with {
+                Some(path) => lens.update_from(path),
+                None => lens.update(),
+            };
+
+            match result {
+                Ok(count) => {
+                    eprintln!(
+                        "[monocle] AS2rel data updated: {} relationships loaded",
+                        count
+                    );
+                }
+                Err(e) => {
+                    eprintln!("[monocle] Failed to update AS2rel data: {}", e);
+                    std::process::exit(1);
+                }
             }
-        };
-
-        let lens = As2relLens::new(&db);
-        let result = match &update_with {
-            Some(path) => lens.update_from(path),
-            None => lens.update(),
-        };
 
-        match result {
-            Ok(count) => {
-                eprintln!("AS2rel data updated: {} relationships loaded", count);
-            }
-            Err(e) => {
-                eprintln!("Failed to update AS2rel data: {}", e);
-                std::process::exit(1);
-            }
+            // Continue with query using the same connection
+            run_query(
+                &db,
+                &asns,
+                sort_by_asn,
+                show_name,
+                show_full_name,
+                no_explain,
+                output_format,
+            );
+            return;
         }
-
-        // Continue with query using the same connection
-        run_query(
-            &db,
-            &asns,
-            sort_by_asn,
-            show_name,
-            show_full_name,
-            no_explain,
-            output_format,
-        );
-        return;
     }
 
     // Open the database
@@ -116,15 +128,25 @@ pub fn run(config: &MonocleConfig, args: As2relArgs, output_format: OutputFormat
 
     // Check if data needs to be initialized or updated automatically
     if lens.needs_update() {
-        eprintln!("AS2rel data is empty or outdated, updating now...");
+        if no_refresh {
+            eprintln!(
+                "[monocle] Warning: AS2rel data is empty or outdated. Results may be incomplete."
+            );
+            eprintln!("[monocle]          Run without --no-refresh or use 'monocle config db-refresh --as2rel' to load data.");
+        } else {
+            eprintln!("[monocle] AS2rel data is empty or outdated, updating now...");
 
-        match lens.update() {
-            Ok(count) => {
-                eprintln!("AS2rel data updated: {} relationships loaded", count);
-            }
-            Err(e) => {
-                eprintln!("Failed to update AS2rel data: {}", e);
-                std::process::exit(1);
+            match lens.update() {
+                Ok(count) => {
+                    eprintln!(
+                        "[monocle] AS2rel data updated: {} relationships loaded",
+                        count
+                    );
+                }
+                Err(e) => {
+                    eprintln!("[monocle] Failed to update AS2rel data: {}", e);
+                    std::process::exit(1);
+                }
             }
         }
     }