Skip to content

Commit 2a9bc01

Browse files
authored
Merge pull request #43 from rene-springmann/master
Added Laravel 5.4 compatibility
2 parents 5dac3ce + fb772b5 commit 2a9bc01

File tree

5 files changed

+10
-5
lines changed

5 files changed

+10
-5
lines changed

composer.json

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -11,7 +11,7 @@
1111
],
1212
"require": {
1313
"php": ">=5.3.0",
14-
"laravelcollective/html": "5.*",
14+
"laravelcollective/html": "^5.4",
1515
"illuminate/support": ">=4.2",
1616
"illuminate/validation": ">=4.0",
1717
"illuminate/routing": ">=4.0"

src/Bllim/Laravalid/Converter/JqueryValidation/Message.php

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -16,7 +16,7 @@ public function ip($parsedRule, $attribute, $type)
1616

1717
public function same($parsedRule, $attribute, $type)
1818
{
19-
$message = Lang::get('validation.'.$parsedRule['name'], ['attribute' => $attribute]);
19+
$message = Helper::getValidationMessage($attribute, $parsedRule['name'], ['other' => $parsedRule['parameters'][0]]);
2020

2121
return ['data-msg-equalto' => $message];
2222
}

src/Bllim/Laravalid/FormBuilder.php

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -27,9 +27,9 @@ class FormBuilder extends \Collective\Html\FormBuilder
2727
{
2828
protected $converter;
2929

30-
public function __construct(\Collective\Html\HtmlBuilder $html, \Illuminate\Routing\UrlGenerator $url, $csrfToken, Converter\Base\Converter $converter)
30+
public function __construct(\Collective\Html\HtmlBuilder $html, \Illuminate\Routing\UrlGenerator $url, \Illuminate\View\Factory $view, $csrfToken, Converter\Base\Converter $converter)
3131
{
32-
parent::__construct($html, $url, $csrfToken);
32+
parent::__construct($html, $url, $view, $csrfToken);
3333
$plugin = \Config::get('laravalid.plugin');
3434
$this->converter = $converter;
3535
}

src/Bllim/Laravalid/Helper.php

Lines changed: 5 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -42,6 +42,11 @@ public static function getValidationMessage($attribute, $rule, $data = [], $type
4242
}
4343

4444
$niceName = !\Lang::has('validation.attributes.'.$attribute) ? $attribute : \Lang::get('validation.attributes.'.$attribute);
45+
46+
//reform data so that all fields have nice names
47+
foreach ($data as $key => $fieldName) {
48+
$data[$key] = !\Lang::has('validation.attributes.'.$fieldName) ? $fieldName : \Lang::get('validation.attributes.'.$fieldName);
49+
}
4550

4651
return \Lang::get('validation.'.$path, $data + ['attribute' => $niceName]);
4752
}

src/Bllim/Laravalid/LaravalidServiceProvider.php

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -54,7 +54,7 @@ public function register()
5454
$converterClassName = 'Bllim\Laravalid\Converter\\'.$plugin.'\Converter';
5555
$converter = new $converterClassName();
5656

57-
$form = new FormBuilder($app->make('html'), $app->make('url'), $app->make('session.store')->getToken(), $converter);
57+
$form = new FormBuilder($app->make('html'), $app->make('url'), $app->make('view'), $app->make('session.store')->token(), $converter);
5858

5959
return $form->setSessionStore($app->make('session.store'));
6060
}

0 commit comments

Comments
 (0)