Refactor UPI QR code generation logic and update version to 1.3.19

Author: bhar4t

dist/index.js

@@ -1,6 +1,6 @@
 {
   "name": "upiqr",
-  "version": "1.3.18",
+  "version": "1.3.19",
   "description": "Generate NPCI's UPI QR code along with UPI intent link, By using it any payment is possible from UPI enabled apps.",
   "main": "dist/index.js",
   "types": "dist/index.d.ts",
@@ -12,7 +12,7 @@
     "package.json"
   ],
   "scripts": {
-    "minify": "jsmin -o dist/index.d.ts dist/index.d.ts && jsmin -o dist/index.js dist/index.js && jsmin -o dist/types/upiqr.d.ts dist/types/upiqr.d.ts",
+    "minify": "jsmin -o dist/types/upiqr.d.ts dist/types/upiqr.d.ts && jsmin -o dist/index.d.ts dist/index.d.ts && uglifyjs -o dist/index.js dist/index.js --mangle",
     "build": "tsc && npm run minify"
   },
   "repository": {
@@ -45,7 +45,6 @@
   "devDependencies": {
     "@types/node": "^20.5.6",
     "@types/qrcode": "^1.5.1",
-    "jsmin": "^1.0.1",
     "typescript": "^5.2.2"
   }
 }

package.json

@@ -12,20 +12,6 @@ function validate({ pa, pn }: { pa: string, pn: string }): string {
     return ''
 }
 
-/**
- * Builds the UPI intent URL from the given parameters.
- * @param {Object} params - The parameters object containing UPI intent fields.
- * @returns {string} - The constructed UPI intent URL.
- */
-function buildUrl(params: object): string {
-    let qs = ""
-    for (let [key, value] of Object.entries(params)) {
-        if (value)
-            qs += `${encodeURIComponent(key)}=${encodeURIComponent(value)}&`
-    }
-    return "upi://pay?" + qs.slice(0, -1) // Remove trailing '&'
-}
-
 /**
  * Generates a UPI QR code and intent URL.
  * @param {UPIIntentParams} params - The UPI intent parameters.
@@ -45,11 +31,18 @@ export default function upiqr ({
 }: UPIIntentParams, qrOptions?: QRCode.QRCodeToDataURLOptions): Promise<QRResult> {
     const params = { pa, pn, am, mam, cu, mc, tid, tr, tn }
     const error = validate(params)
-
     if (error) return Promise.reject(new Error(error))
-
-    const intent = buildUrl(params)
-
+    
+    // IIFE: builds and returns the UPI intent URL by given params.
+    const intent = ((params: object): string => {
+        const urlParams = new URLSearchParams()
+        for (const [key, value] of Object.entries(params)) {
+            if (value)
+                urlParams.append(key, value as string)
+        }
+        return `upi://pay?${urlParams.toString()}`
+    })(params);
+    
     return new Promise((resolve, reject) => {
         QRCode
             .toDataURL(intent, qrOptions)