Fix empty string deserialization (#1)

Author: gryumov

Project.toml

@@ -1,6 +1,6 @@
 name = "OhMyCH"
 uuid = "27ae6650-29b9-4c69-9010-441cd8c8f06e"
-version = "0.1.0"
+version = "0.1.1"
 
 [deps]
 Dates = "ade2ca70-3891-5945-98fb-dc099432e06a"

src/serialization.jl

@@ -42,22 +42,20 @@ end
 @inline function read_leb128(s::Serializer)
     value = 0
     shift = 0
-    while !eof(s)
+    while true
+        if eof(s)
+            error("Unexpected end of file while reading LEB128 number.")
+        end
         byte = read(s, UInt8)
         value |= (UInt64(byte & 0x7f) << shift)
         if (byte & 0x80) == 0
-            break
+            return value
         end
         shift += 7
         if shift > 63
             error("LEB128 number is too long.")
         end
     end
-    if eof(s)
-        error("Unexpected end of file while reading LEB128 number.")
-    else
-        value
-    end
 end
 
 """

test/serialization.jl

@@ -71,14 +71,14 @@ import OhMyCH: Serializer, serialize, deserialize
         s = Serializer()
 
         @test serialize(s, String, "1234567890abcdef") == 17
-        @test serialize(s, String, "") == 1
         @test serialize(s, String, "안녕하세요!") == 17
+        @test serialize(s, String, "") == 1
 
         seekstart(s)
 
         @test deserialize(s, String) == "1234567890abcdef"
-        @test deserialize(s, String) == ""
         @test deserialize(s, String) == "안녕하세요!"
+        @test deserialize(s, String) == ""
 
         @test eof(s)
     end