Merge pull request #8 from bhushankumarl/development

Bhushankumar L · web-flow · commit f0d069acb396 · 2018-10-30T13:52:55.000+05:30
Development
diff --git a/README.md b/README.md
diff --git a/examples/javascript/boards/searchBoardField.js b/examples/javascript/boards/searchBoardField.js
@@ -0,0 +1,16 @@
+var apiKey = process.env.TRELLO_API_KEY || 'YOUR_API_KEY';
+var oauthToken = process.env.TRELLO_OAUTH_TOKEN || 'OAUTH_TOKEN';
+
+var Trello = require('../../../lib/trello-node-api')(apiKey, oauthToken);
+
+var boardRequest = function () {
+    var boardId = 'BOARD_ID';
+    var field = 'shortUrl';
+    Trello.board.searchField(boardId, field).then(function (response) {
+        console.log('response ', response);
+    }).catch(function (error) {
+        console.log('error', error);
+    });
+};
+
+boardRequest();
diff --git a/examples/javascript/boards/searchBoardPromise.js b/examples/javascript/boards/searchBoardPromise.js
@@ -0,0 +1,22 @@
+var apiKey = process.env.TRELLO_API_KEY || 'YOUR_API_KEY';
+var oauthToken = process.env.TRELLO_OAUTH_TOKEN || 'OAUTH_TOKEN';
+
+var Trello = require('../../../lib/trello-node-api')(apiKey, oauthToken);
+
+var boardRequest = async function () {
+    const promises = [];
+    const boardIds = ['BOARD_ID_1', 'BOARD_ID_2'];
+
+    boardIds.forEach((boardId) => {
+        promises.push(Trello.board.search(boardId));
+    });
+
+    try {
+        const boards = await Promise.all(promises);
+        console.log('boards ', boards);
+    } catch (error) {
+        console.error('[trello]', error);
+    }
+};
+
+boardRequest();
diff --git a/examples/javascript/boards/searchBoardWithFilter.js b/examples/javascript/boards/searchBoardWithFilter.js
@@ -0,0 +1,18 @@
+var apiKey = process.env.TRELLO_API_KEY || 'YOUR_API_KEY';
+var oauthToken = process.env.TRELLO_OAUTH_TOKEN || 'OAUTH_TOKEN';
+
+var Trello = require('../../../lib/trello-node-api')(apiKey, oauthToken);
+
+var boardRequest = function () {
+    var boardId = 'BOARD_ID';
+    var fields = {
+        actions: 'all'
+    };
+    Trello.board.search(boardId, fields).then(function (response) {
+        console.log('response ', response);
+    }).catch(function (error) {
+        console.log('error', error);
+    });
+};
+
+boardRequest();
diff --git a/examples/javascript/members/searchMemberBoards.js b/examples/javascript/members/searchMemberBoards.js
@@ -4,7 +4,7 @@ var oauthToken = process.env.TRELLO_OAUTH_TOKEN || 'OAUTH_TOKEN';
 var Trello = require('../../../lib/trello-node-api')(apiKey, oauthToken);
 
 var memberRequest = function () {
-    Trello.member.searchBoards('MEMBER_ID').then(function (response) {
+    Trello.member.searchBoards('me').then(function (response) {
         console.log('response ', response);
     }).catch(function (error) {
         console.log('error', error);
diff --git a/examples/typescript/src/checklists/update.ts b/examples/typescript/src/checklists/update.ts
@@ -14,7 +14,7 @@ let checklistRequest = async function () {
     };
     let response;
     try {
-        response = await Trello.checklist.update(id, data)
+        response = await Trello.checklist.update(id, data);
     } catch (error) {
         if (error) {
             console.log('error ', error);
diff --git a/examples/typescript/src/organizations/create.ts b/examples/typescript/src/organizations/create.ts
@@ -15,7 +15,7 @@ let organizationRequest = async function () {
     };
     let response;
     try {
-        response = await Trello.organization.create(data)
+        response = await Trello.organization.create(data);
     } catch (error) {
         if (error) {
             console.log('error ', error);
diff --git a/lib/Error.js b/lib/Error.js
@@ -43,7 +43,7 @@ var TrelloError = _Error.TrelloError = _Error.extend({
         //this.headers = raw.headers;
         //this.requestId = raw.requestId;
         this.statusCode = raw.statusCode;
-    },
+    }
 });
 
 /**
diff --git a/lib/TrelloMethod.basic.js b/lib/TrelloMethod.basic.js
@@ -67,7 +67,7 @@ module.exports = {
             } else {
                 // Set entire metadata object after resetting it:
                 this._request('POST', path, {
-                    metadata: null,
+                    metadata: null
                 }, auth, {}, function (err, response) {
                     if (err) {
                         return reject(err);
@@ -78,7 +78,7 @@ module.exports = {
 
             function sendMetadata(metadata, auth) {
                 self._request('POST', path, {
-                    metadata: metadata,
+                    metadata: metadata
                 }, auth, {}, function (err, response) {
                     if (err) {
                         reject(err);
@@ -108,6 +108,6 @@ module.exports = {
                 }
             });
         }).bind(this)), cb);
-    },
+    }
 
 };
diff --git a/lib/TrelloMethod.js b/lib/TrelloMethod.js
@@ -23,8 +23,8 @@ function trelloMethod(spec) {
     var requestMethod = (spec.method || 'GET').toUpperCase();
     var urlParams = spec.urlParams || [];
     var encode = spec.encode || function (data) {
-          return data;
-      };
+        return data;
+    };
 
     return function () {
         var self = this;
diff --git a/lib/TrelloResource.js b/lib/TrelloResource.js
@@ -3,12 +3,13 @@
 var http = require('http');
 var https = require('https');
 var path = require('path');
+var Debug = require('debug');
 
 var utils = require('./utils');
 var Error = require('./Error');
 
 var hasOwn = {}.hasOwnProperty;
-
+var debug = Debug('TA:TrelloResource.js');
 // Provide extension mechanism for Trello Resource Sub-Classes
 TrelloResource.extend = utils.protoExtend;
 
@@ -72,9 +73,9 @@ TrelloResource.prototype = {
     // might produce: /invoices/{id}
     createResourcePathWithSymbols: function (pathWithSymbols) {
         return '/' + path.join(
-            this.resourcePath,
-            pathWithSymbols
-          ).replace(/\\/g, '/'); // ugly workaround for Windows
+          this.resourcePath,
+          pathWithSymbols
+        ).replace(/\\/g, '/'); // ugly workaround for Windows
     },
 
     createUrlData: function () {
@@ -93,7 +94,7 @@ TrelloResource.prototype = {
             // Ensure callback is called outside of promise stack.
             return promise.then(function (res) {
                 setTimeout(function () {
-                    callback(null, res)
+                    callback(null, res);
                 }, 0);
             }, function (err) {
                 setTimeout(function () {
@@ -118,11 +119,11 @@ TrelloResource.prototype = {
               self,
               new Error.TrelloConnectionError({
                   message: 'Request aborted due to timeout being reached (' + timeout + 'ms)',
-                  detail: timeoutErr,
+                  detail: timeoutErr
               }),
               null
             );
-        }
+        };
     },
 
     _responseHandler: function (req, callback) {
@@ -189,7 +190,7 @@ TrelloResource.prototype = {
                           message: 'Invalid JSON received from the Trello API',
                           response: response,
                           exception: e,
-                          requestId: headers['request-id'],
+                          requestId: headers['request-id']
                       }),
                       null
                     );
@@ -198,7 +199,7 @@ TrelloResource.prototype = {
                 Object.defineProperty(response, 'lastResponse', {
                     enumerable: false,
                     writable: false,
-                    value: res,
+                    value: res
                 });
                 callback.call(self, null, response);
             });
@@ -216,11 +217,11 @@ TrelloResource.prototype = {
               self,
               new Error.TrelloConnectionError({
                   message: 'An error occurred with our connection to Trello',
-                  detail: error,
+                  detail: error
               }),
               null
             );
-        }
+        };
     },
 
     _defaultHeaders: function (auth, contentLength, apiVersion) {
@@ -238,7 +239,7 @@ TrelloResource.prototype = {
             'Accept': 'application/json',
             'Content-Type': 'application/x-www-form-urlencoded',
             'Content-Length': contentLength,
-            'User-Agent': userAgentString,
+            'User-Agent': userAgentString
         };
 
         if (apiVersion) {
@@ -252,6 +253,7 @@ TrelloResource.prototype = {
         var self = this;
         var requestData;
 
+        debug('data ', data);
         if (self.requestDataProcessor) {
             requestData = self.requestDataProcessor(method, data, options.headers);
         } else {
@@ -282,22 +284,26 @@ TrelloResource.prototype = {
 
             var host = self.overrideHost || self._trello.getApiField('host');
             //console.log('path ', path);
-            var req = (
-              isInsecureConnection ? http : https
-            ).request({
+
+            var options = {
                 host: host,
                 port: self._trello.getApiField('port'),
                 path: path,
                 method: method,
                 agent: self._trello.getApiField('agent'),
                 headers: headers,
-                ciphers: 'DEFAULT:!aNULL:!eNULL:!LOW:!EXPORT:!SSLv2:!MD5',
-            });
+                ciphers: 'DEFAULT:!aNULL:!eNULL:!LOW:!EXPORT:!SSLv2:!MD5'
+            };
+            var req = (
+              isInsecureConnection ? http : https
+            ).request(options);
+
+            debug('options ', options);
 
             var requestEvent = utils.removeEmpty({
                 api_version: apiVersion,
                 method: method,
-                path: path,
+                path: path
             });
 
             req._requestEvent = requestEvent;
@@ -319,7 +325,7 @@ TrelloResource.prototype = {
                 });
             });
         }
-    },
+    }
 
 };
 
diff --git a/lib/Webhooks.js b/lib/Webhooks.js
@@ -12,7 +12,7 @@ var Webhook = {
         this.signature.verifyHeader(payload, header, secret, tolerance || Webhook.DEFAULT_TOLERANCE);
 
         return jsonPayload;
-    },
+    }
 };
 
 var signature = {
@@ -32,8 +32,8 @@ var signature = {
                 message: 'Unable to extract timestamp and signatures from header',
                 detail: {
                     header: header,
-                    payload: payload,
-                },
+                    payload: payload
+                }
             });
         }
 
@@ -42,8 +42,8 @@ var signature = {
                 message: 'No signatures found with expected scheme',
                 detail: {
                     header: header,
-                    payload: payload,
-                },
+                    payload: payload
+                }
             });
         }
 
@@ -59,8 +59,8 @@ var signature = {
                 ' Are you passing the raw request body you received from Trello?',
                 detail: {
                     header: header,
-                    payload: payload,
-                },
+                    payload: payload
+                }
             });
         }
 
@@ -71,13 +71,13 @@ var signature = {
                 message: 'Timestamp outside the tolerance zone',
                 detail: {
                     header: header,
-                    payload: payload,
-                },
+                    payload: payload
+                }
             });
         }
 
         return true;
-    },
+    }
 };
 
 function parseHeader(header, scheme) {
@@ -99,7 +99,7 @@ function parseHeader(header, scheme) {
         return accum;
     }, {
         timestamp: -1,
-        signatures: [],
+        signatures: []
     });
 }
 
diff --git a/lib/resources/Actions.js b/lib/resources/Actions.js
@@ -8,6 +8,6 @@ module.exports = TrelloResource.extend({
     path: 'actions',
     includeBasic: [
         'search', 'searchField', 'update', 'del'
-    ],
+    ]
 
 });
diff --git a/lib/resources/Boards.js b/lib/resources/Boards.js
@@ -14,5 +14,5 @@ module.exports = TrelloResource.extend({
         method: 'GET',
         path: '/{id}/cards',
         urlParams: ['id']
-    }),
+    })
 });
diff --git a/lib/resources/Cards.js b/lib/resources/Cards.js
@@ -8,6 +8,6 @@ module.exports = TrelloResource.extend({
     path: 'cards',
     includeBasic: [
         'create', 'search', 'searchField', 'update', 'del'
-    ],
+    ]
 
 });
diff --git a/lib/resources/Checklists.js b/lib/resources/Checklists.js
@@ -8,6 +8,6 @@ module.exports = TrelloResource.extend({
     path: 'checklists',
     includeBasic: [
         'create', 'search', 'searchField', 'update', 'del'
-    ],
+    ]
 
 });
diff --git a/lib/resources/Enterprises.js b/lib/resources/Enterprises.js
@@ -8,6 +8,6 @@ module.exports = TrelloResource.extend({
     path: 'enterprises',
     includeBasic: [
         'search'
-    ],
+    ]
 
 });
diff --git a/lib/resources/Labels.js b/lib/resources/Labels.js
@@ -8,6 +8,6 @@ module.exports = TrelloResource.extend({
     path: 'labels',
     includeBasic: [
         'create', 'search', 'update', 'del'
-    ],
+    ]
 
 });
diff --git a/lib/resources/Lists.js b/lib/resources/Lists.js
@@ -8,6 +8,6 @@ module.exports = TrelloResource.extend({
     path: 'lists',
     includeBasic: [
         'create', 'search', 'searchField', 'update'
-    ],
+    ]
 
 });
diff --git a/lib/resources/Members.js b/lib/resources/Members.js
diff --git a/lib/resources/Notifications.js b/lib/resources/Notifications.js
diff --git a/lib/resources/Organizations.js b/lib/resources/Organizations.js
diff --git a/lib/resources/Webhooks.js b/lib/resources/Webhooks.js
diff --git a/lib/trello-node-api.js b/lib/trello-node-api.js
diff --git a/lib/utils.js b/lib/utils.js
diff --git a/package.json b/package.json
