Skip to content

Commit dabec7c

Browse files
fixed: error handling
1 parent 47d760e commit dabec7c

File tree

2 files changed

+5
-5
lines changed

2 files changed

+5
-5
lines changed

index.next.js

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -16,8 +16,8 @@ export function loadImage(img) {
1616
// the image reference will set to null
1717
// to avoid memory leaks
1818
return new Promise((resolve, reject) => {
19+
add(i, 'error abort', error => reject(new Error(error)), { once: true })
1920
add(i, 'load', () => resolve(i), { once: true })
20-
add(i, 'error abort', reject)
2121
if (isUrl) i.src = img
2222
})
2323
}

test.js

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -4,16 +4,16 @@ const assert = require('assert')
44
const imagesLoader = require('./')
55

66

7-
const LOAD_FAILURE_SRC = 'succes.jpg'
8-
const LOAD_SUCCESS_SRC = 'failed.jpg'
7+
const LOAD_FAILURE_SRC = 'failed.jpg'
8+
const LOAD_SUCCESS_SRC = 'success.jpg'
99

1010
/* eslint-disable */
1111
Object.defineProperty(global.Image.prototype, 'src', {
1212
set(src) {
1313
if (src === LOAD_FAILURE_SRC) {
14-
setTimeout(() => this.onerror(new Error('mocked error')), Math.random() * 1000)
14+
setTimeout(() => this.dispatchEvent(new Event('error')), Math.random() * 500)
1515
} else if (src === LOAD_SUCCESS_SRC) {
16-
setTimeout(() => this.onload(), Math.random() * 1000)
16+
setTimeout(() => this.dispatchEvent(new Event('load')), Math.random() * 1000)
1717
}
1818
}
1919
})

0 commit comments

Comments
 (0)