fix: Unrunnable tests should skip

Author: effigies

tools/schemacode/src/bidsschematools/conftest.py

@@ -96,6 +96,8 @@ def fixture(tests_data_dir):
 def schema_dir() -> Generator[str, None, None]:
     """Path to the schema housed in the bids-specification repo."""
     with data.load.as_path("schema") as schema_path:
+        if not schema_path.exists():
+            pytest.skip("No schema found; probably in an installed package")
         yield str(schema_path)
 
 

tools/schemacode/src/bidsschematools/tests/test_schema.py

@@ -8,15 +8,14 @@
 
 from bidsschematools import __bids_version__, schema, types
 
-from ..data import load
 
-
-def test__get_bids_version(tmp_path):
+def test__get_bids_version(schema_dir):
     # Is the version being read in correctly?
-    schema_path = str(load("schema"))
-    bids_version = schema._get_bids_version(schema_path)
+    bids_version = schema._get_bids_version(schema_dir)
     assert bids_version == __bids_version__
 
+
+def test__get_bids_version_fallback(tmp_path):
     # Does fallback to unknown development version work?
     expected_version = "1.2.3-dev"
     schema_path = os.path.join(tmp_path, "whatever", expected_version)

tools/schemacode/src/bidsschematools/tests/test_validator.py

@@ -274,7 +274,7 @@ def test_select_schema_path(bids_examples, tmp_path):
     assert schema_path is None
 
 
-def test_bids_schema_versioncheck(monkeypatch):
+def test_bids_schema_versioncheck(monkeypatch, schema_dir):
     """Test incompatible version."""
     import bidsschematools as bst