Skip to content

Commit b60eac1

Browse files
authored
Update phenotype.md and data-summary-files.md
Doing my best to address Chris' PR comment about a few pieces.
1 parent a9e2d4b commit b60eac1

File tree

2 files changed

+5
-27
lines changed

2 files changed

+5
-27
lines changed

src/appendices/phenotype.md

Lines changed: 4 additions & 19 deletions
Original file line numberDiff line numberDiff line change
@@ -54,9 +54,8 @@ the smallest unit of acquisition). In other words:
5454
- If more than one of the same measurement tool is acquired within
5555
the same `session_id`, a `run_id` column MUST be added.
5656

57-
- Encoding the acquisition time for a measurement tool’s `session_id`,
58-
is RECOMMENDED. This information MUST be stored in the `sessions.tsv`
59-
file at the root level of the dataset in the `acq_time` column.
57+
- A measurement tool’s acquisition time SHOULD be stored in the `sessions.tsv`
58+
file at the root-level of the dataset in the `acq_time` column.
6059

6160
<!-- This block generates a columns table.
6261
The definitions of these fields can be found in
@@ -69,7 +68,7 @@ and a guide for using macros can be found at
6968
Furthermore, if you have to add a `session_id` column to the tabular phenotypic data,
7069
you then MUST also introduce a session directory to the imaging data,
7170
even if only one imaging session has been created.
72-
This rule can be considered as "**if anyone uses sessions, everyone uses sessions.**"
71+
This guideline can be considered as "**if anyone uses sessions, everyone uses sessions.**"
7372
And vice versa, if imaging data has session directories,
7473
all imaging data and tabular phenotypic data MUST have sessions.
7574

@@ -108,28 +107,14 @@ The sessions file MUST list all sessions for all subjects across
108107
imaging and tabular phenotypic data. The data dictionary JSON file’s
109108
`session_id` field MUST include `Levels` with the description of each `session_id`.
110109

111-
### 8. Use either root-level sessions file or participant-level sessions files, but not both
112-
113-
When you use a sessions file at the dataset-level,
114-
you MUST NOT provide additional sessions files at the participant-level
115-
as this might conflict with the inheritance principle.
116-
117-
### 9. Record acquisition time of all sessions with `acq_time`
110+
### 8. Record acquisition time of all sessions with `acq_time`
118111

119112
It is RECOMMENDED to store acquisition time[<sup>2</sup>](#footnotes)
120113
for tabular phenotypic data and store the time of acquisition of each row
121114
inside a column named `acq_time` in the sessions file.
122115
This is consistent with how acquisition time is recorded for MRI data
123116
and other time-sensitive measurements (for example systolic blood pressure).
124117

125-
### 10. Respect participant privacy when recording acquisition times
126-
127-
When needed to preserve participant privacy, you SHOULD record
128-
relative acquisition times with respect to the earliest session.
129-
Relative session acquisition times MAY be listed as durations from
130-
the earliest session (baseline) in days, months, or years
131-
using the `acq_time` column.
132-
133118
## Summary
134119

135120
This appendix described guidelines for best tabular phenotypic data.

src/modality-agnostic-files/data-summary-files.md

Lines changed: 1 addition & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -325,15 +325,8 @@ apply to sessions files:
325325
- [7.](../appendices/phenotype.md#7-use-the-sessions-file-at-the-root-level)
326326
Use the sessions file at the root-level
327327

328-
- [8.](../appendices/phenotype.md#8-use-either-root-level-sessions-file-or-participant-level-sessions-files-but-not-both)
329-
Use either root-level sessions file or
330-
participant-level sessions files, but not both
331-
332-
- [9.](../appendices/phenotype.md#9-record-acquisition-time-of-all-sessions-with-acq_time)
328+
- [8.](../appendices/phenotype.md#8-record-acquisition-time-of-all-sessions-with-acq_time)
333329
Record acquisition time of all sessions with `acq_time`
334330

335-
- [10.](../appendices/phenotype.md#10-respect-participant-privacy-when-recording-acquisition-times)
336-
Respect participant privacy when recording acquisition times
337-
338331
To read more about the guidelines for tabular phenotypic data and examples,
339332
see the [tabular phenotypic data guidelines appendix](../appendices/phenotype.md).

0 commit comments

Comments
 (0)