Skip to content

Commit be120f2

Browse files
committed
Backport gh-2054
metaschema: Require additional_columns field for tables schema: Define missing additional columns fix: Add initial_columns to blood.tsv rule to match spec
1 parent e88eb78 commit be120f2

File tree

3 files changed

+10
-2
lines changed

3 files changed

+10
-2
lines changed

src/metaschema.json

Lines changed: 3 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -634,15 +634,16 @@
634634
"additionalProperties": false
635635
},
636636
"additional_columns": {
637-
"type": "string"
637+
"type": "string",
638+
"enum": ["allowed", "allowed_if_defined", "not_allowed", "n/a"]
638639
},
639640
"index_columns": { "type": "array", "items": { "type": "string" } },
640641
"initial_columns": {
641642
"type": "array",
642643
"items": { "type": "string" }
643644
}
644645
},
645-
"required": ["selectors", "columns"],
646+
"required": ["selectors", "columns", "additional_columns"],
646647
"additionalProperties": false
647648
}
648649
}

src/schema/rules/tabular_data/derivatives/common_derivatives.yaml

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -10,6 +10,7 @@ SegmentationLookup:
1010
color: optional
1111
mapping: optional
1212
index_columns: [index]
13+
additional_columns: allowed
1314

1415
Descriptions:
1516
selectors:

src/schema/rules/tabular_data/pet.yaml

Lines changed: 6 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -4,6 +4,7 @@ Blood:
44
- datatype == "pet"
55
- suffix == "blood"
66
- extension == ".tsv"
7+
initial_columns: [time]
78
columns:
89
time: required
910
plasma_radioactivity:
@@ -21,6 +22,7 @@ Blood:
2122
whole_blood_radioactivity:
2223
level: optional
2324
level_addendum: required if `WholeBloodAvail` is `true`
25+
additional_columns: allowed
2426

2527
BloodPlasma:
2628
selectors:
@@ -30,6 +32,7 @@ BloodPlasma:
3032
- sidecar.PlasmaAvail == true
3133
columns:
3234
plasma_radioactivity: required
35+
additional_columns: n/a
3336

3437
BloodMetabolite:
3538
selectors:
@@ -40,6 +43,7 @@ BloodMetabolite:
4043
columns:
4144
metabolite_parent_fraction: required
4245
metabolite_polar_fraction: recommended
46+
additional_columns: n/a
4347

4448
BloodMetaboliteCorrection:
4549
selectors:
@@ -49,6 +53,7 @@ BloodMetaboliteCorrection:
4953
- sidecar.MetaboliteRecoveryCorrectionApplied == true
5054
columns:
5155
hplc_recovery_fractions: required
56+
additional_columns: n/a
5257

5358
BloodWholeBlood:
5459
selectors:
@@ -58,3 +63,4 @@ BloodWholeBlood:
5863
- sidecar.WholeBloodAvail == true
5964
columns:
6065
whole_blood_radioactivity: required
66+
additional_columns: n/a

0 commit comments

Comments
 (0)