From 34843d9a952c54f27972e11a3ba381dd30ffd1df Mon Sep 17 00:00:00 2001
From: Daniel McCloy <dan@mccloy.info>
Date: Mon, 24 Mar 2025 11:09:10 -0500
Subject: [PATCH 1/5] slightly expand the definition of `acq`

---
 src/schema/objects/entities.yaml | 6 +++++-
 1 file changed, 5 insertions(+), 1 deletion(-)

diff --git a/src/schema/objects/entities.yaml b/src/schema/objects/entities.yaml
index a5638bc984..3d49f4447e 100644
--- a/src/schema/objects/entities.yaml
+++ b/src/schema/objects/entities.yaml
@@ -8,7 +8,7 @@ acquisition:
   display_name: Acquisition
   description: |
     The `acq-<label>` entity corresponds to a custom label the user MAY use to distinguish
-    a different set of parameters used for acquiring the same modality.
+    a different set of parameters or devices used for acquiring the same modality.
 
     For example, this should be used when a study includes two T1w images -
     one full brain low resolution and one restricted field of view but high resolution.
@@ -23,6 +23,10 @@ acquisition:
     The level of detail at which the distinction is made
     (for example, just between `RARE` and `FLASH`, or between `RARE`, `FLASH`, and `FLASHsubsampled`)
     remains at the discretion of the researcher.
+
+    For modalities where multiple recording devices may be in use simultaneously
+    (and may each record into different data files with different recording parameters),
+    the `acq-<label>` entity may also be used.
   type: string
   format: label
 ceagent:

From 034f62ae3fcc954e63d889959d2b6af00d8d75d9 Mon Sep 17 00:00:00 2001
From: Daniel McCloy <dan@mccloy.info>
Date: Sun, 30 Mar 2025 11:48:02 -0500
Subject: [PATCH 2/5] add example

---
 src/schema/objects/entities.yaml | 3 +++
 1 file changed, 3 insertions(+)

diff --git a/src/schema/objects/entities.yaml b/src/schema/objects/entities.yaml
index 3d49f4447e..72917a93d2 100644
--- a/src/schema/objects/entities.yaml
+++ b/src/schema/objects/entities.yaml
@@ -27,6 +27,9 @@ acquisition:
     For modalities where multiple recording devices may be in use simultaneously
     (and may each record into different data files with different recording parameters),
     the `acq-<label>` entity may also be used.
+    For example, an EMG dataset with simultaneous recordings from a bipolar sensor and an
+    electrode grid could have the following names:
+    `sub-01_acq-bipolar_emg.bdf` and `sub-01_acq-grid_emg.bdf`.
   type: string
   format: label
 ceagent:

From 3278a5005c363ba260640619131c47690109a871 Mon Sep 17 00:00:00 2001
From: "Seyed (Yahya) Shirazi" <shirazi@ieee.org>
Date: Thu, 7 Aug 2025 07:30:18 -0700
Subject: [PATCH 3/5] Update proposed change from `acq` to `recording`

---
 src/schema/objects/entities.yaml | 10 ++--------
 1 file changed, 2 insertions(+), 8 deletions(-)

diff --git a/src/schema/objects/entities.yaml b/src/schema/objects/entities.yaml
index 72917a93d2..e2df6715dc 100644
--- a/src/schema/objects/entities.yaml
+++ b/src/schema/objects/entities.yaml
@@ -8,7 +8,7 @@ acquisition:
   display_name: Acquisition
   description: |
     The `acq-<label>` entity corresponds to a custom label the user MAY use to distinguish
-    a different set of parameters or devices used for acquiring the same modality.
+    a different set of parameters used for acquiring the same modality.
 
     For example, this should be used when a study includes two T1w images -
     one full brain low resolution and one restricted field of view but high resolution.
@@ -24,12 +24,6 @@ acquisition:
     (for example, just between `RARE` and `FLASH`, or between `RARE`, `FLASH`, and `FLASHsubsampled`)
     remains at the discretion of the researcher.
 
-    For modalities where multiple recording devices may be in use simultaneously
-    (and may each record into different data files with different recording parameters),
-    the `acq-<label>` entity may also be used.
-    For example, an EMG dataset with simultaneous recordings from a bipolar sensor and an
-    electrode grid could have the following names:
-    `sub-01_acq-bipolar_emg.bdf` and `sub-01_acq-grid_emg.bdf`.
   type: string
   format: label
 ceagent:
@@ -250,7 +244,7 @@ recording:
   description: |
     The `recording-<label>` entity can be used to distinguish continuous recording files.
 
-    This entity is commonly applied when continuous recordings have different sampling frequencies or start times.
+    This entity is commonly applied when continuous recordings are from different acquisition instruments, or have different sampling frequencies or start times.
     For example, physiological recordings with different sampling frequencies may be distinguished using
     labels like `recording-100Hz` and `recording-500Hz`.
   type: string

From 542b7efd77bd00efd5563a6141ba4bf02da714de Mon Sep 17 00:00:00 2001
From: "Seyed (Yahya) Shirazi" <shirazi@ieee.org>
Date: Thu, 7 Aug 2025 07:31:31 -0700
Subject: [PATCH 4/5] Update entities.yaml

---
 src/schema/objects/entities.yaml | 1 -
 1 file changed, 1 deletion(-)

diff --git a/src/schema/objects/entities.yaml b/src/schema/objects/entities.yaml
index e2df6715dc..d2f4be0bef 100644
--- a/src/schema/objects/entities.yaml
+++ b/src/schema/objects/entities.yaml
@@ -23,7 +23,6 @@ acquisition:
     The level of detail at which the distinction is made
     (for example, just between `RARE` and `FLASH`, or between `RARE`, `FLASH`, and `FLASHsubsampled`)
     remains at the discretion of the researcher.
-
   type: string
   format: label
 ceagent:

From 3335f71c1c5fe0eb1556a9d61568ddf121a41ddc Mon Sep 17 00:00:00 2001
From: "Seyed (Yahya) Shirazi" <shirazi@ieee.org>
Date: Thu, 7 Aug 2025 07:33:45 -0700
Subject: [PATCH 5/5] fix line length

---
 src/schema/objects/entities.yaml | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/src/schema/objects/entities.yaml b/src/schema/objects/entities.yaml
index d2f4be0bef..3903a010a6 100644
--- a/src/schema/objects/entities.yaml
+++ b/src/schema/objects/entities.yaml
@@ -243,7 +243,8 @@ recording:
   description: |
     The `recording-<label>` entity can be used to distinguish continuous recording files.
 
-    This entity is commonly applied when continuous recordings are from different acquisition instruments, or have different sampling frequencies or start times.
+    This entity is commonly applied when continuous recordings are from different acquisition instruments,
+    or have different sampling frequencies or start times.
     For example, physiological recordings with different sampling frequencies may be distinguished using
     labels like `recording-100Hz` and `recording-500Hz`.
   type: string