Skip to content

Commit 266310f

Browse files
authored
Merge pull request #188 from bids-standard/doc/scrive_for_180
Add scrive for #180 and workflow to check for changes in changelog.d
2 parents ecf8fb7 + 806ac64 commit 266310f

File tree

3 files changed

+79
-0
lines changed

3 files changed

+79
-0
lines changed

.github/scripts/scriv_check.sh

Lines changed: 20 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,20 @@
1+
#!/usr/bin/env bash
2+
# Modified from https://github.com/tarides/changelog-check-action/tree/main
3+
4+
set -uo pipefail
5+
6+
if [ "${NO_CHANGELOG_LABEL}" = "true" ]; then
7+
# 'no changelog' set, so finish successfully
8+
exit 0
9+
else
10+
# a changelog check is required
11+
# fail if the diff is empty
12+
if git diff --exit-code "origin/${BASE_REF}" -- "changelog.d/"; then
13+
cat <<END >&2
14+
User-visible changes should come with an entry in the changelog.
15+
Create a changelog blurb with "uvx scriv create --edit".
16+
If no changelog entry is needed, then set the "no changelog" label.
17+
END
18+
exit 1
19+
fi
20+
fi

.github/workflows/validation.yml

Lines changed: 12 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -22,3 +22,15 @@ jobs:
2222
python-version: 3
2323
- name: Validate CITATION.cff
2424
run: pipx run cffconvert --validate
25+
check_change_log:
26+
runs-on: ubuntu-latest
27+
steps:
28+
- uses: actions/checkout@v4
29+
with:
30+
fetch-depth: 0
31+
- name: Check for changes in changelog
32+
env:
33+
BASE_REF: ${{ github.event.pull_request.base.ref }}
34+
NO_CHANGELOG_LABEL: ${{ contains(github.event.pull_request.labels.*.name, 'no changelog') }}
35+
run: .github/scripts/scriv_check.sh
36+
shell: bash
Lines changed: 47 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,47 @@
1+
<!--
2+
A new scriv changelog fragment.
3+
4+
Uncomment the section that is right (remove the HTML comment wrapper).
5+
-->
6+
7+
### Added
8+
9+
- Validate directory names names according to `schema.rules.directories` entries.
10+
Use rules to identify "opaque" directories whose contents are unspecified by BIDS.
11+
12+
<!--
13+
### Changed
14+
15+
- A bullet item for the Changed category.
16+
17+
-->
18+
<!--
19+
### Fixed
20+
21+
- A bullet item for the Fixed category.
22+
23+
-->
24+
<!--
25+
### Deprecated
26+
27+
- A bullet item for the Deprecated category.
28+
29+
-->
30+
<!--
31+
### Removed
32+
33+
- A bullet item for the Removed category.
34+
35+
-->
36+
<!--
37+
### Security
38+
39+
- A bullet item for the Security category.
40+
41+
-->
42+
<!--
43+
### Infrastructure
44+
45+
- A bullet item for the Infrastructure category.
46+
47+
-->

0 commit comments

Comments
 (0)