-
Notifications
You must be signed in to change notification settings - Fork 52
Open
Labels
Milestone
Description
Problem
Issue #659: DIA-NN parameters are generated in two different places:
- OpenMS parameters: generated by sdrf-pipelines (
parse_sdrf convert-openms) - DIA-NN parameters: generated by quantms-utils (
quantmsutilsc dianncfg)
SDRF metadata like scan windows and per-run tolerances exists in the SDRF but must still be passed as command-line parameters.
Solution: Consolidate to sdrf-pipelines
Migrate all DIA-NN config generation to parse_sdrf convert-diann. This provides:
- Unified config flow: SDRF ->
parse_sdrf convert-diann->diann_config.cfg+diann_filemap.tsv - Per-run tolerance support:
diann_filemap.tsvcontains per-file precursor/fragment tolerances - plexDIA integration: Channel definitions generated from SDRF labels automatically
- Immunopeptidomics detection: Enzyme parsing detects unspecific cleavage
- Single source of truth: All parameter generation in one place
Tasks
- Commit and release sdrf-pipelines converter (Phase 1, #TBD_1)
- Update
GENERATE_CFGmodule to callparse_sdrf convert-dianninstead ofquantmsutilsc dianncfg - Wire
diann_filemap.tsvinto per-file processes (per-run tolerances) - Deprecate
quantmsutilsc dianncfgwith backwards compatibility period - Update quantms-utils container to include sdrf-pipelines
Per-Run Mass Accuracy Support
Current: mass accuracy is either automatic or global.
New: diann_filemap.tsv provides per-file PrecursorMassTolerance and FragmentMassTolerance.
def mass_acc = meta.fragmentmasstolerance ? "--mass-acc ${meta.fragmentmasstolerance}" : ""
def mass_acc_ms1 = meta.precursormasstolerance ? "--mass-acc-ms1 ${meta.precursormasstolerance}" : ""Test Plan
- Run PXD026600 with
parse_sdrf convert-diann— verify identical output toquantmsutilsc dianncfg - Run PXD039578 (SILAC) — verify plexDIA config generated from SDRF automatically
- Verify per-file tolerances from
diann_filemap.tsvapplied in INDIVIDUAL_ANALYSIS
Dataset: PXD026600 (existing CI/CD), PXD039578 (plexDIA)
Reactions are currently unavailable