Skip to content

Commit 04af28e

Browse files
authored
Merge pull request #190 from xJuvi/feature-bbb2.6
2 parents a48a106 + d520b3d commit 04af28e

File tree

3 files changed

+80
-1
lines changed

3 files changed

+80
-1
lines changed

src/Parameters/CreateMeetingParameters.php

Lines changed: 69 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -321,6 +321,21 @@ class CreateMeetingParameters extends MetaParameters
321321
* @var array
322322
*/
323323
private $breakoutRoomsGroups = [];
324+
325+
/**
326+
* @var bool
327+
*/
328+
private $notifyRecordingIsOn;
329+
330+
/**
331+
* @var string
332+
*/
333+
private $uploadExternalUrl;
334+
335+
/**
336+
* @var string
337+
*/
338+
private $uploadExternalDescription;
324339

325340
/**
326341
* CreateMeetingParameters constructor.
@@ -1442,6 +1457,57 @@ public function addBreakoutRoomsGroup($id, $name, $roster)
14421457

14431458
return $this;
14441459
}
1460+
1461+
public function getNotifyRecordingIsOn(): bool
1462+
{
1463+
return $this->notifyRecordingIsOn;
1464+
}
1465+
1466+
/**
1467+
* @param $notifyRecordingIsOn
1468+
*
1469+
* @return $this
1470+
*/
1471+
public function setNotifyRecordingIsOn(bool $notifyRecordingIsOn): CreateMeetingParameters
1472+
{
1473+
$this->notifyRecordingIsOn = $notifyRecordingIsOn;
1474+
1475+
return $this;
1476+
}
1477+
1478+
public function getUploadExternalUrl(): string
1479+
{
1480+
return $this->uploadExternalUrl;
1481+
}
1482+
1483+
/**
1484+
* @param $uploadExternalUrl
1485+
*
1486+
* @return $this
1487+
*/
1488+
public function setUploadExternalUrl(string $uploadExternalUrl): CreateMeetingParameters
1489+
{
1490+
$this->uploadExternalUrl = $uploadExternalUrl;
1491+
1492+
return $this;
1493+
}
1494+
1495+
public function getUploadExternalDescription(): string
1496+
{
1497+
return $this->uploadExternalDescription;
1498+
}
1499+
1500+
/**
1501+
* @param $uploadExternalDescription
1502+
*
1503+
* @return $this
1504+
*/
1505+
public function setUploadExternalDescription(string $uploadExternalDescription): CreateMeetingParameters
1506+
{
1507+
$this->uploadExternalDescription = $uploadExternalDescription;
1508+
1509+
return $this;
1510+
}
14451511

14461512
/**
14471513
* @return string
@@ -1499,6 +1565,9 @@ public function getHTTPQuery()
14991565
'meetingExpireWhenLastUserLeftInMinutes' => $this->meetingExpireWhenLastUserLeftInMinutes,
15001566
'preUploadedPresentationOverrideDefault' => $this->preUploadedPresentationOverrideDefault,
15011567
'disabledFeatures' => join(',', $this->disabledFeatures),
1568+
'notifyRecordingIsOn' => $this->notifyRecordingIsOn ? 'true' : 'false',
1569+
'uploadExternalUrl' => $this->uploadExternalUrl,
1570+
'uploadExternalDescription' => $this->uploadExternalDescription,
15021571
];
15031572

15041573
// Add breakout rooms parameters only if the meeting is a breakout room

tests/Parameters/CreateMeetingParametersTest.php

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -91,6 +91,10 @@ public function testCreateMeetingParameters()
9191
$this->assertEquals($params['meta_presenter'], $createMeetingParams->getMeta('presenter'));
9292
$this->assertEquals($params['meta_endCallbackUrl'], $createMeetingParams->getMeta('endCallbackUrl'));
9393
$this->assertEquals($params['meta_bbb-recording-ready-url'], $createMeetingParams->getMeta('bbb-recording-ready-url'));
94+
95+
$this->assertEquals($params['notifyRecordingIsOn'], $createMeetingParams->getNotifyRecordingIsOn());
96+
$this->assertEquals($params['uploadExternalUrl'], $createMeetingParams->getUploadExternalUrl());
97+
$this->assertEquals($params['uploadExternalDescription'], $createMeetingParams->getUploadExternalDescription());
9498

9599
// Check values are empty of this is not a breakout room
96100
$this->assertNull($createMeetingParams->isBreakout());

tests/TestCase.php

Lines changed: 7 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -185,6 +185,9 @@ protected function generateCreateParams()
185185
'meta_presenter' => $this->faker->name,
186186
'meta_endCallbackUrl' => $this->faker->url,
187187
'meta_bbb-recording-ready-url' => $this->faker->url,
188+
'notifyRecordingIsOn' => $this->faker->boolean(50),
189+
'uploadExternalUrl' => $this->faker->url,
190+
'uploadExternalDescription' => $this->faker->text,
188191
];
189192
}
190193

@@ -281,7 +284,10 @@ protected function getCreateMock($params)
281284
->setPreUploadedPresentationOverrideDefault($params['preUploadedPresentationOverrideDefault'])
282285
->setDisabledFeatures($params['disabledFeatures'])
283286
->addMeta('presenter', $params['meta_presenter'])
284-
->addMeta('bbb-recording-ready-url', $params['meta_bbb-recording-ready-url'])
287+
->addMeta('bbb-recording-ready-url', $params['meta_bbb-recording-ready-url'])
288+
->setNotifyRecordingIsOn($params['notifyRecordingIsOn'])
289+
->setUploadExternalUrl($params['uploadExternalUrl'])
290+
->setUploadExternalDescription($params['uploadExternalDescription'])
285291
;
286292
}
287293

0 commit comments

Comments
 (0)