Skip to content

Commit 36d38d6

Browse files
committed
Refactor return types
1 parent 98f1a0c commit 36d38d6

30 files changed

+158
-595
lines changed

src/BigBlueButton.php

Lines changed: 33 additions & 122 deletions
Original file line numberDiff line numberDiff line change
@@ -123,13 +123,11 @@ public function __construct(?string $baseUrl = null, ?string $secret = null, ?Tr
123123
}
124124

125125
/**
126-
* @return ApiVersionResponse
127-
*
128126
* @throws NetworkException
129127
* @throws ParsingException
130128
* @throws RuntimeException
131129
*/
132-
public function getApiVersion()
130+
public function getApiVersion(): ApiVersionResponse
133131
{
134132
$xml = $this->processXmlResponse($this->urlBuilder->buildUrl());
135133

@@ -182,269 +180,202 @@ public function getConnectionError(): ?int
182180
return $this->connectionError;
183181
}
184182

185-
/* __________________ BBB ADMINISTRATION METHODS _________________ */
186-
/* The methods in the following section support the following categories of the BBB API:
187-
-- create
188-
-- join
189-
-- end
190-
*/
191-
192-
/**
193-
* @return string
194-
*/
195-
public function getCreateMeetingUrl(CreateMeetingParameters $createMeetingParams)
183+
public function getCreateMeetingUrl(CreateMeetingParameters $createMeetingParams): string
196184
{
197185
return $this->urlBuilder->buildUrl(ApiMethod::CREATE, $createMeetingParams->getHTTPQuery());
198186
}
199187

200188
/**
201-
* @return CreateMeetingResponse
202-
*
203189
* @throws NetworkException
204190
* @throws ParsingException
205191
* @throws RuntimeException
206192
*/
207-
public function createMeeting(CreateMeetingParameters $createMeetingParams)
193+
public function createMeeting(CreateMeetingParameters $createMeetingParams): CreateMeetingResponse
208194
{
209195
$xml = $this->processXmlResponse($this->getCreateMeetingUrl($createMeetingParams), $createMeetingParams->getPresentationsAsXML());
210196

211197
return new CreateMeetingResponse($xml);
212198
}
213199

214-
/**
215-
* @return string
216-
*/
217-
public function getJoinMeetingURL(JoinMeetingParameters $joinMeetingParams)
200+
public function getJoinMeetingURL(JoinMeetingParameters $joinMeetingParams): string
218201
{
219202
return $this->urlBuilder->buildUrl(ApiMethod::JOIN, $joinMeetingParams->getHTTPQuery());
220203
}
221204

222205
/**
223-
* @return JoinMeetingResponse
224-
*
225206
* @throws NetworkException
226207
* @throws ParsingException
227208
* @throws RuntimeException
228209
*/
229-
public function joinMeeting(JoinMeetingParameters $joinMeetingParams)
210+
public function joinMeeting(JoinMeetingParameters $joinMeetingParams): JoinMeetingResponse
230211
{
231212
$xml = $this->processXmlResponse($this->getJoinMeetingURL($joinMeetingParams));
232213

233214
return new JoinMeetingResponse($xml);
234215
}
235216

236-
/**
237-
* @return string
238-
*/
239-
public function getEndMeetingURL(EndMeetingParameters $endParams)
217+
public function getEndMeetingURL(EndMeetingParameters $endParams): string
240218
{
241219
return $this->urlBuilder->buildUrl(ApiMethod::END, $endParams->getHTTPQuery());
242220
}
243221

244222
/**
245-
* @return EndMeetingResponse
246-
*
247223
* @throws NetworkException
248224
* @throws ParsingException
249225
* @throws RuntimeException
250226
*/
251-
public function endMeeting(EndMeetingParameters $endParams)
227+
public function endMeeting(EndMeetingParameters $endParams): EndMeetingResponse
252228
{
253229
$xml = $this->processXmlResponse($this->getEndMeetingURL($endParams));
254230

255231
return new EndMeetingResponse($xml);
256232
}
257233

258-
/**
259-
* @return string
260-
*/
261-
public function getIsMeetingRunningUrl(IsMeetingRunningParameters $meetingParams)
234+
public function getIsMeetingRunningUrl(IsMeetingRunningParameters $meetingParams): string
262235
{
263236
return $this->urlBuilder->buildUrl(ApiMethod::IS_MEETING_RUNNING, $meetingParams->getHTTPQuery());
264237
}
265238

266239
/**
267-
* @return IsMeetingRunningResponse
268-
*
269240
* @throws NetworkException
270241
* @throws ParsingException
271242
* @throws RuntimeException
272243
*/
273-
public function isMeetingRunning(IsMeetingRunningParameters $meetingParams)
244+
public function isMeetingRunning(IsMeetingRunningParameters $meetingParams): IsMeetingRunningResponse
274245
{
275246
$xml = $this->processXmlResponse($this->getIsMeetingRunningUrl($meetingParams));
276247

277248
return new IsMeetingRunningResponse($xml);
278249
}
279250

280-
/**
281-
* @return string
282-
*/
283-
public function getMeetingsUrl()
251+
public function getMeetingsUrl(): string
284252
{
285253
return $this->urlBuilder->buildUrl(ApiMethod::GET_MEETINGS);
286254
}
287255

288256
/**
289-
* @return GetMeetingsResponse
290-
*
291257
* @throws NetworkException
292258
* @throws ParsingException
293259
* @throws RuntimeException
294260
*/
295-
public function getMeetings()
261+
public function getMeetings(): GetMeetingsResponse
296262
{
297263
$xml = $this->processXmlResponse($this->getMeetingsUrl());
298264

299265
return new GetMeetingsResponse($xml);
300266
}
301267

302-
/**
303-
* @return string
304-
*/
305-
public function getMeetingInfoUrl(GetMeetingInfoParameters $meetingParams)
268+
public function getMeetingInfoUrl(GetMeetingInfoParameters $meetingParams): string
306269
{
307270
return $this->urlBuilder->buildUrl(ApiMethod::GET_MEETING_INFO, $meetingParams->getHTTPQuery());
308271
}
309272

310273
/**
311-
* @return GetMeetingInfoResponse
312-
*
313274
* @throws NetworkException
314275
* @throws ParsingException
315276
* @throws RuntimeException
316277
*/
317-
public function getMeetingInfo(GetMeetingInfoParameters $meetingParams)
278+
public function getMeetingInfo(GetMeetingInfoParameters $meetingParams): GetMeetingInfoResponse
318279
{
319280
$xml = $this->processXmlResponse($this->getMeetingInfoUrl($meetingParams));
320281

321282
return new GetMeetingInfoResponse($xml);
322283
}
323284

324-
/**
325-
* @return string
326-
*/
327-
public function getRecordingsUrl(GetRecordingsParameters $recordingsParams)
285+
public function getRecordingsUrl(GetRecordingsParameters $recordingsParams): string
328286
{
329287
return $this->urlBuilder->buildUrl(ApiMethod::GET_RECORDINGS, $recordingsParams->getHTTPQuery());
330288
}
331289

332290
/**
333-
* @return GetRecordingsResponse
334-
*
335291
* @throws NetworkException
336292
* @throws ParsingException
337293
* @throws RuntimeException
338294
*/
339-
public function getRecordings(GetRecordingsParameters $recordingParams)
295+
public function getRecordings(GetRecordingsParameters $recordingParams): GetRecordingsResponse
340296
{
341297
$xml = $this->processXmlResponse($this->getRecordingsUrl($recordingParams));
342298

343299
return new GetRecordingsResponse($xml);
344300
}
345301

346-
/**
347-
* @return string
348-
*/
349-
public function getPublishRecordingsUrl(PublishRecordingsParameters $recordingParams)
302+
public function getPublishRecordingsUrl(PublishRecordingsParameters $recordingParams): string
350303
{
351304
return $this->urlBuilder->buildUrl(ApiMethod::PUBLISH_RECORDINGS, $recordingParams->getHTTPQuery());
352305
}
353306

354307
/**
355-
* @return PublishRecordingsResponse
356-
*
357308
* @throws NetworkException
358309
* @throws ParsingException
359310
* @throws RuntimeException
360311
*/
361-
public function publishRecordings(PublishRecordingsParameters $recordingParams)
312+
public function publishRecordings(PublishRecordingsParameters $recordingParams): PublishRecordingsResponse
362313
{
363314
$xml = $this->processXmlResponse($this->getPublishRecordingsUrl($recordingParams));
364315

365316
return new PublishRecordingsResponse($xml);
366317
}
367318

368-
/**
369-
* @return string
370-
*/
371-
public function getDeleteRecordingsUrl(DeleteRecordingsParameters $recordingParams)
319+
public function getDeleteRecordingsUrl(DeleteRecordingsParameters $recordingParams): string
372320
{
373321
return $this->urlBuilder->buildUrl(ApiMethod::DELETE_RECORDINGS, $recordingParams->getHTTPQuery());
374322
}
375323

376324
/**
377-
* @return DeleteRecordingsResponse
378-
*
379325
* @throws NetworkException
380326
* @throws ParsingException
381327
* @throws RuntimeException
382328
*/
383-
public function deleteRecordings(DeleteRecordingsParameters $recordingParams)
329+
public function deleteRecordings(DeleteRecordingsParameters $recordingParams): DeleteRecordingsResponse
384330
{
385331
$xml = $this->processXmlResponse($this->getDeleteRecordingsUrl($recordingParams));
386332

387333
return new DeleteRecordingsResponse($xml);
388334
}
389335

390-
/**
391-
* @return string
392-
*/
393-
public function getUpdateRecordingsUrl(UpdateRecordingsParameters $recordingParams)
336+
public function getUpdateRecordingsUrl(UpdateRecordingsParameters $recordingParams): string
394337
{
395338
return $this->urlBuilder->buildUrl(ApiMethod::UPDATE_RECORDINGS, $recordingParams->getHTTPQuery());
396339
}
397340

398341
/**
399-
* @return UpdateRecordingsResponse
400-
*
401342
* @throws NetworkException
402343
* @throws ParsingException
403344
* @throws RuntimeException
404345
*/
405-
public function updateRecordings(UpdateRecordingsParameters $recordingParams)
346+
public function updateRecordings(UpdateRecordingsParameters $recordingParams): UpdateRecordingsResponse
406347
{
407348
$xml = $this->processXmlResponse($this->getUpdateRecordingsUrl($recordingParams));
408349

409350
return new UpdateRecordingsResponse($xml);
410351
}
411352

412-
/**
413-
* @return string
414-
*/
415-
public function getRecordingTextTracksUrl(GetRecordingTextTracksParameters $getRecordingTextTracksParams)
353+
public function getRecordingTextTracksUrl(GetRecordingTextTracksParameters $getRecordingTextTracksParams): string
416354
{
417355
return $this->urlBuilder->buildUrl(ApiMethod::GET_RECORDING_TEXT_TRACKS, $getRecordingTextTracksParams->getHTTPQuery());
418356
}
419357

420358
/**
421-
* @return GetRecordingTextTracksResponse
422-
*
423359
* @throws NetworkException
424360
* @throws RuntimeException
425361
*/
426-
public function getRecordingTextTracks(GetRecordingTextTracksParameters $getRecordingTextTracksParams)
362+
public function getRecordingTextTracks(GetRecordingTextTracksParameters $getRecordingTextTracksParams): GetRecordingTextTracksResponse
427363
{
428364
return new GetRecordingTextTracksResponse(
429365
$this->processJsonResponse($this->getRecordingTextTracksUrl($getRecordingTextTracksParams))
430366
);
431367
}
432368

433-
/**
434-
* @return string
435-
*/
436-
public function getPutRecordingTextTrackUrl(PutRecordingTextTrackParameters $putRecordingTextTrackParams)
369+
public function getPutRecordingTextTrackUrl(PutRecordingTextTrackParameters $putRecordingTextTrackParams): string
437370
{
438371
return $this->urlBuilder->buildUrl(ApiMethod::PUT_RECORDING_TEXT_TRACK, $putRecordingTextTrackParams->getHTTPQuery());
439372
}
440373

441374
/**
442-
* @return PutRecordingTextTrackResponse
443-
*
444375
* @throws NetworkException
445376
* @throws RuntimeException
446377
*/
447-
public function putRecordingTextTrack(PutRecordingTextTrackParameters $putRecordingTextTrackParams)
378+
public function putRecordingTextTrack(PutRecordingTextTrackParameters $putRecordingTextTrackParams): PutRecordingTextTrackResponse
448379
{
449380
$url = $this->getPutRecordingTextTrackUrl($putRecordingTextTrackParams);
450381
$file = $putRecordingTextTrackParams->getFile();
@@ -456,62 +387,46 @@ public function putRecordingTextTrack(PutRecordingTextTrackParameters $putRecord
456387
);
457388
}
458389

459-
/**
460-
* @return string
461-
*/
462-
public function getHooksCreateUrl(HooksCreateParameters $hookCreateParams)
390+
public function getHooksCreateUrl(HooksCreateParameters $hookCreateParams): string
463391
{
464392
return $this->urlBuilder->buildUrl(ApiMethod::HOOKS_CREATE, $hookCreateParams->getHTTPQuery());
465393
}
466394

467395
/**
468-
* @return HooksCreateResponse
469-
*
470396
* @throws NetworkException
471397
* @throws RuntimeException
472398
* @throws ParsingException
473399
*/
474-
public function hooksCreate(HooksCreateParameters $hookCreateParams)
400+
public function hooksCreate(HooksCreateParameters $hookCreateParams): HooksCreateResponse
475401
{
476402
$xml = $this->processXmlResponse($this->getHooksCreateUrl($hookCreateParams));
477403

478404
return new HooksCreateResponse($xml);
479405
}
480406

481-
/**
482-
* @return string
483-
*/
484-
public function getHooksListUrl()
407+
public function getHooksListUrl(): string
485408
{
486409
return $this->urlBuilder->buildUrl(ApiMethod::HOOKS_LIST);
487410
}
488411

489-
/**
490-
* @return HooksListResponse
491-
*/
492-
public function hooksList()
412+
public function hooksList(): HooksListResponse
493413
{
494414
$xml = $this->processXmlResponse($this->getHooksListUrl());
495415

496416
return new HooksListResponse($xml);
497417
}
498418

499-
/**
500-
* @return string
501-
*/
502-
public function getHooksDestroyUrl(HooksDestroyParameters $hooksDestroyParams)
419+
public function getHooksDestroyUrl(HooksDestroyParameters $hooksDestroyParams): string
503420
{
504421
return $this->urlBuilder->buildUrl(ApiMethod::HOOKS_DESTROY, $hooksDestroyParams->getHTTPQuery());
505422
}
506423

507424
/**
508-
* @return HooksDestroyResponse
509-
*
510425
* @throws NetworkException
511426
* @throws RuntimeException
512427
* @throws ParsingException
513428
*/
514-
public function hooksDestroy(HooksDestroyParameters $hooksDestroyParams)
429+
public function hooksDestroy(HooksDestroyParameters $hooksDestroyParams): HooksDestroyResponse
515430
{
516431
$xml = $this->processXmlResponse($this->getHooksDestroyUrl($hooksDestroyParams));
517432

@@ -535,16 +450,12 @@ public function insertDocument(InsertDocumentParameters $insertDocumentParams):
535450
return new InsertDocumentResponse($xml);
536451
}
537452

538-
/* ____________________ SPECIAL METHODS ___________________ */
539-
/**
540-
* @return string
541-
*/
542-
public function getJSessionId()
453+
public function getJSessionId(): ?string
543454
{
544455
return $this->jSessionId;
545456
}
546457

547-
public function setJSessionId(string $jSessionId)
458+
public function setJSessionId(string $jSessionId): void
548459
{
549460
$this->jSessionId = $jSessionId;
550461
}

0 commit comments

Comments
 (0)