Make JoinMeeting-Test work again

Author: DigitalTimK

src/BigBlueButton.php

@@ -184,11 +184,9 @@ public function getIsMeetingRunningUrl(IsMeetingRunningParameters $meetingParams
     }
 
     /**
-     * @param mixed $meetingParams
-     *
      * @throws BadResponseException|\RuntimeException
      */
-    public function isMeetingRunning($meetingParams): IsMeetingRunningResponse
+    public function isMeetingRunning(IsMeetingRunningParameters $meetingParams): IsMeetingRunningResponse
     {
         $xml = $this->processXmlResponse($this->getIsMeetingRunningUrl($meetingParams));
 

src/Parameters/JoinMeetingParameters.php

@@ -40,7 +40,7 @@ class JoinMeetingParameters extends UserDataParameters
 
     private ?string $webVoiceConf = null;
 
-    private ?int $creationTime = null;
+    private ?float $creationTime = null;
 
     private ?string $avatarURL = null;
 
@@ -147,12 +147,12 @@ public function setWebVoiceConf(string $webVoiceConf): self
         return $this;
     }
 
-    public function getCreationTime(): ?int
+    public function getCreationTime(): ?float
     {
         return $this->creationTime;
     }
 
-    public function setCreationTime(int $creationTime): self
+    public function setCreationTime(float $creationTime): self
     {
         $this->creationTime = $creationTime;
 

src/Responses/CreateMeetingResponse.php

@@ -25,102 +25,68 @@
  */
 class CreateMeetingResponse extends BaseResponse
 {
-    /**
-     * @return string
-     */
-    public function getMeetingId()
+    public function getMeetingId(): string
     {
         return $this->rawXml->meetingID->__toString();
     }
 
-    /**
-     * @return string
-     */
-    public function getInternalMeetingId()
+    public function getInternalMeetingId(): string
     {
         return $this->rawXml->internalMeetingID->__toString();
     }
 
-    /**
-     * @return string
-     */
-    public function getParentMeetingId()
+    public function getParentMeetingId(): string
     {
         return $this->rawXml->parentMeetingID->__toString();
     }
 
-    /**
-     * @return string
-     */
-    public function getAttendeePassword()
+    public function getAttendeePassword(): string
     {
         return $this->rawXml->attendeePW->__toString();
     }
 
-    /**
-     * @return string
-     */
-    public function getModeratorPassword()
+    public function getModeratorPassword(): string
     {
         return $this->rawXml->moderatorPW->__toString();
     }
 
     /**
      * Creation timestamp.
-     *
-     * @return float
      */
-    public function getCreationTime()
+    public function getCreationTime(): float
     {
         return (float) $this->rawXml->createTime;
     }
 
-    /**
-     * @return int
-     */
-    public function getVoiceBridge()
+    public function getVoiceBridge(): int
     {
         return (int) $this->rawXml->voiceBridge;
     }
 
-    /**
-     * @return string
-     */
-    public function getDialNumber()
+    public function getDialNumber(): string
     {
         return $this->rawXml->dialNumber->__toString();
     }
 
     /**
      * Creation date at the format "Sun Jan 17 18:20:07 EST 2016".
-     *
-     * @return string
      */
-    public function getCreationDate()
+    public function getCreationDate(): string
     {
         return $this->rawXml->createDate->__toString();
     }
 
-    /**
-     * @return bool
-     */
-    public function hasUserJoined()
+    public function hasUserJoined(): bool
     {
         return 'true' === $this->rawXml->hasUserJoined->__toString();
     }
 
-    /**
-     * @return int
-     */
-    public function getDuration()
+    public function getDuration(): int
     {
         return (int) $this->rawXml->duration;
     }
 
-    /**
-     * @return null|bool
-     */
-    public function hasBeenForciblyEnded()
+    public function hasBeenForciblyEnded(): bool
     {
         return 'true' === $this->rawXml->hasBeenForciblyEnded->__toString();
     }

tests/BigBlueButtonTest.php

@@ -21,6 +21,7 @@
 namespace BigBlueButton;
 
 use BigBlueButton\Core\ApiMethod;
+use BigBlueButton\Parameters\CreateMeetingParameters;
 use BigBlueButton\Parameters\DeleteRecordingsParameters;
 use BigBlueButton\Parameters\EndMeetingParameters;
 use BigBlueButton\Parameters\GetMeetingInfoParameters;
@@ -197,19 +198,33 @@ public function testCreateJoinMeetingUrl(): void
      */
     public function testJoinMeeting(): void
     {
+        // create a meeting that can be joined
+        $createMeetingParameters = new CreateMeetingParameters($this->faker->uuid(), $this->faker->word());
+        $createMeetingResponse   = $this->bbb->createMeeting($createMeetingParameters);
+
+        // prepare to join the meeting
         $joinMeetingParams = $this->generateJoinMeetingParams();
         $joinMeetingMock   = $this->getJoinMeetingMock($joinMeetingParams);
         $joinMeetingMock->setRedirect(false);
 
-        $joinMeeting = $this->bbb->joinMeeting($joinMeetingMock);
-
-        $this->assertEquals('SUCCESS', $joinMeeting->getReturnCode());
-        $this->assertTrue($joinMeeting->success());
-        $this->assertNotEmpty($joinMeeting->getAuthToken());
-        $this->assertNotEmpty($joinMeeting->getUserId());
-        $this->assertNotEmpty($joinMeeting->getSessionToken());
-        $this->assertNotEmpty($joinMeeting->getGuestStatus());
-        $this->assertNotEmpty($joinMeeting->getUrl());
+        // adapt to join the above created meeting
+        $joinMeetingMock->setMeetingId($createMeetingResponse->getMeetingId());
+        $joinMeetingMock->setCreationTime($createMeetingResponse->getCreationTime());
+
+        // join the meeting
+        $joinMeetingResponse = $this->bbb->joinMeeting($joinMeetingMock);
+
+        $this->assertEquals(
+            'SUCCESS',
+            $joinMeetingResponse->getReturnCode(),
+            $joinMeetingResponse->getRawXml()->message->__toString()
+        );
+        $this->assertTrue($joinMeetingResponse->success());
+        $this->assertNotEmpty($joinMeetingResponse->getAuthToken());
+        $this->assertNotEmpty($joinMeetingResponse->getUserId());
+        $this->assertNotEmpty($joinMeetingResponse->getSessionToken());
+        $this->assertNotEmpty($joinMeetingResponse->getGuestStatus());
+        $this->assertNotEmpty($joinMeetingResponse->getUrl());
     }
 
     // End Meeting