Skip to content

Commit 413f74e

Browse files
committed
multiple fixes to insert document endpoint
1 parent bc5d8fd commit 413f74e

File tree

2 files changed

+4
-11
lines changed

2 files changed

+4
-11
lines changed

src/BigBlueButton.php

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -511,12 +511,11 @@ public function getInsertDocumentUrl(InsertDocumentParameters $insertDocumentPar
511511
}
512512

513513
/**
514-
* @return CreateMeetingResponse
515514
* @throws NetworkException
516515
* @throws ParsingException
517516
* @throws RuntimeException
518517
*/
519-
public function insertDocument(InsertDocumentParameters $insertDocumentParams): InsertDocumentReponse
518+
public function insertDocument(InsertDocumentParameters $insertDocumentParams): InsertDocumentResponse
520519
{
521520
$xml = $this->processXmlResponse($this->getInsertDocumentUrl($insertDocumentParams), $insertDocumentParams->getPresentationsAsXML());
522521

src/Parameters/InsertDocumentParameters.php

Lines changed: 3 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -34,16 +34,13 @@ final class InsertDocumentParameters extends MetaParameters
3434
/**
3535
* @var array
3636
*/
37-
protected $presentations = [];
37+
private $presentations = [];
3838

3939
public function __construct(string $meetingID)
4040
{
4141
$this->meetingID = $meetingID;
4242
}
4343

44-
/**
45-
* @return CreateMeetingParameters
46-
*/
4744
public function addPresentation(string $url, string $filename, ?bool $downloadable = null, ?bool $removable = null): self
4845
{
4946
$this->presentations[$url] = [
@@ -55,12 +52,9 @@ public function addPresentation(string $url, string $filename, ?bool $downloadab
5552
return $this;
5653
}
5754

58-
/**
59-
* @return array
60-
*/
61-
public function getPresentations(): array
55+
public function removePresentation(string $url): void
6256
{
63-
return $this->presentations;
57+
unset($this->presentations[$url]);
6458
}
6559

6660
/**

0 commit comments

Comments
 (0)