make phpstan happy

Author: DigitalTimK

src/Parameters/BaseParameters.php

@@ -25,9 +25,6 @@
  */
 abstract class BaseParameters
 {
-    /**
-     * @return string
-     */
     abstract public function getHTTPQuery(): string;
 
     /**

src/Parameters/MetaParameters.php

@@ -40,8 +40,10 @@ public function getMeta(string $key)
 
     /**
      * @param mixed $value
+     *
+     * @return $this
      */
-    public function addMeta(string $key, $value): MetaParameters
+    public function addMeta(string $key, $value)
     {
         $this->meta[$key] = $value;
 

src/Parameters/UserDataParameters.php

@@ -37,8 +37,10 @@ public function getUserData(string $key)
 
     /**
      * @param mixed $value
+     *
+     * @return $this
      */
-    public function addUserData(string $key, $value): UserDataParameters
+    public function addUserData(string $key, $value): self
     {
         $this->userData[$key] = $value;
 

src/Responses/BaseJsonResponse.php

@@ -46,10 +46,7 @@ public function getRawJson()
         return json_encode($this->data);
     }
 
-    /**
-     * @return null|mixed
-     */
-    public function getMessage()
+    public function getMessage(): ?string
     {
         if ($this->failed()) {
             return $this->data->response->message;
@@ -58,10 +55,7 @@ public function getMessage()
         return null;
     }
 
-    /**
-     * @return null|mixed
-     */
-    public function getMessageKey()
+    public function getMessageKey(): ?string
     {
         if ($this->failed()) {
             return $this->data->response->messageKey;
@@ -71,9 +65,11 @@ public function getMessageKey()
     }
 
     /**
-     * @return mixed
+     * Return will be either 'SUCCESS' or 'FAILED' (nothing else).
+     *
+     * @see: https://docs.bigbluebutton.org/development/api/#api-calls
      */
-    public function getReturnCode()
+    public function getReturnCode(): string
     {
         return $this->data->response->returncode;
     }

tests/TestCase.php

@@ -357,11 +357,11 @@ protected function getJoinMeetingMock(array $params): JoinMeetingParameters
             ->setUserId($params['userId'])
             ->setWebVoiceConf($params['webVoiceConf'])
             ->setCreationTime($params['creationTime'])
-            ->addUserData('countrycode', $params['userdata_countrycode'])
             ->setRole($params['role'])
+            ->setExcludeFromDashboard($params['excludeFromDashboard'])
+            ->addUserData('countrycode', $params['userdata_countrycode'])
             ->addUserData('email', $params['userdata_email'])
             ->addUserData('commercial', $params['userdata_commercial'])
-            ->setExcludeFromDashboard($params['excludeFromDashboard'])
         ;
     }