Skip to content

Commit 5e0bafa

Browse files
committed
Delete joinViaHTML5 client param in join API.
1 parent 3b58634 commit 5e0bafa

File tree

3 files changed

+4
-27
lines changed

3 files changed

+4
-27
lines changed

src/Parameters/JoinMeetingParameters.php

Lines changed: 0 additions & 25 deletions
Original file line numberDiff line numberDiff line change
@@ -73,11 +73,6 @@ class JoinMeetingParameters extends UserDataParameters
7373
*/
7474
private $clientURL;
7575

76-
/**
77-
* @var boolean
78-
*/
79-
private $joinViaHtml5;
80-
8176
/**
8277
* @var array
8378
*/
@@ -294,25 +289,6 @@ public function setClientURL($clientURL)
294289
return $this;
295290
}
296291

297-
/**
298-
* @return boolean
299-
*/
300-
public function isJoinViaHtml5()
301-
{
302-
return $this->joinViaHtml5;
303-
}
304-
305-
/**
306-
* @param boolean $joinViaHtml5
307-
* @return JoinMeetingParameters
308-
*/
309-
public function setJoinViaHtml5($joinViaHtml5)
310-
{
311-
$this->joinViaHtml5 = $joinViaHtml5;
312-
313-
return $this;
314-
}
315-
316292
/**
317293
* @param string $paramName
318294
* @param string $paramValue
@@ -340,7 +316,6 @@ public function getHTTPQuery()
340316
'configToken' => $this->configToken,
341317
'avatarURL' => $this->avatarURL,
342318
'redirect' => $this->redirect ? 'true' : 'false',
343-
'joinViaHtml5' => $this->joinViaHtml5 ? 'true' : 'false',
344319
'clientURL' => $this->clientURL
345320
];
346321

src/Parameters/MetaParameters.php

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -51,6 +51,10 @@ public function addMeta($key, $value)
5151
return $this;
5252
}
5353

54+
/**
55+
* @param $queries
56+
* @return void
57+
*/
5458
protected function buildMeta(&$queries)
5559
{
5660
if (count($this->meta) !== 0) {

tests/Parameters/JoinMeetingParametersTest.php

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -45,14 +45,12 @@ public function testJoinMeetingParameters()
4545
$joinMeetingParams->setAvatarURL($avatarUrl = $this->faker->url);
4646
$joinMeetingParams->setRedirect($redirect = $this->faker->boolean(50));
4747
$joinMeetingParams->setClientURL($clientUrl = $this->faker->url);
48-
$joinMeetingParams->setJoinViaHtml5($joinViaHtml5 = $this->faker->boolean(50));
4948
$this->assertEquals($newId, $joinMeetingParams->getMeetingId());
5049
$this->assertEquals($newName, $joinMeetingParams->getUsername());
5150
$this->assertEquals($newPassword, $joinMeetingParams->getPassword());
5251
$this->assertEquals($configToken, $joinMeetingParams->getConfigToken());
5352
$this->assertEquals($avatarUrl, $joinMeetingParams->getAvatarURL());
5453
$this->assertEquals($redirect, $joinMeetingParams->isRedirect());
5554
$this->assertEquals($clientUrl, $joinMeetingParams->getClientURL());
56-
$this->assertEquals($joinViaHtml5, $joinMeetingParams->isJoinViaHtml5());
5755
}
5856
}

0 commit comments

Comments
 (0)